Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Update API docs generation script to comply with new docs format #109343

Merged
merged 5 commits into from
Aug 24, 2021
Merged

[ML] Update API docs generation script to comply with new docs format #109343

merged 5 commits into from
Aug 24, 2021

Conversation

darnautov
Copy link
Contributor

Summary

  • Updates the script with custom header required for new docs format
  • Bumps versions of apidoc and apidoc-markdown packages

@darnautov darnautov added :ml v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.16.0 labels Aug 19, 2021
@darnautov darnautov self-assigned this Aug 19, 2021
@darnautov darnautov requested a review from a team as a code owner August 19, 2021 20:36
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@jportner jportner mentioned this pull request Aug 20, 2021
Merged
2 tasks
@darnautov
Copy link
Contributor Author

@elasticmachine merge upstream

szabosteve
szabosteve approved these changes Aug 23, 2021
View reviewed changes
Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for these changes! Frontmatter LGTM!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @darnautov

peteharverson
peteharverson approved these changes Aug 23, 2021
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

@darnautov darnautov merged commit 20529be into elastic:master Aug 24, 2021
@darnautov darnautov deleted the ml-update-apidoc branch August 24, 2021 08:03
@darnautov darnautov added the auto-backport Deprecated - use backport:version if exact versions are needed label Aug 24, 2021
@kibanamachine kibanamachine mentioned this pull request Aug 24, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 24, 2021
@darnautov @kibanamachine
[ML] Update API docs generation script to comply with new docs format (…
0bf784f 
…elastic#109343)

* [ML] update deps

* [ML] fix script

* [ML] add header

* [ML] generate header
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Aug 24, 2021
@kibanamachine @darnautov
[ML] Update API docs generation script to comply with new docs format (…
f57fa6d 
…#109343) (#109781)

* [ML] update deps

* [ML] fix script

* [ML] add header

* [ML] generate header

Co-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@szabosteve szabosteve szabosteve approved these changes

@jgowdyelastic jgowdyelastic Awaiting requested review from jgowdyelastic

@qn895 qn895 Awaiting requested review from qn895

Assignees

@darnautov darnautov

Labels
auto-backport Deprecated - use backport:version if exact versions are needed :ml release_note:skip Skip the PR/issue when compiling release notes v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@darnautov @elasticmachine @kibanamachine @peteharverson @szabosteve