Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Remove Legacy Dashboard Only Mode #108103

Merged
Merged
Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
8f8a5d9
Remove all dashboard only mode code and tests. Align dashboard permis…
ThomThomson Aug 10, 2021
806784a
Removed translations, and additional references to dashboard_mode. Re…
ThomThomson Aug 10, 2021
503abdf
Merge branch 'master' of github.com:elastic/kibana into breaking/remo…
ThomThomson Aug 10, 2021
74a8664
Update api docs
ThomThomson Aug 10, 2021
8da67b9
Removed tests for showOnly. Fixed types
ThomThomson Aug 10, 2021
9dd82ab
Update jest tests and snapshots. Remove more dashboard_mode documenta…
ThomThomson Aug 11, 2021
841a6ca
Merge branch 'master' of github.com:elastic/kibana into breaking/remo…
ThomThomson Aug 12, 2021
378b71b
Merge branch 'master' of github.com:elastic/kibana into breaking/remo…
ThomThomson Aug 16, 2021
8f8a6d1
Merge branch 'master' of github.com:elastic/kibana into breaking/remo…
ThomThomson Aug 17, 2021
bb35015
dashboard reset to last saved state should always put app in view mode
ThomThomson Aug 17, 2021
1ca9f8e
remove exclusive suite
ThomThomson Aug 17, 2021
9157000
Remove tsconfig.refs
ThomThomson Aug 19, 2021
7755c4d
Merge branch 'master' into breaking/removeDashboardOnlyMode
kibanamachine Aug 19, 2021
1bf2842
Merge branch 'master' of github.com:elastic/kibana into breaking/remo…
ThomThomson Aug 19, 2021
637a527
Merge branch 'breaking/removeDashboardOnlyMode' of https://github.com…
ThomThomson Aug 19, 2021
a0963aa
Merge branch 'master' of github.com:elastic/kibana into breaking/remo…
ThomThomson Aug 20, 2021
428f33d
Merge branch 'master' into breaking/removeDashboardOnlyMode
kibanamachine Aug 20, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,6 @@
/x-pack/plugins/dashboard_enhanced/ @elastic/kibana-presentation
/x-pack/test/functional/apps/canvas/ @elastic/kibana-presentation
#CC# /src/plugins/kibana_react/public/code_editor/ @elastic/kibana-presentation
#CC# /x-pack/plugins/dashboard_mode @elastic/kibana-presentation

# Machine Learning
/x-pack/plugins/ml/ @elastic/ml-ui
Expand Down
238 changes: 0 additions & 238 deletions api_docs/dashboard_mode.json

This file was deleted.

32 changes: 0 additions & 32 deletions api_docs/dashboard_mode.mdx

This file was deleted.

4 changes: 0 additions & 4 deletions docs/developer/plugin-list.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -390,10 +390,6 @@ The client-side plugin configures following values:
|Adds drilldown capabilities to dashboard. Owned by the Kibana App team.


|{kib-repo}blob/{branch}/x-pack/plugins/dashboard_mode/README.md[dashboardMode]
|The deprecated dashboard only mode.


|{kib-repo}blob/{branch}/x-pack/plugins/data_enhanced/README.md[dataEnhanced]
|The data_enhanced plugin is the x-pack counterpart to the src/plguins/data plugin.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,4 @@ export interface ChromeNavLinks
| [getForceAppSwitcherNavigation$()](./kibana-plugin-core-public.chromenavlinks.getforceappswitchernavigation_.md) | An observable of the forced app switcher state. |
| [getNavLinks$()](./kibana-plugin-core-public.chromenavlinks.getnavlinks_.md) | Get an observable for a sorted list of navlinks. |
| [has(id)](./kibana-plugin-core-public.chromenavlinks.has.md) | Check whether or not a navlink exists. |
| [showOnly(id)](./kibana-plugin-core-public.chromenavlinks.showonly.md) | Remove all navlinks except the one matching the given id. |

This file was deleted.

1 change: 0 additions & 1 deletion packages/kbn-optimizer/limits.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ pageLoadAssetSize:
crossClusterReplication: 65408
dashboard: 374194
dashboardEnhanced: 65646
dashboardMode: 22716
data: 824229
dataEnhanced: 50420
devTools: 38637
Expand Down
1 change: 0 additions & 1 deletion src/core/public/chrome/chrome_service.mock.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ const createStartContractMock = () => {
has: jest.fn(),
get: jest.fn(),
getAll: jest.fn(),
showOnly: jest.fn(),
enableForcedAppSwitcherNavigation: jest.fn(),
getForceAppSwitcherNavigation$: jest.fn(),
},
Expand Down
Loading