-
Notifications
You must be signed in to change notification settings - Fork 8.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Cases] Fix flakiness in
all_cases_list.test.tsx
(#157285)
## Summary This PR fixes the flaky tests in `x-pack/plugins/cases/public/components/all_cases/all_cases_list.test.tsx`. It modifies the `getComputedStyle` to be more performant. For more information see https://blog.sentry.io/sentrys-frontend-tests-migrating-from-enzyme-to-react-testing-library and jsdom/jsdom#3234. I run the test multiple times on CI to ensure that the test is not flaky anymore: Specifically: - Test run 50 times in ccf2716 - Test run 40 times in c56c650 - Test run 50 times in b04d613 - Test run 50 times in e0ef292 - Test run 55 times in 1ba6bac Fixes: #148096, #150923 ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
- Loading branch information
1 parent
80edb84
commit b782df8
Showing
1 changed file
with
94 additions
and
102 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters