[Cases] Fix flakiness in all_cases_list.test.tsx
#157285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnasikas
added
release_note:skip
|
@elasticmachine merge upstream |
cnasikas
changed the title
all_cases_list.test.tsx
|
Pinging @elastic/response-ops (Team:ResponseOps) |
|
Pinging @elastic/response-ops-cases (Feature:Cases) |
js-jankisalvi
approved these changes
May 15, 2023
| @@ -705,7 +739,7 @@ describe.skip('AllCasesListGeneric', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| describe('Actions', () => { | |||
| describe.each(Array(55).fill(null))('Actions', () => { | |||
There was a problem hiding this comment.
don't forget to remove it before merge 😄
| // The JSDOM implementation is too slow | ||
| // Especially for dropdowns that try to position themselves | ||
| // perf issue - https://github.com/jsdom/jsdom/issues/3234 | ||
| Object.defineProperty(window, 'getComputedStyle', { |
There was a problem hiding this comment.
Great finding!! 👏
perhaps we could try the same for xpack/plugins/cases/public/components/case_view/components/ case_view_activity.test.tsx component as well.
There was a problem hiding this comment.
@jcger told me about it! Yes I try to improve the case_view_activity.test.tsx on another PR.
Why not use the flaky test runner? |
Unfortunately, the flaky test runner does not support unit tests. |
adcoelho
approved these changes
May 15, 2023
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
jasonrhodes
pushed a commit
that referenced
this pull request
May 17, 2023
## Summary This PR fixes the flaky tests in `x-pack/plugins/cases/public/components/all_cases/all_cases_list.test.tsx`. It modifies the `getComputedStyle` to be more performant. For more information see https://blog.sentry.io/sentrys-frontend-tests-migrating-from-enzyme-to-react-testing-library and jsdom/jsdom#3234. I run the test multiple times on CI to ensure that the test is not flaky anymore: Specifically: - Test run 50 times in ccf2716 - Test run 40 times in c56c650 - Test run 50 times in b04d613 - Test run 50 times in e0ef292 - Test run 55 times in 1ba6bac Fixes: #148096, #150923 ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the flaky tests in
x-pack/plugins/cases/public/components/all_cases/all_cases_list.test.tsx. It modifies thegetComputedStyleto be more performant. For more information see https://blog.sentry.io/sentrys-frontend-tests-migrating-from-enzyme-to-react-testing-library and jsdom/jsdom#3234.I run the test multiple times on CI to ensure that the test is not flaky anymore: Specifically:
Fixes: #148096, #150923
Checklist
Delete any items that are not applicable to this PR.
For maintainers