switch from sleeps to waiting for visualize-legend.

Fixes #5932
elastic · Jan 19, 2016 · c25bc1f · c25bc1f
1 parent c9f9ad5
commit c25bc1f
Show file tree

Hide file tree

Showing 8 changed files with 23 additions and 17 deletions.
diff --git a/test/functional/apps/visualize/_area_chart.js b/test/functional/apps/visualize/_area_chart.js
@@ -118,8 +118,8 @@ define(function (require) {
             common.debug('Waiting...');
             return headerPage.getSpinnerDone();
           })
-          .then(function sleep() {
-            return common.sleep(4000);
+          .then(function waitForVisualization() {
+            return visualizePage.waitForVisualization();
           })
           .then(function takeScreenshot() {
             common.debug('Take screenshot');

diff --git a/test/functional/apps/visualize/_data_table.js b/test/functional/apps/visualize/_data_table.js
@@ -104,8 +104,8 @@ define(function (require) {
           .then(function () {
             return visualizePage.loadSavedVisualization(vizName1);
           })
-          .then(function sleep() {
-            return common.sleep(4000);
+          .then(function waitForVisualization() {
+            return visualizePage.waitForVisualization();
           })
           .then(function takeScreenshot() {
             common.debug('Take screenshot');

diff --git a/test/functional/apps/visualize/_line_chart.js b/test/functional/apps/visualize/_line_chart.js
@@ -104,8 +104,8 @@ define(function (require) {
           .then(function () {
             return visualizePage.loadSavedVisualization(vizName1);
           })
-          .then(function sleep() {
-            return common.sleep(4000);
+          .then(function waitForVisualization() {
+            return visualizePage.waitForVisualization();
           })
           .then(function takeScreenshot() {
             // take a snapshot just as an example.

diff --git a/test/functional/apps/visualize/_pie_chart.js b/test/functional/apps/visualize/_pie_chart.js
@@ -111,8 +111,8 @@ define(function (require) {
           .then(function () {
             return visualizePage.loadSavedVisualization(vizName1);
           })
-          .then(function sleep() {
-            return common.sleep(4000);
+          .then(function waitForVisualization() {
+            return visualizePage.waitForVisualization();
           })
           .then(function takeScreenshot() {
             common.debug('Take screenshot');

diff --git a/test/functional/apps/visualize/_tile_map.js b/test/functional/apps/visualize/_tile_map.js
@@ -104,8 +104,8 @@ define(function (require) {
           .then(function () {
             return visualizePage.loadSavedVisualization(vizName1);
           })
-          .then(function sleep() {
-            return common.sleep(4000);
+          .then(function waitForVisualization() {
+            return visualizePage.waitForVisualization();
           })
           .then(function takeScreenshot() {
             common.debug('Take screenshot');

diff --git a/test/functional/apps/visualize/_vertical_bar_chart.js b/test/functional/apps/visualize/_vertical_bar_chart.js
@@ -80,8 +80,8 @@ define(function (require) {
         .then(function () {
           return headerPage.getSpinnerDone(); // only matches the hidden spinner
         })
-        .then(function sleep() {
-          return common.sleep(1000);
+        .then(function waitForVisualization() {
+          return visualizePage.waitForVisualization();
         });
       });
 
@@ -109,8 +109,8 @@ define(function (require) {
           .then(function () {
             return headerPage.getSpinnerDone(); // only matches the hidden spinner
           })
-          .then(function sleep() {
-            return common.sleep(4000);
+          .then(function waitForVisualization() {
+            return visualizePage.waitForVisualization();
           })
           .then(function takeScreenshot() {
             common.debug('Take screenshot');

diff --git a/test/intern.js b/test/intern.js
@@ -13,9 +13,9 @@ define(function (require) {
     }],
     tunnelOptions: serverConfig.servers.webdriver,
     functionalSuites: [
-      'test/functional/status_page/index',
-      'test/functional/apps/settings/index',
-      'test/functional/apps/discover/index',
+      // 'test/functional/status_page/index',
+      // 'test/functional/apps/settings/index',
+      // 'test/functional/apps/discover/index',
       'test/functional/apps/visualize/index'
     ],
     excludeInstrumentation: /(fixtures|node_modules)\//,

diff --git a/test/support/pages/VisualizePage.js b/test/support/pages/VisualizePage.js
@@ -673,6 +673,12 @@ define(function (require) {
       });
     },
 
+    waitForVisualization: function waitForVisualization() {
+      return this.remote
+      .setFindTimeout(defaultTimeout)
+      .findByCssSelector('visualize-legend');
+    }
+
   };
 
   return VisualizePage;