Initial test to see if screenshot timing is the prob.

[LeeDr]

Initial test to see if screenshot timing is the prob.

[LeeDr]

I know we don't want fragile sleep's in the tests but 4 seconds before each screenshot fixes the problems where the actual charts were blank. Examples here;
http://build-eu-00.elastic.co/job/kibana_core_pr/1770/s3/

[jbudz]

As a less fragile alternative would a tryForTime until the chart appears be possible?

[LeeDr]

@jbudz I could, but I don't have one generic method to get chart data as it depends on the type of chart. So each test would have to tryForTime a call to get the chart data for that chart type and test that the size of the returned data > 0. And what I realize now, is that the tests for getting the chart data do not have a tryForTime, but they work because they come after these 'save, load, screenshot' tests and the charts are done loading by that time.

[jbudz]

If screenshots need to get working, and the sleeps aren't part of the pass/fail testing, I'm not going to be overly picky. A comment explaining why the sleep needs to happen might be useful. The changes without 9157cf7 LGTM

[LeeDr]

I had to use a short sleep in a couple of cases. I added comments for them.

[elasticsearch-bot]

Lee Drengenberg merged this into the following branches!

Branch	Commits
master	4c5f822, d41f985, e2face2, 967cc0c, c0d049c, f480b9b, df6c34f, 540ca8e, 6673721, 86ab222, 40f8450
4.x	1b13204, bc9ffa3, c9f9ad5, c25bc1f, ff033eb, 1f7936c, a9d2d83, 6654e50, f68c78b, 38578ad, 55c46f3