Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] MVP for the new Security side navigation #130023

Closed
semd opened this issue Apr 12, 2022 · 1 comment
Closed

[Security Solution] MVP for the new Security side navigation #130023

semd opened this issue Apr 12, 2022 · 1 comment
Assignees
Labels
Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team

Comments

@semd
Copy link
Contributor

semd commented Apr 12, 2022

Summary

Design: https://www.figma.com/file/5nmBlNVjUNFgsprHkZ8nzg/Navigation
Specs Document: https://docs.google.com/document/d/1_uGeDa_J1cJo0UBfmgnfeqv6e3GCFeb8XnsET2EofCE/edit?usp=sharing

Implement the new navigation design for Security Solution:

nav_mockup

Specifications

It will be added under a feature flag (enabled by default) and an advanced settings toggle (disabled by default).

The main navigation items:

  • Items must always have a URL
  • Items can have "active" and "hover" states:
    • "active" -> primary color background + primary color text + bold
    • "focus" -> primary color background + default text
  • Items may or may not have sub navigations items:

Main nav items without sub nav:

item_without_subnav

  • It must have a text link to navigate to the nav item URL
  • It must not have a sub-menu toggle button
  • It must have "active" state when the item URL matches the current page URL
  • It must have "focus" state when it is focused or hovered

Main nav items with sub nav items:

item_with_subnav

  • It must have a icon button on the right side to toggle the sub-menu panel
  • It must have "active" state when its item URL or any sub-item URL matches the current page URL
  • It must have "focus" state when it is focused or hovered
  • It must have "focus" state when its secondary navigation menu is open

Sub-menu panel

sub_nav_panel

  • It must show a link label and a description (not clickable) for each item.
  • It must navigate to the link URL and close the sub-menu when any link is clicked.
  • It must show a scroll bar if content overflows vertically
  • When the sub-menu is open:
    • It must close on outside click
    • It must close when the same main nav toggle button is clicked
    • It must change content when other main nav toggle button is clicked
  • When the sub-menu is closed:
    • It must open when any toggle icon button is clicked

Steps:

  1. Implement prototype [Prototype] Security nav next-eui-starter#61
  2. Integrate the new implementation within Kibana and Security plugin, wire all props.

We will also refactor the link config files, to create a single source of truth in Security plugin, to make it easier to add/remove/update pages.

The landing pages for all grouped sections will be implemented in: #130565

PRs:

@botelastic botelastic bot added the needs-team Issues missing a team label label Apr 12, 2022
@semd semd added Team:Threat Hunting Security Solution Threat Hunting Team Team:Threat Hunting:Explore labels Apr 12, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Apr 12, 2022
@semd semd self-assigned this Apr 25, 2022
@semd semd changed the title [Security Solution][POC] New side navigation with secondary menu [Security Solution] MVP for the new Security side navigation Apr 28, 2022
@semd semd closed this as completed Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team
Projects
None yet
Development

No branches or pull requests

2 participants