[Security Solution] New navigation panel bottom padding fix #132951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semd
added
bug
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
semd
commented
May 25, 2022
Comment on lines
+36
to
+38
| const wrapper = mount(Component); | ||
| await waitFor(() => wrapper.find('[data-test-subj="queryInput"]').exists()); // check for presence of query input | ||
| return wrapper; |
There was a problem hiding this comment.
unrelated, just fixing a flaky test that was failing randomly
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
semd
added
the
auto-backport
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
pushed a commit
that referenced
this pull request
May 26, 2022
* fix panel nav bottom padding when index does not exist * fix unrelated flacky test * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 159fe79)
💔 Build FailedFailed CI StepsMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @semd |
kibanamachine
added a commit
that referenced
this pull request
May 26, 2022
…#133006) * fix panel nav bottom padding when index does not exist * fix unrelated flacky test * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 159fe79) Co-authored-by: Sergi Massaneda <sergi.massaneda@elastic.co> Co-authored-by: Spencer <spencer@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
issue: #130023
The bug appears when the instance is new and the timeline indices do not yet exist.
before:
after:
The padding was added to the navigation panel based on the location path flag defined in the static config, but the timeline bottom bar is also hidden if the index does not exist, which was not checked by the
showTimelinehook.I just moved the logic of checking the dataView values from the
bottom_barto theshowTimelinehook, so the navigation will also consider this case when adding the padding.Checklist