Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Manage landing page #131245

Merged
merged 2 commits into from
May 4, 2022
Merged

Create Manage landing page #131245

merged 2 commits into from
May 4, 2022

Conversation

machadoum
Copy link
Member

@machadoum machadoum commented Apr 29, 2022 •
edited
Loading

Summary

Create Manage landing page /app/security/manage.

Screenshot 2022-04-29 at 16 18 30

Checklist

@machadoum machadoum added release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore v8.3.0 labels Apr 29, 2022
@machadoum machadoum self-assigned this Apr 29, 2022
@machadoum machadoum marked this pull request as ready for review April 29, 2022 14:50
@machadoum machadoum requested a review from a team as a code owner April 29, 2022 14:50
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@machadoum machadoum force-pushed the siem-explore-issue-130565-2 branch 3 times, most recently from e8e85f2 to b4e129a Compare May 2, 2022 07:53
@machadoum machadoum requested review from bfishel and semd May 2, 2022 09:18
@machadoum machadoum force-pushed the siem-explore-issue-130565-2 branch from b4e129a to ede8b06 Compare May 3, 2022 13:24
@machadoum machadoum requested a review from semd May 3, 2022 13:24
@machadoum machadoum force-pushed the siem-explore-issue-130565-2 branch from ede8b06 to 6950606 Compare May 3, 2022 15:25
semd
semd approved these changes May 3, 2022
View reviewed changes
Copy link
Contributor

@semd semd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

YulNaumenko
YulNaumenko approved these changes May 3, 2022
View reviewed changes
Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@machadoum
Copy link
Member Author

@elasticmachine merge upstream

@machadoum machadoum enabled auto-merge (squash) May 4, 2022 08:11
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 2787 2796 +9

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 4.8MB 4.8MB +13.6KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 249.2KB 249.3KB +75.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @machadoum

@machadoum machadoum merged commit 78d6ace into elastic:main May 4, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 4, 2022
dmlemeshko pushed a commit to dmlemeshko/kibana that referenced this pull request May 5, 2022
@machadoum @kibanamachine @dmlemeshko
Create Manage landing page (elastic#131245)
bb4e788 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@semd semd mentioned this pull request May 17, 2022
Closed
kertal pushed a commit to kertal/kibana that referenced this pull request May 24, 2022
@machadoum @kibanamachine @kertal
Create Manage landing page (elastic#131245)
60fc1ee 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semd semd semd approved these changes

@YulNaumenko YulNaumenko YulNaumenko approved these changes

@bfishel bfishel Awaiting requested review from bfishel

Assignees

@machadoum machadoum

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@machadoum @elasticmachine @kibana-ci @semd @YulNaumenko @kibanamachine