Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset to default button is not functioning on Discover page and also hides on custom option sometimes. #131130

Closed
ghost opened this issue Apr 28, 2022 · 5 comments · Fixed by #157269
Closed

Reset to default button is not functioning on Discover page and also hides on custom option sometimes. #131130

ghost opened this issue Apr 28, 2022 · 5 comments · Fixed by #157269
Labels
blocked bug Fixes for quality problems that affect the customer experience impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) v8.2.0

Comments

@ghost
Copy link

ghost commented Apr 28, 2022

Describe the bug
Reset to default button is not functioning on Discover page and also hides on custom option sometimes.

Build Details:
Version: 8.2.0 BC4
Build: 52005
Commit: 9a5003d

Preconditions

  1. Elasticsearch should be up and running
  2. Kibana should be up and running
  3. Agent or any beats should be installed.

Steps to Reproduce

  1. Navigate to Analytics-->Discover.
  2. Select any Data View.
  3. Click on Display options button for the data hits.
  4. Select any option "Single" ,"Autofit" or "Custom"
  5. Click on Reset to Default button.

Actual Result
Reset to Default button is not working and also hides after clicking under custom option.

Expected Result
Reset to Default button Should work and also does not hide after clicking under custom option.

Screen records:

Discover.-.Elastic.-.Google.Chrome.2022-04-28.13-03-20.mp4
@ghost ghost added bug Fixes for quality problems that affect the customer experience impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. v8.2.0 labels Apr 28, 2022
@ghost ghost self-assigned this Apr 28, 2022
@botelastic botelastic bot added the needs-team Issues missing a team label label Apr 28, 2022
@ghost ghost removed their assignment Apr 28, 2022
@ghost
Copy link
Author

ghost commented Apr 28, 2022 •
edited by ghost
Loading

Hi @MadameSheema ,

Please help us to assign this bug to the right team.

Thanks !

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Apr 28, 2022
@jloleysens jloleysens added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Aug 9, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@Heenawter Heenawter added Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) and removed Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Feb 8, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal kertal added the blocked label Feb 8, 2023
@kertal
Copy link
Member

kertal commented Feb 8, 2023

Blocked by elastic/eui#5593

@jughosta jughosta mentioned this issue Aug 17, 2023
Merged
@davismcphee davismcphee added the loe:small Small Level of Effort label Sep 8, 2023
jughosta added a commit that referenced this issue Sep 12, 2023
@jughosta @kibanamachine
[Discover] Set data table row height to auto-fit by default (#164218)
0f07497 
- Closes #164285

This PR changes the default value of "rowHeight" setting to be
"Auto-fit".

<img width="600" alt="Screenshot 2023-08-17 at 19 46 03"
src="https://github.com/elastic/kibana/assets/1415710/44cc2cc6-8bbd-41a9-b34c-94a189edbd7b">

When testing, make sure to delete "discover:dataGridRowHeight" from the
browser localStorage, refresh the page and press "New" in Discover.

Partially addresses #131130 (it
can still hide "Reset" after page reload)

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This was referenced Oct 10, 2023
Merged
Merged
jughosta added a commit that referenced this issue Oct 19, 2023
@jughosta
[OnWeek][Discover] Allow to change current sample size and save it wi…
6038f92 
…th a saved search (#157269)

- Closes #94140
- #11758
- #4060
- #3220
- #23307
- Closes #131130 

## Summary

This PR allows to change current sample size right from Discover page,
no need to modify the global default value.

Saved search panels on Dashboard will also use the saved value to fetch
only the requested sample size. This customisation was requested by many
customers as it will allow to load Dashboards faster.

Current range for the slider: from 10 to 1000 (with a step 10).

<img width="400" alt="Screenshot 2023-10-09 at 11 10 52"
src="https://github.com/elastic/kibana/assets/1415710/74e2e4ad-9929-4a44-8d85-c2baafccbaa6">


### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
benakansara pushed a commit to benakansara/kibana that referenced this issue Oct 22, 2023
@jughosta @benakansara
[OnWeek][Discover] Allow to change current sample size and save it wi…
df2607f 
…th a saved search (elastic#157269)

- Closes elastic#94140
- elastic#11758
- elastic#4060
- elastic#3220
- elastic#23307
- Closes elastic#131130 

## Summary

This PR allows to change current sample size right from Discover page,
no need to modify the global default value.

Saved search panels on Dashboard will also use the saved value to fetch
only the requested sample size. This customisation was requested by many
customers as it will allow to load Dashboards faster.

Current range for the slider: from 10 to 1000 (with a step 10).

<img width="400" alt="Screenshot 2023-10-09 at 11 10 52"
src="https://github.com/elastic/kibana/assets/1415710/74e2e4ad-9929-4a44-8d85-c2baafccbaa6">


### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
benakansara pushed a commit to benakansara/kibana that referenced this issue Oct 22, 2023
@jughosta @benakansara
[OnWeek][Discover] Allow to change current sample size and save it wi…
e98658b 
…th a saved search (elastic#157269)

- Closes elastic#94140
- elastic#11758
- elastic#4060
- elastic#3220
- elastic#23307
- Closes elastic#131130 

## Summary

This PR allows to change current sample size right from Discover page,
no need to modify the global default value.

Saved search panels on Dashboard will also use the saved value to fetch
only the requested sample size. This customisation was requested by many
customers as it will allow to load Dashboards faster.

Current range for the slider: from 10 to 1000 (with a step 10).

<img width="400" alt="Screenshot 2023-10-09 at 11 10 52"
src="https://github.com/elastic/kibana/assets/1415710/74e2e4ad-9929-4a44-8d85-c2baafccbaa6">


### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked bug Fixes for quality problems that affect the customer experience impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) v8.2.0
Projects
None yet
Milestone
No milestone
6 participants
@kertal @jloleysens @Heenawter @elasticmachine @MadameSheema @davismcphee