Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Selector for amount of records displayed #94140

Closed
shaunmcgough opened this issue Mar 9, 2021 · 2 comments · Fixed by #157269
Closed

[Discover] Selector for amount of records displayed #94140

shaunmcgough opened this issue Mar 9, 2021 · 2 comments · Fixed by #157269
Assignees
Labels
enhancement New value added to drive a business result Feature:Discover Discover Application impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph)

Comments

@shaunmcgough
Copy link

Currently, Discover limits the results set for Discover to 500 records, and while this works in some use cases, it eliminates key records in others. It would be nice to have a selector (perhaps a sliders from 1 - ALL) that the user can adjust, leave the default at 500, and allow people to change the results set easily.

@kertal FYI.

@shaunmcgough shaunmcgough added Feature:Discover Discover Application enhancement New value added to drive a business result labels Mar 9, 2021
@kertal kertal added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Mar 10, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@timroes timroes added Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Aug 31, 2021
@lukasolson lukasolson added loe:medium Medium Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Dec 13, 2022
@lukasolson
Copy link
Member

Just an FYI that there is an advanced setting to configure this (discover:sampleSize):

image

Agreed that it would be nicer if it was configurable from the table itself.

@jughosta jughosta self-assigned this May 10, 2023
jughosta added a commit that referenced this issue Oct 19, 2023
…th a saved search (#157269)

- Closes #94140
- #11758
- #4060
- #3220
- #23307
- Closes #131130 

## Summary

This PR allows to change current sample size right from Discover page,
no need to modify the global default value.

Saved search panels on Dashboard will also use the saved value to fetch
only the requested sample size. This customisation was requested by many
customers as it will allow to load Dashboards faster.

Current range for the slider: from 10 to 1000 (with a step 10).

<img width="400" alt="Screenshot 2023-10-09 at 11 10 52"
src="https://github.com/elastic/kibana/assets/1415710/74e2e4ad-9929-4a44-8d85-c2baafccbaa6">


### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
benakansara pushed a commit to benakansara/kibana that referenced this issue Oct 22, 2023
…th a saved search (elastic#157269)

- Closes elastic#94140
- elastic#11758
- elastic#4060
- elastic#3220
- elastic#23307
- Closes elastic#131130 

## Summary

This PR allows to change current sample size right from Discover page,
no need to modify the global default value.

Saved search panels on Dashboard will also use the saved value to fetch
only the requested sample size. This customisation was requested by many
customers as it will allow to load Dashboards faster.

Current range for the slider: from 10 to 1000 (with a step 10).

<img width="400" alt="Screenshot 2023-10-09 at 11 10 52"
src="https://github.com/elastic/kibana/assets/1415710/74e2e4ad-9929-4a44-8d85-c2baafccbaa6">


### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
benakansara pushed a commit to benakansara/kibana that referenced this issue Oct 22, 2023
…th a saved search (elastic#157269)

- Closes elastic#94140
- elastic#11758
- elastic#4060
- elastic#3220
- elastic#23307
- Closes elastic#131130 

## Summary

This PR allows to change current sample size right from Discover page,
no need to modify the global default value.

Saved search panels on Dashboard will also use the saved value to fetch
only the requested sample size. This customisation was requested by many
customers as it will allow to load Dashboards faster.

Current range for the slider: from 10 to 1000 (with a step 10).

<img width="400" alt="Screenshot 2023-10-09 at 11 10 52"
src="https://github.com/elastic/kibana/assets/1415710/74e2e4ad-9929-4a44-8d85-c2baafccbaa6">


### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Discover Discover Application impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph)
Projects
None yet
6 participants