[ResponseOps] do we need to display info for rules with user-managed API keys? #154581
Assignees
Labels
Feature:Alerting/RulesManagement
Issues related to the Rules Management UX
Team:ResponseOps
Label for the ResponseOps team (formerly the Cases and Alerting teams)
Comments
pmuellr
added
Team:ResponseOps
|
Pinging @elastic/response-ops (Team:ResponseOps) |
|
@shanisagiv1 @mdefazio |
Seems reasonable.
Perhaps the link out should be behind a popover/click or something—thinking we would need to make it clear where the link would go
I would vote against this. Seems like too much detail at this level. |
|
I'd say that the first option will provide the details for users to keep checking the details if they're willing to.. I'd not invest more in the other 2 for now.. |
ersin-erdal
added a commit
that referenced
this issue
May 15, 2023
…eated by users (#155699) Resolves: #154581 This PR adds 'user-managed' label next to the API key owner name when the API key is created by the user. <img width="813" alt="Screenshot 2023-05-06 at 19 02 08" src="https://user-images.githubusercontent.com/92688503/236637767-d0c0ee00-1314-4824-b97a-b7bdf1b7f43b.png">
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
May 15, 2023
…eated by users (elastic#155699) Resolves: elastic#154581 This PR adds 'user-managed' label next to the API key owner name when the API key is created by the user. <img width="813" alt="Screenshot 2023-05-06 at 19 02 08" src="https://user-images.githubusercontent.com/92688503/236637767-d0c0ee00-1314-4824-b97a-b7bdf1b7f43b.png"> (cherry picked from commit d297a99)
kibanamachine
added a commit
that referenced
this issue
May 15, 2023
…eys created by users (#155699) (#157792) # Backport This will backport the following commits from `main` to `8.8`: - [add 'user-managed' label to the rule details page for the api keys created by users (#155699)](#155699) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ersin Erdal","email":"92688503+ersin-erdal@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-05-15T19:33:48Z","message":"add 'user-managed' label to the rule details page for the api keys created by users (#155699)\n\nResolves: #154581\r\n\r\nThis PR adds 'user-managed' label next to the API key owner name when\r\nthe API key is created by the user.\r\n\r\n<img width=\"813\" alt=\"Screenshot 2023-05-06 at 19 02 08\"\r\nsrc=\"https://user-images.githubusercontent.com/92688503/236637767-d0c0ee00-1314-4824-b97a-b7bdf1b7f43b.png\">","sha":"d297a9949fc603a797faebc997ea92bee1001fee","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","ui-copy","v8.8.0","v8.9.0"],"number":155699,"url":"https://github.com/elastic/kibana/pull/155699","mergeCommit":{"message":"add 'user-managed' label to the rule details page for the api keys created by users (#155699)\n\nResolves: #154581\r\n\r\nThis PR adds 'user-managed' label next to the API key owner name when\r\nthe API key is created by the user.\r\n\r\n<img width=\"813\" alt=\"Screenshot 2023-05-06 at 19 02 08\"\r\nsrc=\"https://user-images.githubusercontent.com/92688503/236637767-d0c0ee00-1314-4824-b97a-b7bdf1b7f43b.png\">","sha":"d297a9949fc603a797faebc997ea92bee1001fee"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/155699","number":155699,"mergeCommit":{"message":"add 'user-managed' label to the rule details page for the api keys created by users (#155699)\n\nResolves: #154581\r\n\r\nThis PR adds 'user-managed' label next to the API key owner name when\r\nthe API key is created by the user.\r\n\r\n<img width=\"813\" alt=\"Screenshot 2023-05-06 at 19 02 08\"\r\nsrc=\"https://user-images.githubusercontent.com/92688503/236637767-d0c0ee00-1314-4824-b97a-b7bdf1b7f43b.png\">","sha":"d297a9949fc603a797faebc997ea92bee1001fee"}}]}] BACKPORT--> Co-authored-by: Ersin Erdal <92688503+ersin-erdal@users.noreply.github.com>
jasonrhodes
pushed a commit
that referenced
this issue
May 17, 2023
![https://user-images.githubusercontent.com/92688503/236637767-d0c0ee00-1314-4824-b97a-b7bdf1b7f43b.png\">","sha":"d297a9949fc603a797faebc997ea92bee1001fee","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","ui-copy","v8.8.0","v8.9.0"],"number":155699,"url":"https://github.com/elastic/kibana/pull/155699","mergeCommit":{"message":"add](https://user-images.githubusercontent.com/92688503/236637767-d0c0ee00-1314-4824-b97a-b7bdf1b7f43b.png\">","sha":"d297a9949fc603a797faebc997ea92bee1001fee","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","ui-copy","v8.8.0","v8.9.0"],"number":155699,"url":"https://github.com/elastic/kibana/pull/155699","mergeCommit":{"message":"add){kind=link}
![https://user-images.githubusercontent.com/92688503/236637767-d0c0ee00-1314-4824-b97a-b7bdf1b7f43b.png\">","sha":"d297a9949fc603a797faebc997ea92bee1001fee"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/155699","number":155699,"mergeCommit":{"message":"add](https://user-images.githubusercontent.com/92688503/236637767-d0c0ee00-1314-4824-b97a-b7bdf1b7f43b.png\">","sha":"d297a9949fc603a797faebc997ea92bee1001fee"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/155699","number":155699,"mergeCommit":{"message":"add){kind=link}
![https://user-images.githubusercontent.com/92688503/236637767-d0c0ee00-1314-4824-b97a-b7bdf1b7f43b.png\">","sha":"d297a9949fc603a797faebc997ea92bee1001fee](https://user-images.githubusercontent.com/92688503/236637767-d0c0ee00-1314-4824-b97a-b7bdf1b7f43b.png\">","sha":"d297a9949fc603a797faebc997ea92bee1001fee){kind=link}
…eated by users (#155699) Resolves: #154581 This PR adds 'user-managed' label next to the API key owner name when the API key is created by the user. <img width="813" alt="Screenshot 2023-05-06 at 19 02 08" src="https://user-images.githubusercontent.com/92688503/236637767-d0c0ee00-1314-4824-b97a-b7bdf1b7f43b.png">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In PR Allow users authenticated with an API keys to manage alerting rules #154189, we will now have a combination of alerting-framework-generated APIs keys and user-generated API keys, as the API keys stored and used by rules.
We currently show a bit of API key info in the Rule details:
I'm thinking we'll want some additional UX around these, so users will be able to tell whether a given rule has user-managed API keys or not. I'm not sure how far we can go
I think we'll have to play with it to see how much we would need, but we do probably want to at least add a visual indication of this - will be very useful for diagnostic situations in which Rule details pages are screen-shot'ed :-)
The text was updated successfully, but these errors were encountered: