add 'user-managed' label to the rule details page for the api keys created by users #155699

ersin-erdal · 2023-04-25T11:29:05Z

Resolves: #154581

This PR adds 'user-managed' label next to the API key owner name when the API key is created by the user.

…eated by users

elasticmachine · 2023-04-25T14:49:39Z

Pinging @elastic/response-ops (Team:ResponseOps)

mikecote

Changes LGTM! Created a rule with my own API key and saw the (user-managed) label appended 👍

mdefazio · 2023-05-03T11:52:17Z

I think the label works well enough. My original thought was to have the user icon next to the name (with a tooltip on it showing 'User managed'): API Key Owner: elastic <icon>.

Reviewed the previous issue and had a few questions. Feel free to direct me there instead.

Can you remind me of the implications if I edit a rule owned by another user? Would it switch it to my api key?
If I don't have an api key assigned, I would not be able to modify this rule, correct? (Would help us decide if perhaps a different icon makes sense).

Also not trying to make this more complicated than it needs to be as well. 😄

ersin-erdal · 2023-05-03T19:10:13Z

Can you remind me of the implications if I edit a rule owned by another user? Would it switch it to my api key?

AFAIK yes.

If I don't have an api key assigned, I would not be able to modify this rule, correct? (Would help us decide if perhaps a different icon makes sense).

Not sure about this. @mikecote can you help us here?

mikecote · 2023-05-04T11:11:59Z

If I don't have an api key assigned, I would not be able to modify this rule, correct? (Would help us decide if perhaps a different icon makes sense).

Not sure about this. @mikecote can you help us here?

You would be able to modify this rule for sure but by modifying the rule a new API key would get assigned on your behalf and un-associate the previous API key from the rule.

mdefazio · 2023-05-04T11:37:37Z

After understanding this a bit more, I'm thinking a simple questionInCircle icon that shows a tooltip with the following:

API Key Owner: < EuiIconTip position="right" content={...} />

This rule is associated with an API key. Modifying this rule with either remove or switch the API key owner.

That's very likely not correct...

@lcawl Apologies for the mid-conversation ping, but can you take a look at this?

lcawl · 2023-05-11T15:23:14Z

...This rule is associated with an API key. Modifying this rule with either remove or switch the API key owner.
@lcawl Apologies for the mid-conversation ping, but can you take a look at this?

IMO the second sentence seems out of place here. I'm hovering over the tooltip since I'm curious what the API key owner field means, not because I want to edit the rule. I think it would be more appropriate to have that info somewhere in the Edit rule UI. For example, where there are other warnings already:

If we can tell that a rule uses API keys at this stage, it would be cool to modify the message to something like: "Saving this rule will change the API key owner and therefore its privileges and behavior might change."

mdefazio

Just the small copy tweak.

mdefazio · 2023-05-11T13:23:30Z

...ins/triggers_actions_ui/public/application/sections/rule_details/components/rule_details.tsx

+                              'xpack.triggersActionsUI.sections.ruleDetails.userManagedApikey',
+                              {
+                                defaultMessage:
+                                  'This rule is associated with an API key.  Modifying this rule with either remove or switch the API key owner.',


I agree with @lcawl . Let's remove this second sentence.

Should i add that exclamation mark next to the save button too?

If you mean the additional text mentioned in #155699 (comment), that'd be great!

…154581-user-managed-label

mdefazio

LGTM. Thanks!

kibana-ci · 2023-05-15T19:09:39Z

💚 Build Succeeded

Buildkite Build
Commit: 74b0d83

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`triggersActionsUi`	1.4MB	1.4MB	+263.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`triggersActionsUi`	87.0KB	87.1KB	+67.0B

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
`enterpriseSearch`	19	21	+2
`securitySolution`	400	404	+4
total			+6

Total ESLint disabled count

id	before	after	diff
`enterpriseSearch`	20	22	+2
`securitySolution`	480	484	+4
total			+6

History

💛 Build #126053 was flaky 10b0100
💚 Build #122932 succeeded eec9043

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…eated by users (elastic#155699) Resolves: elastic#154581 This PR adds 'user-managed' label next to the API key owner name when the API key is created by the user. <img width="813" alt="Screenshot 2023-05-06 at 19 02 08" src="https://user-images.githubusercontent.com/92688503/236637767-d0c0ee00-1314-4824-b97a-b7bdf1b7f43b.png"> (cherry picked from commit d297a99)

kibanamachine · 2023-05-15T19:42:58Z

💚 All backports created successfully

Status	Branch	Result
✅	8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…eys created by users (#155699) (#157792) # Backport This will backport the following commits from `main` to `8.8`: - [add 'user-managed' label to the rule details page for the api keys created by users (#155699)](#155699)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)  Co-authored-by: Ersin Erdal <92688503+ersin-erdal@users.noreply.github.com>

…eated by users (#155699) Resolves: #154581 This PR adds 'user-managed' label next to the API key owner name when the API key is created by the user. <img width="813" alt="Screenshot 2023-05-06 at 19 02 08" src="https://user-images.githubusercontent.com/92688503/236637767-d0c0ee00-1314-4824-b97a-b7bdf1b7f43b.png">

ersin-erdal added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.8.0 labels Apr 25, 2023

add 'user-managed' label to the rule details page for the api keys cr…

eec9043

…eated by users

ersin-erdal force-pushed the 154581-user-managed-label branch from f6c10aa to eec9043 Compare April 25, 2023 12:03

ersin-erdal marked this pull request as ready for review April 25, 2023 14:49

ersin-erdal requested a review from a team as a code owner April 25, 2023 14:49

ymao1 requested a review from mdefazio April 25, 2023 17:21

ersin-erdal added v8.9.0 and removed v8.8.0 labels May 2, 2023

mikecote self-requested a review May 2, 2023 18:10

mikecote approved these changes May 2, 2023

View reviewed changes

ersin-erdal and others added 2 commits May 6, 2023 19:10

replace "user-managed" text with questionInCircle icon

c4d187d

Merge branch 'main' into 154581-user-managed-label

10b0100

lcawl added the ui-copy Review of UI copy with docs team is recommended label May 11, 2023

mdefazio requested changes May 11, 2023

View reviewed changes

ersin-erdal and others added 3 commits May 15, 2023 19:57

copy tweak

b85d0c2

Merge remote-tracking branch 'origin/154581-user-managed-label' into …

bb98b05

…154581-user-managed-label

Merge branch 'main' into 154581-user-managed-label

74b0d83

mdefazio approved these changes May 15, 2023

View reviewed changes

ersin-erdal added the v8.8.0 label May 15, 2023

ersin-erdal merged commit d297a99 into elastic:main May 15, 2023

ersin-erdal deleted the 154581-user-managed-label branch May 15, 2023 19:33

kibanamachine mentioned this pull request May 15, 2023

[8.8] add 'user-managed' label to the rule details page for the api keys created by users (#155699) #157792

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add 'user-managed' label to the rule details page for the api keys created by users #155699

add 'user-managed' label to the rule details page for the api keys created by users #155699

ersin-erdal commented Apr 25, 2023 •

edited by kibanamachine

Loading

elasticmachine commented Apr 25, 2023

mikecote left a comment

mdefazio commented May 3, 2023

ersin-erdal commented May 3, 2023 •

edited

Loading

mikecote commented May 4, 2023

mdefazio commented May 4, 2023

lcawl commented May 11, 2023 •

edited

Loading

mdefazio left a comment

mdefazio May 11, 2023

ersin-erdal May 12, 2023

lcawl May 15, 2023

mdefazio left a comment

kibana-ci commented May 15, 2023

ESLint disabled line counts

Total ESLint disabled count

kibanamachine commented May 15, 2023

add 'user-managed' label to the rule details page for the api keys created by users #155699

add 'user-managed' label to the rule details page for the api keys created by users #155699

Conversation

ersin-erdal commented Apr 25, 2023 • edited by kibanamachine Loading

elasticmachine commented Apr 25, 2023

mikecote left a comment

Choose a reason for hiding this comment

mdefazio commented May 3, 2023

ersin-erdal commented May 3, 2023 • edited Loading

mikecote commented May 4, 2023

mdefazio commented May 4, 2023

lcawl commented May 11, 2023 • edited Loading

mdefazio left a comment

Choose a reason for hiding this comment

mdefazio May 11, 2023

Choose a reason for hiding this comment

ersin-erdal May 12, 2023

Choose a reason for hiding this comment

lcawl May 15, 2023

Choose a reason for hiding this comment

mdefazio left a comment

Choose a reason for hiding this comment

kibana-ci commented May 15, 2023

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

ESLint disabled line counts

Total ESLint disabled count

History

kibanamachine commented May 15, 2023

💚 All backports created successfully

Questions ?

ersin-erdal commented Apr 25, 2023 •

edited by kibanamachine

Loading

ersin-erdal commented May 3, 2023 •

edited

Loading

lcawl commented May 11, 2023 •

edited

Loading