Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ILM] Warm phase Data allocation doesn't assign initial value for Custom option #173764

Closed
ElenaStoeva opened this issue Dec 20, 2023 · 1 comment · Fixed by #176292
Closed

[ILM] Warm phase Data allocation doesn't assign initial value for Custom option #173764

ElenaStoeva opened this issue Dec 20, 2023 · 1 comment · Fixed by #176292
Assignees
@ElenaStoeva
Labels
bug Fixes for quality problems that affect the customer experience Feature:ILM Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@ElenaStoeva
Copy link
Contributor

ElenaStoeva commented Dec 20, 2023 •
edited
Loading

Customer support issue: https://github.com/elastic/sdh-kibana/issues/4330

When we create a new ILM policy and add a Warm phase, selecting a Custom option for the "Data allocation" field doesn't add the initial value (data:hot) to the request. We need to select one of the other two values from the dropdown in order to add the value to the executed ES request:

Screen.Recording.2023-12-20.at.16.02.06.mov

In older versions (for example 7.17), there is only one Custom option available - data:hot which makes it impossible to select any other option and add a value to the request:

Screen.Recording.2023-12-20.at.16.03.04.mov
@ElenaStoeva ElenaStoeva added bug Fixes for quality problems that affect the customer experience Feature:ILM Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Dec 20, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

@ElenaStoeva ElenaStoeva self-assigned this Feb 5, 2024
@ElenaStoeva ElenaStoeva mentioned this issue Feb 6, 2024
Merged
ElenaStoeva added a commit that referenced this issue Feb 8, 2024
@ElenaStoeva
[ILM] Fix data allocation field (#176292)
3e4f1ed 
Fixes #173764

## Summary

This PR fixes the "Custom" data allocation field in the edit IL policy
form by adding a default value for the field. Before, there was no
default value, so no value would be added to the request until the user
changes the initial selection to another option. This explains the bug
described from #173764 (in
v7.17) where there is only one option and the user is not able to change
it to something else so the value of the only option cannot be added to
the request. Now with these changes, if the user doesn't make any
changes to the initially selected option, the default value would be
added to the request.

**How to test:**
1. Start Es with `yarn es snapshot` and Kibana with `yarn start`.
2. Go to Stack Management -> Index Lifecycle Policies and start creating
a new policy.
3. Type in some name for the policy. Enable the Warm (or Cold) phase and
type in some number in the "Move data into phase when" field. Click on
"Advanced settings".
4. In the "Data allocation" field, select the "Custom" option.
5. Click on "Show request" and verify that the request correctly shows
the `allocation` field (the "Any data node" option doesn't add anything
to the request).
6. Select another option for the node attribution field and verify it is
displayed in the request.

Test the field on cloud by accessing the [CI cloud
deployment](https://kibana-pr-176292.kb.us-west2.gcp.elastic-cloud.com:9243/)
from this PR or by changing the if-condition in line 65 in
`x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/shared_fields/data_tier_allocation_field/components/node_allocation.tsx`
to `if (false)`. Now the "Any data node" option is not available. Follow
the test instructions above and verify that the initially selected node
attribute option is added to the request.
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this issue Feb 15, 2024
@ElenaStoeva @CoenWarmer
[ILM] Fix data allocation field (elastic#176292)
31f835c 
Fixes elastic#173764

## Summary

This PR fixes the "Custom" data allocation field in the edit IL policy
form by adding a default value for the field. Before, there was no
default value, so no value would be added to the request until the user
changes the initial selection to another option. This explains the bug
described from elastic#173764 (in
v7.17) where there is only one option and the user is not able to change
it to something else so the value of the only option cannot be added to
the request. Now with these changes, if the user doesn't make any
changes to the initially selected option, the default value would be
added to the request.

**How to test:**
1. Start Es with `yarn es snapshot` and Kibana with `yarn start`.
2. Go to Stack Management -> Index Lifecycle Policies and start creating
a new policy.
3. Type in some name for the policy. Enable the Warm (or Cold) phase and
type in some number in the "Move data into phase when" field. Click on
"Advanced settings".
4. In the "Data allocation" field, select the "Custom" option.
5. Click on "Show request" and verify that the request correctly shows
the `allocation` field (the "Any data node" option doesn't add anything
to the request).
6. Select another option for the node attribution field and verify it is
displayed in the request.

Test the field on cloud by accessing the [CI cloud
deployment](https://kibana-pr-176292.kb.us-west2.gcp.elastic-cloud.com:9243/)
from this PR or by changing the if-condition in line 65 in
`x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/shared_fields/data_tier_allocation_field/components/node_allocation.tsx`
to `if (false)`. Now the "Any data node" option is not available. Follow
the test instructions above and verify that the initially selected node
attribute option is added to the request.
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this issue Feb 15, 2024
@ElenaStoeva @CoenWarmer
[ILM] Fix data allocation field (elastic#176292)
60e4ee6 
Fixes elastic#173764

## Summary

This PR fixes the "Custom" data allocation field in the edit IL policy
form by adding a default value for the field. Before, there was no
default value, so no value would be added to the request until the user
changes the initial selection to another option. This explains the bug
described from elastic#173764 (in
v7.17) where there is only one option and the user is not able to change
it to something else so the value of the only option cannot be added to
the request. Now with these changes, if the user doesn't make any
changes to the initially selected option, the default value would be
added to the request.

**How to test:**
1. Start Es with `yarn es snapshot` and Kibana with `yarn start`.
2. Go to Stack Management -> Index Lifecycle Policies and start creating
a new policy.
3. Type in some name for the policy. Enable the Warm (or Cold) phase and
type in some number in the "Move data into phase when" field. Click on
"Advanced settings".
4. In the "Data allocation" field, select the "Custom" option.
5. Click on "Show request" and verify that the request correctly shows
the `allocation` field (the "Any data node" option doesn't add anything
to the request).
6. Select another option for the node attribution field and verify it is
displayed in the request.

Test the field on cloud by accessing the [CI cloud
deployment](https://kibana-pr-176292.kb.us-west2.gcp.elastic-cloud.com:9243/)
from this PR or by changing the if-condition in line 65 in
`x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/shared_fields/data_tier_allocation_field/components/node_allocation.tsx`
to `if (false)`. Now the "Any data node" option is not available. Follow
the test instructions above and verify that the initially selected node
attribute option is added to the request.
fkanout pushed a commit to fkanout/kibana that referenced this issue Mar 4, 2024
@ElenaStoeva @fkanout
[ILM] Fix data allocation field (elastic#176292)
f082f11 
Fixes elastic#173764

## Summary

This PR fixes the "Custom" data allocation field in the edit IL policy
form by adding a default value for the field. Before, there was no
default value, so no value would be added to the request until the user
changes the initial selection to another option. This explains the bug
described from elastic#173764 (in
v7.17) where there is only one option and the user is not able to change
it to something else so the value of the only option cannot be added to
the request. Now with these changes, if the user doesn't make any
changes to the initially selected option, the default value would be
added to the request.

**How to test:**
1. Start Es with `yarn es snapshot` and Kibana with `yarn start`.
2. Go to Stack Management -> Index Lifecycle Policies and start creating
a new policy.
3. Type in some name for the policy. Enable the Warm (or Cold) phase and
type in some number in the "Move data into phase when" field. Click on
"Advanced settings".
4. In the "Data allocation" field, select the "Custom" option.
5. Click on "Show request" and verify that the request correctly shows
the `allocation` field (the "Any data node" option doesn't add anything
to the request).
6. Select another option for the node attribution field and verify it is
displayed in the request.

Test the field on cloud by accessing the [CI cloud
deployment](https://kibana-pr-176292.kb.us-west2.gcp.elastic-cloud.com:9243/)
from this PR or by changing the if-condition in line 65 in
`x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/shared_fields/data_tier_allocation_field/components/node_allocation.tsx`
to `if (false)`. Now the "Any data node" option is not available. Follow
the test instructions above and verify that the initially selected node
attribute option is added to the request.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ElenaStoeva ElenaStoeva

Labels
bug Fixes for quality problems that affect the customer experience Feature:ILM Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ILM] Fix data allocation field ElenaStoeva/kibana
2 participants
@elasticmachine @ElenaStoeva