Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG][OBS-UX-MNGT] Add the missing prefill fields for the Custom Threshold rule #174824

Closed
fkanout opened this issue Jan 15, 2024 · 2 comments · Fixed by #174690
Closed

[BUG][OBS-UX-MNGT] Add the missing prefill fields for the Custom Threshold rule #174824

fkanout opened this issue Jan 15, 2024 · 2 comments · Fixed by #174690
Assignees
@maryam-saeidi
Labels
bug Fixes for quality problems that affect the customer experience Feature:Alerting Feature: Custom threshold Observability custom threshold rule type Team:obs-ux-management Observability Management User Experience Team v8.1.3

Comments

@fkanout
Copy link
Contributor

fkanout commented Jan 15, 2024

📝 Summary

This is a follow-up issue of the original one #170295, and to complete #172783 by adding the missing fields and fixing an issue.

✅ AC

  • Add timeSize
  • Add timeUnit
  • Add alertOnGroupDisappear
  • Fix the optional query field when we pass ad-hoc DataView (searchConfiguration). The query will not be taken into account, and it will be overridden by the default value.
@fkanout fkanout added bug Fixes for quality problems that affect the customer experience Feature:Alerting v8.1.3 Team:obs-ux-management Observability Management User Experience Team Feature: Custom threshold Observability custom threshold rule type labels Jan 15, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@fkanout fkanout changed the title [BUG][OBS-UX-MNGT] Add the missing prefill fields for the Custom Threshold role [BUG][OBS-UX-MNGT] Add the missing prefill fields for the Custom Threshold rule Jan 15, 2024
@maryam-saeidi maryam-saeidi self-assigned this Jan 15, 2024
@maryam-saeidi
Copy link
Member

@fkanout Can you please also add the list of fields that you tested and worked correctly?

I tested comparator and threshold (besides the original aggregation type and field and group by) and they worked fine.

@maryam-saeidi maryam-saeidi mentioned this issue Jan 15, 2024
Merged
maryam-saeidi added a commit that referenced this issue Jan 24, 2024
@maryam-saeidi @fkanout
[Custom threshold] Add missing prefill fields to the custom threshold…
86ca7a6 
… rule (#174690)

Fixes #174824

## Summary

This PR adds prefill functionality for `time size`, `time unit`, and
`alertOnGroupDisappear` in the custom threshold.
It also fixes the filter query by changing the structure to match how we
save information in the rule saved object, like this:

```
searchConfiguration: {
  index: 'metrics-*',
  query: {
    query: 'host.name: host-1',
    language: 'kuery',
  },
},
```
This will be more compatible with future changes in case we want to
support query filters other than `kuery`.

---------

Co-authored-by: Faisal Kanout <faisal.kanout@elastic.co>
lcawl pushed a commit to lcawl/kibana that referenced this issue Jan 26, 2024
@maryam-saeidi @fkanout @lcawl
[Custom threshold] Add missing prefill fields to the custom threshold…
0840430 
… rule (elastic#174690)

Fixes elastic#174824

## Summary

This PR adds prefill functionality for `time size`, `time unit`, and
`alertOnGroupDisappear` in the custom threshold.
It also fixes the filter query by changing the structure to match how we
save information in the rule saved object, like this:

```
searchConfiguration: {
  index: 'metrics-*',
  query: {
    query: 'host.name: host-1',
    language: 'kuery',
  },
},
```
This will be more compatible with future changes in case we want to
support query filters other than `kuery`.

---------

Co-authored-by: Faisal Kanout <faisal.kanout@elastic.co>
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this issue Feb 15, 2024
@maryam-saeidi @fkanout @CoenWarmer
[Custom threshold] Add missing prefill fields to the custom threshold…
7601782 
… rule (elastic#174690)

Fixes elastic#174824

## Summary

This PR adds prefill functionality for `time size`, `time unit`, and
`alertOnGroupDisappear` in the custom threshold.
It also fixes the filter query by changing the structure to match how we
save information in the rule saved object, like this:

```
searchConfiguration: {
  index: 'metrics-*',
  query: {
    query: 'host.name: host-1',
    language: 'kuery',
  },
},
```
This will be more compatible with future changes in case we want to
support query filters other than `kuery`.

---------

Co-authored-by: Faisal Kanout <faisal.kanout@elastic.co>
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this issue Feb 15, 2024
@maryam-saeidi @fkanout @CoenWarmer
[Custom threshold] Add missing prefill fields to the custom threshold…
b235b68 
… rule (elastic#174690)

Fixes elastic#174824

## Summary

This PR adds prefill functionality for `time size`, `time unit`, and
`alertOnGroupDisappear` in the custom threshold.
It also fixes the filter query by changing the structure to match how we
save information in the rule saved object, like this:

```
searchConfiguration: {
  index: 'metrics-*',
  query: {
    query: 'host.name: host-1',
    language: 'kuery',
  },
},
```
This will be more compatible with future changes in case we want to
support query filters other than `kuery`.

---------

Co-authored-by: Faisal Kanout <faisal.kanout@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maryam-saeidi maryam-saeidi

Labels
bug Fixes for quality problems that affect the customer experience Feature:Alerting Feature: Custom threshold Observability custom threshold rule type Team:obs-ux-management Observability Management User Experience Team v8.1.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Custom threshold] Add missing prefill fields to the custom threshold rule maryam-saeidi/kibana
3 participants
@fkanout @maryam-saeidi @elasticmachine