[Custom threshold] Add missing prefill fields to the custom threshold rule

[maryam-saeidi]

Fixes #174824

Summary

This PR adds prefill functionality for time size, time unit, and alertOnGroupDisappear in the custom threshold.
It also fixes the filter query by changing the structure to match how we save information in the rule saved object, like this:

searchConfiguration: {
  index: 'metrics-*',
  query: {
    query: 'host.name: host-1',
    language: 'kuery',
  },
},

This will be more compatible with future changes in case we want to support query filters other than kuery.

[elasticmachine]

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

[apmmachine]

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

• /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
• /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
• run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

[fkanout]

Can you add to the PR the prefill for alertOnGroupDisappear ?

[maryam-saeidi]

@fkanout I changed how we prefill filter so it matches how we save it in the rule. It will also allow us to extend this filter more easily in the future. Here is what the new structure looks like:

searchConfiguration: {
  index: 'metrics-*',
  query: {
    query: 'host.name: host-1',
    language: 'kuery',
  },
},

So we don't need to prefill the filter query separately anymore.

[fkanout]

I tested it locally, and it works as expected! Good job @maryam-saeidi
One nit thing: I just noticed that there is no prefill for the optional label field. Could you add it, too?

[maryam-saeidi]

I tested it locally, and it works as expected! Good job @maryam-saeidi One nit thing: I just noticed that there is no prefill for the optional label field. Could you add it, too?

@fkanout I tested locally and the optional field worked as expected, was there any issue with it in your test?
Also, besides this nit, is there something missing that blocks the approval of this PR?

Update:
If you mean adding this field to the test, I've added it.

[fkanout]

Nice 👍🏻

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: 44ef6be

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
observability	634.5KB	634.5KB	+26.0B

History

• 💛 Build #188481 was flaky 57cd386
• 💚 Build #187630 succeeded 2365425
• 💛 Build #187481 was flaky 245bee4
• 💚 Build #186989 succeeded 934bb76

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @maryam-saeidi