Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Meta: Kibana app NP cutover #60097

Closed
69 tasks done
flash1293 opened this issue Mar 13, 2020 · 2 comments
Closed
69 tasks done

Meta: Kibana app NP cutover #60097

flash1293 opened this issue Mar 13, 2020 · 2 comments
Labels
Feature:NP Migration Meta Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@flash1293
Copy link
Contributor

flash1293 commented Mar 13, 2020 •
edited by kertal
Loading

This issue tracks the last remaining legacy dependencies of Kibana app code.

How to read this list

The first level of the list is the name of the shimmed plugin holding legacy dependencies. Most of them are in src/legacy/core_plugins except for lens, graph and rollup, those are in x-pack/legacy/plugins. If a shimmed plugin name is checked, it is moved to the new platform in its entirety.

The second level of the list are referenced dependencies (mostly from within the legacy_imports.ts file within the plugin). Those have to be resolved for the plugin to move. If a dependency is gone, its checkbox can be checked.

After the name of a plugin or a dependency, three different things can be referenced:

  • issue: The sub issue(s) tracking this specific dependency (owned by Kibana app team)
  • pr: The PR(s) fixing this dependency
  • blocker: The issue or PR of another team which is currently blocking resolving the dependency.

How to work with this list

  • Choose an item that's not done yet that doesn't have a pending PR or a blocker
  • Put either your GH username or the link to a draft PR behind the item (before actually starting to work on it)
  • Finish the work
  • When the PR is merged, check the checkbox

How to migrate a plugin

When all dependencies of a plugin are done, the plugin itself can be moved.

  • Put either your GH username or the link to a draft PR behind the plugin (before actually starting to work on it - see graph)
  • Move the whole plugin to the respective NP plugin. In some cases (e.g. dashboard or discover) it already exists and the remaining code just has to be merged in, in other cases a new plugin has to be created. Check the structure of existing plugins for guidance.
  • CSS is currently imported from a root _/index.scss in the legacy platform - this should be changed to an import directly in the NP plugin to use the new CSS infrastructure if possible. If not, the CSS can be moved over, but still imported from the legacy platform.
    • For stylesheets imported in the NP, Kibana and EUI constants and mixins are imported automatically - it's not necessary to import them again.
  • Some tests are not migrated yet (if they are in a __tests__ folder) - if this is the case, the plugin can still be moved with the tests left behind in the legacy platform. To be able to delete the legacy plugin, move the tests into the core_plugins/kibana plugin into public/__tests__/<your pluginname>. So old discover tests should go into core_plugins/kibana/public/__tests__/discover and so on.
  • Make sure to also adjust the paths in the various config files (for codeowners, linting, i18n and so on).

Visualization plugin specials

Dependencies
@flash1293 flash1293 added Meta Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:NP Migration labels Mar 13, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293 flash1293 changed the title Meta: Kibana app NP cutover Meta: Kibana app NP cutover preparation Mar 13, 2020
@kindsun kindsun mentioned this issue Mar 16, 2020
Closed
4 tasks
@flash1293 flash1293 changed the title Meta: Kibana app NP cutover preparation Meta: Kibana app NP cutover Mar 25, 2020
This was referenced Mar 25, 2020
Closed
Closed
@lukeelmers lukeelmers mentioned this issue Mar 31, 2020
Closed
@mattkime mattkime mentioned this issue Mar 31, 2020
Closed
16 tasks
This was referenced Apr 7, 2020
Merged
Merged
This was referenced Apr 9, 2020
Merged
Merged
@DianaDerevyankina DianaDerevyankina mentioned this issue Apr 14, 2020
Merged
7 tasks
@maryia-lapata maryia-lapata mentioned this issue Apr 17, 2020
Merged
@flash1293 flash1293 mentioned this issue Apr 20, 2020
Closed
@sulemanof sulemanof mentioned this issue Apr 29, 2020
Merged
7 tasks
@kertal
Copy link
Member

kertal commented May 5, 2020

Closing this since also Discover entered new/kibana platform

@kertal kertal closed this as completed May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:NP Migration Meta Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kertal @flash1293 @elasticmachine