[NP] TSVB

[sulemanof]

Summary

Move the TSVB public into new platform.

Get rid of all lodash isFunction checks due to failure to check async functions in dev mode (we are using a local copy of lodash which does not treat async functions - issue #63239)

Checklist

Delete any items that are not applicable to this PR.

• Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios
• This was checked for keyboard-only and screenreader accessibility
• This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
• This was checked for cross-browser compatibility, including a check against IE11

For maintainers

• This was checked for breaking API changes and was labeled appropriately

[elasticmachine]

Pinging @elastic/kibana-app (Team:KibanaApp)

[sulemanof]

@elasticmachine merge upstream

[flash1293]

Tested in Chrome and everything works as expected, LGTM. Could you add the src/plugins/vis_type_timeseries directory to the .github/CODEOWNERS file? Seems like this was forgotten initially (probably by me).

The plugin id thing will be solved by another PR @alexwizp already set up.

[cchaos]

The styling_constants import is no longer necessary at the top of the /public/application/index.scss file.

[cchaos]

Is this the right place to import all the styles for TSVB and not in the plugin.ts fle?

[sulemanof]

Right now there is no benefit in importing it here in editor_controller.js,
since the plugin initialization will synchronously load these styles.
But this helps to decrease the plugin bundle if we'll switch loading of the editor_controller.js to a dynamic import in future.

e.x. like we did it in the dashboard plugin:
styles are loaded in :
https://github.com/elastic/kibana/blob/master/src/plugins/dashboard/public/application/application.ts#L20

but this file is under a dynamic import, so it will be loaded only if the dashboard is rendered in browser:
https://github.com/elastic/kibana/blob/master/src/plugins/dashboard/public/plugin.tsx#L246

[cchaos]

But the styles included in this index.scss file aren't restricted to the editor application, right? There looks to be styles associated with just the render of the chart, which would need to be added to Dashboard, or any other place the TSVB chart types are displayed/embedded. So I definitely agree that importing at a lower component is a good idea, I think this is too low for all TSVB styles.

[sulemanof]

Makes sense, moved into plugin.ts

[sulemanof]

The styling_constants import is no longer necessary at the top of the /public/application/index.scss file.

Thanks, wasn't aware of it ! Updated.

[sulemanof]

@elasticmachine merge upstream

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: a66b030

History

• 💔 Build #40871 failed e88b26b
• 💚 Build #40701 succeeded 7fee63d
• 💚 Build #40339 succeeded f52cf26
• 💚 Build #40143 succeeded f12f9e4
• 💛 Build #40118 was flaky 0becbe2

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[cchaos]

Thanks!