Shim getFormat function correctly #60032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
69 tasks
|
@elasticmachine merge upstream |
flash1293
added
Feature:NP Migration
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
flash1293
added
release_note:skip
majagrubic
approved these changes
Mar 24, 2020
kertal
approved these changes
Mar 25, 2020
| @@ -26,7 +26,7 @@ function tableResponseHandler(table, dimensions) { | |||
| if (split) { | |||
There was a problem hiding this comment.
Just a note: I think we can further cleanup the discover part, since it doesn't use splitColumn, splitRow
There was a problem hiding this comment.
however, doesn't need to be in this PR, just loud thinking :)
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Mar 25, 2020
flash1293
added a commit
that referenced
this pull request
Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a bunch of places in shimmed visualizations the
getFormatfunction was used via legacy import. Since this has been migrated as a stateful API, this PR moves it into the shim by passing it through the plugin class.This is preparing the visualizations to get moved to the new platform once the
visualizationsplugin is ready.