Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: X-Pack Accessibility Tests.x-pack/test/accessibility/apps/dashboard_edit_panel·ts - Dashboard Edit Panel A11y test on dashboard embeddable clone panel #91592

Closed
kibanamachine opened this issue Feb 17, 2021 · 5 comments · Fixed by #91017
Closed

Failing test: X-Pack Accessibility Tests.x-pack/test/accessibility/apps/dashboard_edit_panel·ts - Dashboard Edit Panel A11y test on dashboard embeddable clone panel #91592

kibanamachine opened this issue Feb 17, 2021 · 5 comments · Fixed by #91017
Assignees
@myasonik
Labels
failed-test A test failure on a tracked branch, potentially flaky-test skipped-test Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. v7.12.0 v8.0.0

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Feb 17, 2021 •
edited
Loading

A test failed on a tracked branch

Error: Element "[data-test-subj="toastCloseButton"]" is not displayed
    at Proxy.descendantDisplayedByCssSelector (/dev/shm/workspace/parallel/10/kibana/test/functional/services/common/find.ts:207:15)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at TestSubjects.findDescendant (/dev/shm/workspace/parallel/10/kibana/test/functional/services/common/test_subjects.ts:125:14)
    at Toasts.dismissAllToasts (/dev/shm/workspace/parallel/10/kibana/test/functional/services/toasts.ts:50:31)
    at Context.<anonymous> (test/accessibility/apps/dashboard_edit_panel.ts:53:7)
    at Object.apply (/dev/shm/workspace/parallel/10/kibana/packages/kbn-test/src/functional_test_runner/lib/mocha/wrap_function.js:73:16)

First failure: Jenkins Build
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Feb 17, 2021
@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@mistic mistic added the Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. label Feb 17, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-design (Team:Kibana-Design)

@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

tylersmalley added a commit that referenced this issue Feb 17, 2021
@tylersmalley
skip flaky suite (#91592)
2c16d8c
tylersmalley added a commit that referenced this issue Feb 17, 2021
@tylersmalley
skip flaky suite (#91592)
57a42b2
@tylersmalley
Copy link
Contributor

tylersmalley commented Feb 17, 2021 •
edited
Loading

Skipped, fairly consistently failing on master.

master: 57a42b2
7.x: 2c16d8c

gmmorris added a commit to gmmorris/kibana that referenced this issue Feb 17, 2021
@gmmorris
Merge branch 'master' into task-manager/docs-monitoring
61d7256 
* master: (157 commits)
  [DOCS] Adds machine learning to the security section of alerting (elastic#91501)
  [Uptime] Ping list step screenshot caption formatting (elastic#91403)
  [Vislib] Use timestamp on brush event instead of iso dates (elastic#91483)
  [Application Usage] Remove deprecated & unused legacy.appChanged API (elastic#91464)
  Migrate logstash, monitoring, url_drilldowns, xpack_legacy to ts projects (elastic#91194)
  [APM] Wrap Elasticsearch client errors (elastic#91125)
  [APM] Fix optimize-tsconfig script (elastic#91487)
  [Discover][docs] Add searchFieldsFromSource description (elastic#90980)
  Adds support for 'ip' data type (elastic#85087)
  [Detection Rules] Add updates from 7.11.2 rules (elastic#91553)
  [SECURITY SOLUTION] Eql in timeline (elastic#90816)
  [APM] Correlations Beta (elastic#86477) (elastic#89952)
  [Security Solutions][Detection Engine] Adds a warning banner when the alerts data has not been migrated yet. (elastic#90258)
  [Security Solution] [Timeline] Endpoint row renderers (2nd batch) (elastic#91446)
  skip flaky suite (elastic#91450)
  skip flaky suite (elastic#91592)
  [Security Solution][Endpoint][Admin] Endpoint Details UX Enhancements (elastic#90870)
  [ML] Add better UI support for runtime fields Transforms  (elastic#90363)
  [Security Solution] [Detections] Replace 'partial failure' with 'warning' for rule statuses (elastic#91167)
  [Security Solution][Detections] Adds Indicator path config for indicator match rules (elastic#91260)
  ...
@myasonik myasonik self-assigned this Feb 17, 2021
@myasonik myasonik removed the blocker label Feb 17, 2021
@myasonik
Copy link
Contributor

There's no reason this has to be a blocker.

The test is failing because of timing issues with the toast error messages. The toast identification just needs to get a little smarter on figuring out if a toast is visible without failing but it isn't critical.

I'll take on this work.

@myasonik myasonik mentioned this issue Feb 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@myasonik myasonik

Labels
failed-test A test failure on a tracked branch, potentially flaky-test skipped-test Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enabling Uptime and Dashboard a11y test myasonik/kibana
5 participants
@tylersmalley @myasonik @mistic @elasticmachine @kibanamachine