Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Correlations Beta #86477

Closed
20 of 27 tasks
sorenlouv opened this issue Dec 18, 2020 · 8 comments · Fixed by #89952
Closed
20 of 27 tasks

[APM] Correlations Beta #86477

sorenlouv opened this issue Dec 18, 2020 · 8 comments · Fixed by #89952
Assignees
Labels
apm:correlations Team:APM All issues that need APM UI Team support v7.12.0

Comments

@sorenlouv
Copy link
Member

sorenlouv commented Dec 18, 2020

Summary

Related design issue elastic/apm#302

Design solution

Kapture.2020-12-22.at.20.56.53.mp4

Testing

  • Validate the feature against more realistic data like DPP or the chaos environment.

Technical

Design

  • Add "Traffic" metric as another option ([APM] Add Throughput tab to Correlations #90633)
  • Add tab navigation and split each metric set into separate tabs; Latency, Error rate, and Traffic
  • Add small paragraph summary for each tab content that introduces the different expected value of each metric set aggregration. (copy TBD)
  • Add titles for each chart (size xxs)
  • Filter options should have a tooltip with explanations; "Filter by value" or "Filter out value".
  • Adding a filter value should close the flyout and add the value to the query bar in the previous view.
  • Add i18n support for all labels
  • Change main flyout button to "Explore correlations" and add icon visTagCloud (new icon pending)
  • Update charts to make them consistent with the other Transaction pages
  • Change the selected value chart visualization to use the euiColorAccent as opposed to the existing red.
  • Update the score badge to use default and drop the code font change. Also, add proper unit formatting.
  • Change the accordion button label to "Customize fields"
  • Move the button below the table
  • Update the threshold field with new prepend label to show it's percentiles and add help text.
  • There should be an option to reset to default, if the user changes the value.
  • Sort the selected field values alphabetically.
  • Add help text with a link to documentation where we can explain the reason for selecting those fields.
  • Add the correlations button to the overview page in addition to the transactions experience.
  • If the filter next to the value is clicked, the user should navigate go to the currently selected page with the filter in the kuery bar and the correlations flyout should collapse.
  • Add the Explore correlations button to the Service overview page
  • Customizing the fields for correlation should allow suggestions for fields to make it easier to add new terms for the sig terms query
  • Saving field customization

Section descriptions copy

Latency

What is slowing down my service? Correlations will help discover a slower performance in a particular cohort of your data. Either by host, version, or other custom fields.

Errors

Why are some transactions failing and returning errors? Correlations will help discover a possible culprit in a particular cohort of your data. Either by host, version, or other custom fields.

Throughput

What's driving the increase or decrease in throughput to my service? Correlations will help discover a potential problem in a particular cohort of your data. Either by host, version, or other custom fields.

Saving field customization

We could either save the configurations to an index or saved object depending on what we feel is best suited to the experience. Alternatively, they're not saved and only kept for the quick analysis as you're adding them, but I think users will get the impression that their selections are saved until next time, or if they go to another service or transaction.

Update We've decided to go with a local storage approach to keep the customized fields per session for the user. We might reconsider once per-user settings are enabled on spaces (#21640) that will enable even more control per user. Also, we'll keep an eye out for feedback we get from users. I've removed the task around saving fields, as they will be saved automatically in local storage.

View examples Significant tags - Flyout - Latency - Customize Significant tags - Flyout - Errors - Customize Significant tags - Flyout - Traffic - Compare
@sorenlouv sorenlouv added [zube]: 7.12 needs design Team:APM All issues that need APM UI Team support v7.12.0 labels Dec 18, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@formgeist formgeist changed the title [APM] Correlations GA [APM] Significant terms GA Dec 22, 2020
@formgeist
Copy link
Contributor

@sqren @nehaduggal Updated the list of changes and additions to the feature.

@formgeist
Copy link
Contributor

@sqren @nehaduggal I made some changes above to separate things from new additions to changes and a specific portion around the fields customization, which I wasn't sure how we imagine we want to implement further. Please when you have time if you can provide some feedback on this.

@formgeist
Copy link
Contributor

Updated the issue description with a decision on the fields customization, which we'll make local storage enabled per user session. This is the most practical and essential saving of the fields we can imagine would be useful for the first iteration. We might reconsider when spaces also become user profile specific, which will enable users per space to define the fields. We might also get other feedback from users once the feature is released, so we should keep an eye out for that.

cc @nehaduggal @sqren

@ogupte ogupte changed the title [APM] Significant terms GA [APM] Correlations GA Jan 21, 2021
@ogupte
Copy link
Contributor

ogupte commented Jan 21, 2021

We should also take this opportunity to rename files, components, and data type to reflect the current feature name "Correlations" instead of the old feature name "Significant terms" (#89028)

@sorenlouv
Copy link
Member Author

@ogupte I added a new section "Technical" with some more items. LMK if you have questions about it.

ogupte added a commit to ogupte/kibana that referenced this issue Feb 2, 2021
@formgeist
Copy link
Contributor

@ogupte I've added another task to add the "Explore correlations" button to invoke the flyout to the Service overview page as well ^ cc @sqren @nehaduggal

ogupte added a commit to ogupte/kibana that referenced this issue Feb 5, 2021
@formgeist
Copy link
Contributor

@ogupte @nehaduggal Added some quick descriptions for each section in the flyouts to describe what use each of them are to the investigation. Let me know if you have any improvements to the copy? I wanted to keep a similar theme to them.

@ogupte ogupte changed the title [APM] Correlations GA [APM] Correlations Beta Feb 16, 2021
ogupte added a commit that referenced this issue Feb 17, 2021
* [APM] Correlations GA (#86477)

* polish and improvements to correlations UI

* more improvements and polish

* added impact bar

* added descriptions

* make custom field persistence be unique per service

* make custom threshold unique per service in latency correlations

* adds telemetry for apm correlations feature. Events:
 - 'show_correlations_flyout'
 - 'customize_correlations_fields'
 - 'select_significant_term'

* adds more telemetry for correlations (#90622)

* removes the raw score column

* replaces experiemental callout with beta badge

* replaces threshold number input with percentile option selector

* improvements to latency correlations scoring and percentage reporting

* removes the 'apm:enableCorrelations' UI setting

* - rename useFieldNames.ts -> use_field_names.ts
- filter out fields that are not type 'keyword'
- feedback improvements

* Fixes casing issue for the 'correlations' dir

* [APM] Moves correlations button to service details tabslist row (#91080)

* [APM] Adds license check for correlations (#90766)

* [APM] Adds metrics tracking for correlations views and license prompts (#90622)

* Updated the API integration tests to check for new default fields and 15 buckets

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@zube zube bot added the [zube]: Done label Feb 17, 2021
ogupte added a commit to ogupte/kibana that referenced this issue Feb 17, 2021
* [APM] Correlations GA (elastic#86477)

* polish and improvements to correlations UI

* more improvements and polish

* added impact bar

* added descriptions

* make custom field persistence be unique per service

* make custom threshold unique per service in latency correlations

* adds telemetry for apm correlations feature. Events:
 - 'show_correlations_flyout'
 - 'customize_correlations_fields'
 - 'select_significant_term'

* adds more telemetry for correlations (elastic#90622)

* removes the raw score column

* replaces experiemental callout with beta badge

* replaces threshold number input with percentile option selector

* improvements to latency correlations scoring and percentage reporting

* removes the 'apm:enableCorrelations' UI setting

* - rename useFieldNames.ts -> use_field_names.ts
- filter out fields that are not type 'keyword'
- feedback improvements

* Fixes casing issue for the 'correlations' dir

* [APM] Moves correlations button to service details tabslist row (elastic#91080)

* [APM] Adds license check for correlations (elastic#90766)

* [APM] Adds metrics tracking for correlations views and license prompts (elastic#90622)

* Updated the API integration tests to check for new default fields and 15 buckets

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
ogupte added a commit that referenced this issue Feb 17, 2021
* [APM] Correlations GA (#86477)

* polish and improvements to correlations UI

* more improvements and polish

* added impact bar

* added descriptions

* make custom field persistence be unique per service

* make custom threshold unique per service in latency correlations

* adds telemetry for apm correlations feature. Events:
 - 'show_correlations_flyout'
 - 'customize_correlations_fields'
 - 'select_significant_term'

* adds more telemetry for correlations (#90622)

* removes the raw score column

* replaces experiemental callout with beta badge

* replaces threshold number input with percentile option selector

* improvements to latency correlations scoring and percentage reporting

* removes the 'apm:enableCorrelations' UI setting

* - rename useFieldNames.ts -> use_field_names.ts
- filter out fields that are not type 'keyword'
- feedback improvements

* Fixes casing issue for the 'correlations' dir

* [APM] Moves correlations button to service details tabslist row (#91080)

* [APM] Adds license check for correlations (#90766)

* [APM] Adds metrics tracking for correlations views and license prompts (#90622)

* Updated the API integration tests to check for new default fields and 15 buckets

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this issue Feb 17, 2021
* master: (157 commits)
  [DOCS] Adds machine learning to the security section of alerting (elastic#91501)
  [Uptime] Ping list step screenshot caption formatting (elastic#91403)
  [Vislib] Use timestamp on brush event instead of iso dates (elastic#91483)
  [Application Usage] Remove deprecated & unused legacy.appChanged API (elastic#91464)
  Migrate logstash, monitoring, url_drilldowns, xpack_legacy to ts projects (elastic#91194)
  [APM] Wrap Elasticsearch client errors (elastic#91125)
  [APM] Fix optimize-tsconfig script (elastic#91487)
  [Discover][docs] Add searchFieldsFromSource description (elastic#90980)
  Adds support for 'ip' data type (elastic#85087)
  [Detection Rules] Add updates from 7.11.2 rules (elastic#91553)
  [SECURITY SOLUTION] Eql in timeline (elastic#90816)
  [APM] Correlations Beta (elastic#86477) (elastic#89952)
  [Security Solutions][Detection Engine] Adds a warning banner when the alerts data has not been migrated yet. (elastic#90258)
  [Security Solution] [Timeline] Endpoint row renderers (2nd batch) (elastic#91446)
  skip flaky suite (elastic#91450)
  skip flaky suite (elastic#91592)
  [Security Solution][Endpoint][Admin] Endpoint Details UX Enhancements (elastic#90870)
  [ML] Add better UI support for runtime fields Transforms  (elastic#90363)
  [Security Solution] [Detections] Replace 'partial failure' with 'warning' for rule statuses (elastic#91167)
  [Security Solution][Detections] Adds Indicator path config for indicator match rules (elastic#91260)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:correlations Team:APM All issues that need APM UI Team support v7.12.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants