Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Security Solutions] Re-arranges and adds more packages to remove copied code (#100310) #100369

Merged
merged 1 commit into from
May 19, 2021

Commits on May 19, 2021

  1. [Security Solutions] Re-arranges and adds more packages to remove cop…

    …ied code (elastic#100310)
    
    ## Summary
    
    * Creates a `securitysolution-list-utils` packaged and moves the first set of utilities into there
    * Fixes a slight bug with `kbn-securitysolution-io-ts-list-types` where the wrong name was used
    * Moves _all_ of the lists schemas and types into the package `kbn-securitysolution-io-ts-list-types`
    * Removes copied code found in a few places
    
    ## Tech debt
    * Some spots I have to use an `any` in the package as Kibana kbn packages don't have the types I need
    * Some spots I copy constants until we can straighten out those pieces.
    * I keep copied mock files until we figure out how to share mocks from these packages without adding weight or we create dedicated mock packages for all of this. 
    
    
    ### Checklist
    
    - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
    FrankHassanabad authored and kibanamachine committed May 19, 2021
    Configuration menu
    Copy the full SHA
    9fceca4 View commit details
    Browse the repository at this point in the history