Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TSVB] [Table tab] Fix "Math" aggregation #100765

Merged
merged 1 commit into from
May 28, 2021
Merged

[TSVB] [Table tab] Fix "Math" aggregation #100765

merged 1 commit into from
May 28, 2021

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented May 27, 2021 •
edited
Loading

Closes: #100892

Summary

"Math" aggregation not working at all for table view due to executing with wrong arguments.

Steps to reproduce:

  1. Open TSVB and go to Table tab
  2. Configure some Math aggregation like e.g
    image

Expected result:
Table should contain some data

Actual result:
image

Console log:

   │ proc [kibana] TypeError: extractFields is not a function
   │ proc [kibana]     at getSplits (/Users/Documents/Kibana/src/plugins/vis_type_timeseries/server/lib/vis_data/helpers/get_splits.js:26:46)
   │ proc [kibana]     at /Users/Documents/Kibana/src/plugins/vis_type_timeseries/server/lib/vis_data/response_processors/series/math.js:30:26
   │ proc [kibana]     at next (/Users/Documents/Kibana/src/plugins/vis_type_timeseries/server/lib/vis_data/response_processors/table/math.js:14:12)
   │ proc [kibana]     at next (/Users/Documents/Kibana/src/plugins/vis_type_timeseries/server/lib/vis_data/response_processors/table/std_sibling.js:17:47)
   │ proc [kibana]     at /Users/Documents/Kibana/src/plugins/vis_type_timeseries/server/lib/vis_data/response_processors/table/std_metric.js:43:12
   │ proc [kibana]     at runMicrotasks (<anonymous>)
   │ proc [kibana]     at processTicksAndRejections (internal/process/task_queues.js:95:5)
   │ proc [kibana]     at /Users/Documents/Kibana/src/plugins/vis_type_timeseries/server/lib/vis_data/table/process_bucket.js:50:30
   │ proc [kibana]     at async Promise.all (index 0)
   │ proc [kibana]     at /Users/Documents/Kibana/src/plugins/vis_type_timeseries/server/lib/vis_data/table/process_bucket.js:28:20
   │ proc [kibana]     at async Promise.all (index 0)
   │ proc [kibana]     at getTableData (/Users/Documents/Kibana/src/plugins/vis_type_timeseries/server/lib/vis_data/get_table_data.ts:100:20)
   │ proc [kibana]     at async Promise.all (index 0)
   │ proc [kibana]     at /Users/Documents/Kibana/src/plugins/vis_type_timeseries/server/routes/vis.ts:36:23
   │ proc [kibana]     at Router.handle (/Users/Documents/Kibana/src/core/server/http/router/router.ts:273:30)
   │ proc [kibana]     at handler (/Users/Documents/Kibana/src/core/server/http/router/router.ts:228:11)

@alexwizp alexwizp self-assigned this May 27, 2021
@alexwizp alexwizp requested a review from stratoula May 27, 2021 12:32
@alexwizp alexwizp added Team:Visualizations Visualization editors, elastic-charts and infrastructure auto-backport Deprecated - use backport:version if exact versions are needed labels May 27, 2021
@alexwizp alexwizp marked this pull request as ready for review May 27, 2021 12:35
@alexwizp alexwizp requested a review from a team May 27, 2021 12:35
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@alexwizp alexwizp removed the v7.13.1 label May 27, 2021
@alexwizp alexwizp mentioned this pull request May 27, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

References to deprecated APIs

id before after diff
lens 67 45 -22
licensing 18 15 -3
maps 286 208 -78
ml 121 115 -6
monitoring 109 56 -53
securitySolution 386 342 -44
stackAlerts 101 95 -6
total -212

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alexwizp

stratoula
stratoula approved these changes May 28, 2021
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alexwizp alexwizp enabled auto-merge (squash) May 28, 2021 13:30
@alexwizp alexwizp added auto-backport Deprecated - use backport:version if exact versions are needed and removed auto-backport Deprecated - use backport:version if exact versions are needed labels May 28, 2021
@timroes
Copy link
Contributor

timroes commented May 28, 2021

@elasticmachine run elasticsearch-ci/docs

@alexwizp alexwizp merged commit bd2bf74 into elastic:master May 28, 2021
@kibanamachine kibanamachine mentioned this pull request May 28, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 28, 2021
@alexwizp @kibanamachine
[TSVB] [Table tab] Fix "Math" aggregation (elastic#100765)
e561184
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 28, 2021
@alexwizp @kibanamachine
[TSVB] [Table tab] Fix "Math" aggregation (elastic#100765)
5b259aa
@kibanamachine kibanamachine mentioned this pull request May 28, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.13
✅ 7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request May 28, 2021
@kibanamachine @alexwizp
[TSVB] [Table tab] Fix "Math" aggregation (#100765) (#100895)
9b177ae 
Co-authored-by: Alexey Antonov <alexwizp@gmail.com>
kibanamachine added a commit that referenced this pull request May 28, 2021
@kibanamachine @alexwizp
[TSVB] [Table tab] Fix "Math" aggregation (#100765) (#100896)
50e6387 
Co-authored-by: Alexey Antonov <alexwizp@gmail.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request May 28, 2021
@gmmorris
Merge branch 'master' into task-manager/capacity-estimation
d1de507 
* master: (77 commits)
  [RAC][Security Solution] Register Security Detection Rules with Rule Registry (elastic#96015)
  [Enterprise Search] Log warning for Kibana/EntSearch version mismatches (elastic#100809)
  updating the saved objects test to include more saved object types (elastic#100828)
  [ML] Fix categorization job view examples link when datafeed uses multiple indices (elastic#100789)
  Fixing ES archive mapping failure (elastic#100835)
  Fix bug with Observability > APM header navigation (elastic#100845)
  [Security Solution][Endpoint] Add event filters summary card to the fleet endpoint tab (elastic#100668)
  [Actions] Taking space id into account when creating email footer link (elastic#100734)
  Ensure comments on parameters in arrow functions are captured in the docs and ci metrics. (elastic#100823)
  [Security Solution] Improve find rule and find rule status route performance (elastic#99678)
  [DOCS] Adds video to introduction (elastic#100906)
  [Fleet] Improve combo box for fleet settings (elastic#100603)
  [Security Solution][Endpoint] Endpoint generator and data loader support for Host Isolation (elastic#100813)
  [DOCS] Adds Lens video (elastic#100898)
  [TSVB] [Table tab] Fix "Math" aggregation (elastic#100765)
  chore(NA): moving @kbn/io-ts-utils into bazel (elastic#100810)
  [Alerting] Adding feature flag for enabling/disabling rule import and export (elastic#100718)
  [TSVB] Fix Upgrading from 7.12.1 to 7.13.0 breaks TSVB (elastic#100864)
  [Lens] Adds dynamic table cell coloring (elastic#95217)
  [Security Solution][Endpoint] Do not display searchbar in security-trusted apps if there are no items (elastic#100853)
  ...
@marius-dr marius-dr mentioned this pull request May 31, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stratoula stratoula stratoula approved these changes

Assignees

@alexwizp alexwizp

Labels
auto-backport Deprecated - use backport:version if exact versions are needed blocker Feature:TSVB TSVB (Time Series Visual Builder) release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.13.1 v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TSVB] [Table tab] "Math" aggregation not working for Table view
5 participants
@alexwizp @elasticmachine @kibanamachine @timroes @stratoula