Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update saved objects import test to include more saved object types #100828

Merged
merged 2 commits into from
May 28, 2021
Merged

Update saved objects import test to include more saved object types #100828

merged 2 commits into from
May 28, 2021

Conversation

bhavyarm
Copy link
Contributor

@bhavyarm bhavyarm commented May 27, 2021 •
edited
Loading

The test is using logstash functional data and shakespeare data to have both time-based and non time based index pattern. Its importing a saved objects ndJSON from 7.13.x to 8.0.0

Original PR is here - #91908

These are the saved object types included in the import test:

  • url (2)
  • index-pattern (5)
  • visualization (23)
  • tag (3)
  • map (1)
  • lens (17)
  • search (4)
  • dashboard (9)
  • config (2)
  • graph-workspace (1)
  • timelion-sheet (1)
  • canvas-element (1)
  • query (2)
  • canvas-workpad (1)

Missing saved objects:

  • action (0)
  • alert (0)
  • infrastructure-ui-source (0)
  • metrics-explorer-view (0)
  • inventory-view (0)
  • apm-indices (0)

Screen Shot 2021-05-28 at 9 29 56 AM

@bhavyarm bhavyarm self-assigned this May 27, 2021
@bhavyarm bhavyarm added v8.0.0 backport:skip This commit does not require backporting Feature:Saved Objects test_xpack_functional release_note:skip Skip the PR/issue when compiling release notes labels May 27, 2021
@bhavyarm bhavyarm requested review from marius-dr and LeeDr May 27, 2021 21:14
@bhavyarm bhavyarm added the Team:QA Team label for QA Team label May 27, 2021
@bhavyarm bhavyarm marked this pull request as ready for review May 27, 2021 23:41
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-qa (Team:QA)

@bhavyarm bhavyarm changed the title Updated saved objects import test to include all the possible core kibana saved object types. Update saved objects import test to include more saved object types May 28, 2021
LeeDr
LeeDr approved these changes May 28, 2021
View reviewed changes
Copy link
Contributor

@LeeDr LeeDr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - code reviewed and checked Jenkins results;

Kibana Pipeline / general / Saved objects management Export import saved objects between versions should be able to import 7.13 saved objects into 8.0.0 1 min 19 sec Passed

@bhavyarm
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

References to deprecated APIs

id before after diff
canvas 29 25 -4
crossClusterReplication 8 6 -2
fleet 22 20 -2
globalSearch 4 2 -2
indexManagement 12 7 -5
infra 261 149 -112
lens 67 45 -22
licensing 18 15 -3
lists 239 236 -3
maps 286 208 -78
ml 121 115 -6
monitoring 109 56 -53
securitySolution 386 342 -44
stackAlerts 101 95 -6
total -342

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @bhavyarm

marius-dr
marius-dr approved these changes May 28, 2021
View reviewed changes
Copy link
Member

@marius-dr marius-dr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bhavyarm bhavyarm merged commit 4989ec2 into elastic:master May 28, 2021
gmmorris added a commit to gmmorris/kibana that referenced this pull request May 28, 2021
@gmmorris
Merge branch 'master' into task-manager/capacity-estimation
d1de507 
* master: (77 commits)
  [RAC][Security Solution] Register Security Detection Rules with Rule Registry (elastic#96015)
  [Enterprise Search] Log warning for Kibana/EntSearch version mismatches (elastic#100809)
  updating the saved objects test to include more saved object types (elastic#100828)
  [ML] Fix categorization job view examples link when datafeed uses multiple indices (elastic#100789)
  Fixing ES archive mapping failure (elastic#100835)
  Fix bug with Observability > APM header navigation (elastic#100845)
  [Security Solution][Endpoint] Add event filters summary card to the fleet endpoint tab (elastic#100668)
  [Actions] Taking space id into account when creating email footer link (elastic#100734)
  Ensure comments on parameters in arrow functions are captured in the docs and ci metrics. (elastic#100823)
  [Security Solution] Improve find rule and find rule status route performance (elastic#99678)
  [DOCS] Adds video to introduction (elastic#100906)
  [Fleet] Improve combo box for fleet settings (elastic#100603)
  [Security Solution][Endpoint] Endpoint generator and data loader support for Host Isolation (elastic#100813)
  [DOCS] Adds Lens video (elastic#100898)
  [TSVB] [Table tab] Fix "Math" aggregation (elastic#100765)
  chore(NA): moving @kbn/io-ts-utils into bazel (elastic#100810)
  [Alerting] Adding feature flag for enabling/disabling rule import and export (elastic#100718)
  [TSVB] Fix Upgrading from 7.12.1 to 7.13.0 breaks TSVB (elastic#100864)
  [Lens] Adds dynamic table cell coloring (elastic#95217)
  [Security Solution][Endpoint] Do not display searchbar in security-trusted apps if there are no items (elastic#100853)
  ...
@bhavyarm bhavyarm mentioned this pull request Jun 14, 2021
Merged
21 tasks
This was referenced Oct 14, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marius-dr marius-dr marius-dr approved these changes

@LeeDr LeeDr LeeDr approved these changes

Assignees

@bhavyarm bhavyarm

Labels
backport:skip This commit does not require backporting Feature:Saved Objects release_note:skip Skip the PR/issue when compiling release notes Team:QA Team label for QA Team test_xpack_functional v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bhavyarm @elasticmachine @kibanamachine @marius-dr @LeeDr