Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Uptime] Fix uptime amsterdam UI issues #103683

Merged
merged 12 commits into from
Jul 1, 2021
Merged

[Uptime] Fix uptime amsterdam UI issues #103683

merged 12 commits into from
Jul 1, 2021

Conversation

dominiqueclarke
Copy link
Contributor

Summary

Fixes #96121

Fixes the two Amsterdam issues described in #96121

Disables enable monitor status alerts toggle on the monitor details page, while providing extra help text directing the user to the Settings page to define default connectors. This is necessary because in disabling the toggle, we prevent the ability to display a popover. Because of the length of the help text, I opted to place the status toggle below the heading. Please note: the font weight is off due to the issues described in #103670

Updates the casing of the monitor type on the monitor details page.

image

@dominiqueclarke dominiqueclarke added bug Fixes for quality problems that affect the customer experience v8.0.0 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability release_note:skip Skip the PR/issue when compiling release notes v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Jun 29, 2021
@dominiqueclarke dominiqueclarke requested a review from a team as a code owner June 29, 2021 15:01
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

justinkambic
justinkambic approved these changes Jun 29, 2021
View reviewed changes
Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, once CI is passing

x-pack/plugins/uptime/public/components/overview/monitor_list/columns/translations.ts
@@ -8,11 +8,11 @@
import { i18n } from '@kbn/i18n';

export const ENABLE_STATUS_ALERT = i18n.translate('xpack.uptime.monitorList.enableDownAlert', {
defaultMessage: 'Enable rule',
defaultMessage: 'Enable status alerts',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

10 similar comments
@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

9 similar comments
@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dominiqueclarke
Copy link
Contributor Author

@elasticmachine merge upstream

@spalger spalger added v7.15.0 and removed v7.14.0 labels Jun 30, 2021
@dominiqueclarke
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
uptime 952.0KB 953.3KB +1.2KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dominiqueclarke dominiqueclarke merged commit b7dc2c1 into elastic:master Jul 1, 2021
@dominiqueclarke dominiqueclarke deleted the fix/96121-uptime-amsterdam-ui-issues branch July 1, 2021 19:58
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Jul 1, 2021
@dominiqueclarke @justinkambic @kibanamachine
[Uptime] Fix uptime amsterdam UI issues (elastic#103683)
dcc87f4 
* Uptime - update monitor type format in StatusBar and update UI for define connectors switch

* update define_connectors

* Resolve type error.

* Add tests for `renderMonitorType`.

* remove unnecessary async specifier

* update i18n

* remove unused imports

* update i18n

Co-authored-by: Justin Kambic <justin.kambic@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Jul 1, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.14

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jul 1, 2021
@kibanamachine @dominiqueclarke @justinkambic
[Uptime] Fix uptime amsterdam UI issues (#103683) (#104200)
5736541 
* Uptime - update monitor type format in StatusBar and update UI for define connectors switch

* update define_connectors

* Resolve type error.

* Add tests for `renderMonitorType`.

* remove unnecessary async specifier

* update i18n

* remove unused imports

* update i18n

Co-authored-by: Justin Kambic <justin.kambic@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Dominique Clarke <doclarke71@gmail.com>
Co-authored-by: Justin Kambic <justin.kambic@elastic.co>
madirey pushed a commit to madirey/kibana that referenced this pull request Jul 6, 2021
@dominiqueclarke @justinkambic
@kibanamachine @madirey
[Uptime] Fix uptime amsterdam UI issues (elastic#103683)
7e2af39 
* Uptime - update monitor type format in StatusBar and update UI for define connectors switch

* update define_connectors

* Resolve type error.

* Add tests for `renderMonitorType`.

* remove unnecessary async specifier

* update i18n

* remove unused imports

* update i18n

Co-authored-by: Justin Kambic <justin.kambic@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@spalger spalger added the v7.15.0 label Jul 7, 2021
spalger pushed a commit to spalger/kibana that referenced this pull request Jul 7, 2021
@dominiqueclarke @justinkambic
@kibanamachine @spalger
[Uptime] Fix uptime amsterdam UI issues (elastic#103683)
e62b468 
* Uptime - update monitor type format in StatusBar and update UI for define connectors switch

* update define_connectors

* Resolve type error.

* Add tests for `renderMonitorType`.

* remove unnecessary async specifier

* update i18n

* remove unused imports

* update i18n

Co-authored-by: Justin Kambic <justin.kambic@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@spalger spalger mentioned this pull request Jul 7, 2021
Merged
spalger pushed a commit that referenced this pull request Jul 7, 2021
@dominiqueclarke @justinkambic @kibanamachine
[Uptime] Fix uptime amsterdam UI issues (#103683) (#104713)
1e797fd 
* Uptime - update monitor type format in StatusBar and update UI for define connectors switch

* update define_connectors

* Resolve type error.

* Add tests for `renderMonitorType`.

* remove unnecessary async specifier

* update i18n

* remove unused imports

* update i18n

Co-authored-by: Justin Kambic <justin.kambic@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Dominique Clarke <doclarke71@gmail.com>
Co-authored-by: Justin Kambic <justin.kambic@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinkambic justinkambic justinkambic approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.14.0 v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Uptime UI] Amsterdam related UI issues
5 participants
@dominiqueclarke @elasticmachine @kibanamachine @justinkambic @spalger