Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Observability] [Exploratory View] remove the filter buttons from the exploratory view legend #114908

Merged
merged 1 commit into from
Oct 14, 2021
Merged

[Observability] [Exploratory View] remove the filter buttons from the exploratory view legend #114908

merged 1 commit into from
Oct 14, 2021

Conversation

dominiqueclarke
Copy link
Contributor

@dominiqueclarke dominiqueclarke commented Oct 13, 2021 •
edited
Loading

Fixes #114868

Hide filter buttons from the exploratory view legend

Before
Screen Shot 2021-10-13 at 1 07 13 PM

After
Screen Shot 2021-10-13 at 3 30 04 PM

@dominiqueclarke dominiqueclarke added bug Fixes for quality problems that affect the customer experience v8.0.0 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 labels Oct 13, 2021
@dominiqueclarke dominiqueclarke requested a review from a team as a code owner October 13, 2021 19:36
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@dominiqueclarke dominiqueclarke changed the title remove the filter buttons from the exploratory view legend [Observability] [Exploratory View] remove the filter buttons from the exploratory view legend Oct 13, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 363.1KB 363.2KB +37.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

shahzad31
shahzad31 approved these changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please create a follow up issue to implement these filters, just for tracking purpose. LGTM !!

@dominiqueclarke
Copy link
Contributor Author

Can you please create a follow up issue to implement these filters, just for tracking purpose. LGTM !!

#115054

@dominiqueclarke dominiqueclarke merged commit e4e7a1c into elastic:master Oct 14, 2021
@dominiqueclarke dominiqueclarke deleted the feature/exploratory-view-hide-legend-fitlers branch October 14, 2021 16:43
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 14, 2021
@dominiqueclarke @kibanamachine
[Observability] [Exploratory view] remove the filter buttons from the…
72d550a 
… exploratory view legend (elastic#114908)
@kibanamachine kibanamachine mentioned this pull request Oct 14, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Oct 14, 2021
@kibanamachine @dominiqueclarke
[Observability] [Exploratory view] remove the filter buttons from the…
6fc1636 
… exploratory view legend (#114908) (#115055)

Co-authored-by: Dominique Clarke <doclarke71@gmail.com>
artem-shelkovnikov pushed a commit to artem-shelkovnikov/kibana that referenced this pull request Oct 20, 2021
@dominiqueclarke @artem-shelkovnikov
[Observability] [Exploratory view] remove the filter buttons from the…
db67c4b 
… exploratory view legend (elastic#114908)
@shahzad31
Copy link
Contributor

Post FF testing Looks good !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahzad31 shahzad31 shahzad31 approved these changes

@liciavale liciavale liciavale approved these changes

@drewpost drewpost Awaiting requested review from drewpost

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Observability] [Exploratory view] Hide legend filter buttons
5 participants
@dominiqueclarke @elasticmachine @kibanamachine @shahzad31 @liciavale