Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Workplace Search] Fix external connector button stuck loading #128617

Merged
merged 2 commits into from
Mar 28, 2022
Merged

[Workplace Search] Fix external connector button stuck loading #128617

merged 2 commits into from
Mar 28, 2022

Conversation

sphilipse
Copy link
Member

This fixes a minor bug where saving an external connector would get stuck in a loading state on API error.

@sphilipse sphilipse requested a review from a team March 28, 2022 13:12
@sphilipse sphilipse added release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v8.2.0 v8.3.0 backport:skip This commit does not require backporting and removed v8.3.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Mar 28, 2022
efegurkan
efegurkan approved these changes Mar 28, 2022
View reviewed changes
Copy link
Member

@efegurkan efegurkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I only have a nitpick comment

...ontent_sources/components/add_source/add_external_connector/external_connector_logic.test.ts Outdated Show resolved Hide resolved
@sphilipse sphilipse enabled auto-merge (squash) March 28, 2022 14:27
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 1.4MB 1.4MB +113.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sphilipse sphilipse merged commit 7494a91 into elastic:main Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efegurkan efegurkan efegurkan approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sphilipse @kibana-ci @efegurkan