Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Workplace Search] Fix external connector button stuck loading #128617

Merged
merged 2 commits into from
Mar 28, 2022
Merged

[Workplace Search] Fix external connector button stuck loading #128617

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de38f33
[Workplace Search] Fix external connector button stuck loading
sphilipse Mar 28, 2022
466c4ab
Make tests check entire state
sphilipse Mar 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions ...ent_sources/components/add_source/add_external_connector/external_connector_logic.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,18 @@ describe('ExternalConnectorLogic', () => {
});
});

describe('saveExternalConnectorConfigError', () => {
it('turns off the button loading flag', () => {
mount({
buttonLoading: true,
});

ExternalConnectorLogic.actions.saveExternalConnectorConfigError();

expect(ExternalConnectorLogic.values.buttonLoading).toEqual(false);
sphilipse marked this conversation as resolved.
Show resolved Hide resolved
});
});

describe('setExternalConnectorApiKey', () => {
it('updates the api key', () => {
ExternalConnectorLogic.actions.setExternalConnectorApiKey('abcd1234');
Expand Down
4 changes: 4 additions & 0 deletions .../content_sources/components/add_source/add_external_connector/external_connector_logic.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import { AddSourceLogic, SourceConfigData } from '../add_source_logic';
export interface ExternalConnectorActions {
fetchExternalSource: () => true;
fetchExternalSourceSuccess(sourceConfigData: SourceConfigData): SourceConfigData;
saveExternalConnectorConfigError: () => true;
saveExternalConnectorConfigSuccess(externalConnectorId: string): string;
setExternalConnectorApiKey(externalConnectorApiKey: string): string;
saveExternalConnectorConfig(config: ExternalConnectorConfig): ExternalConnectorConfig;
Expand Down Expand Up @@ -59,6 +60,7 @@ export const ExternalConnectorLogic = kea<
actions: {
fetchExternalSource: true,
fetchExternalSourceSuccess: (sourceConfigData) => sourceConfigData,
saveExternalConnectorConfigError: true,
saveExternalConnectorConfigSuccess: (externalConnectorId) => externalConnectorId,
saveExternalConnectorConfig: (config) => config,
setExternalConnectorApiKey: (externalConnectorApiKey: string) => externalConnectorApiKey,
Expand All @@ -78,6 +80,7 @@ export const ExternalConnectorLogic = kea<
false,
{
saveExternalConnectorConfigSuccess: () => false,
saveExternalConnectorConfigError: () => false,
saveExternalConnectorConfig: () => true,
},
],
Expand Down Expand Up @@ -168,6 +171,7 @@ export const ExternalConnectorLogic = kea<
getSourcesPath(`${getAddPath('external')}`, AppLogic.values.isOrganization)
);
} catch (e) {
actions.saveExternalConnectorConfigError();
flashAPIErrors(e);
}
}
Expand Down