[XY] Add `minTimeBarInterval` arg #128726

VladLasitsa · 2022-03-29T10:05:11Z

Completes part of #127115

Summary

Added possibility to override the min interval fot time bar chart.

elasticmachine · 2022-04-27T10:04:33Z

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

VladLasitsa · 2022-04-27T10:04:51Z

@elasticmachine merge upstream

VladLasitsa · 2022-04-29T10:06:18Z

@elasticmachine merge upstream

flash1293

LGTM, code review only

mbondyra · 2022-05-02T09:31:40Z

@elasticmachine merge upstream

src/plugins/chart_expressions/expression_xy/common/expression_functions/xy_vis.ts

Kuznietsov

During the testing, I realized, that this argument is not affecting the actual x-axis. Could you, please, fix this issue?

src/plugins/chart_expressions/expression_xy/common/expression_functions/validate.ts

src/plugins/chart_expressions/expression_xy/common/expression_functions/xy_vis_fn.ts

VladLasitsa · 2022-05-11T09:45:29Z

@elasticmachine merge upstream

…y_add_interval_arg

…-ref HEAD~1..HEAD --fix'

…y_add_interval_arg

flash1293

LGTM, tested and works as expected

kibana-ci · 2022-05-17T09:21:26Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`expressionXY`	93	94	+1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`expressionXY`	125	126	+1
`lens`	454	455	+1
total			+2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`expressionXY`	61.5KB	66.0KB	+4.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`expressionXY`	29.1KB	29.5KB	+362.0B

Unknown metric groups

API count

id	before	after	diff
`expressionXY`	135	136	+1
`lens`	529	530	+1
total			+2

History

💔 Build #45194 failed 3ca7d2c
💔 Build #44646 failed 1111f5e
💛 Build #43999 was flaky 1171fb3
💔 Build #43991 failed decfdc8
💚 Build #42414 succeeded 1cdb5c0
💔 Build #42355 failed 2fc8a44

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @VladLasitsa

Kuznietsov

Code LGTM 👍
Code Review only.

* Added `xAxisInterval` arg * Add validation * Add tests * Rename xAxisInterval to minTimeBarInterval and add validation * Fix imports * Add tests to validation * Fix conflicts * [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix' * Fix tests Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* wip I * add alert table state in case * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' * add new API to get FeatureID form registrationContext and update UI to use this new API * rm dead code * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' * remove unnecessary memo * adds tests for case view helpers * Move http call to API and add tests for getFeatureIds * fix type + unit test * add unit tests + cleanup * add new api integration test for _feature_ids * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' * Fix small type creating typescript slowness * remove console log * use import type for validfeatureId * force any to improve typescript performance * Update APM (#132270) Co-authored-by: Renovate Bot <bot@renovateapp.com> * [ResponseOps][Docs] Updating ServiceNow docs with OAuth setup instructions (#131344) * Updating ServiceNow docs. Need screenshots * Adding screenshots * Fix nested screenshots and lists * Tweaks and screenshots * Updates * blergh * Apply suggestions from code review Co-authored-by: Lisa Cawley <lcawley@elastic.co> * Apply suggestions from code review Co-authored-by: Mike Côté <mikecote@users.noreply.github.com> Co-authored-by: lcawl <lcawley@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Mike Côté <mikecote@users.noreply.github.com> * Show polling options when 'Data streams' option is selected in the Console Settings modal. (#132277) * [Osquery] Make Osquery All with All base privillege (#130523) * [XY] Add normalizeTable function to correct works with esdocs (#131917) * Add normalizeTable function to correct works with esdocs * Fix types * Fix types * Fix CI * Fix CI * Some fixes * Remove fallback with min/max value for domain * Added tests * Some refactoring Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Yaroslav Kuznietsov <kuznetsov.yaroslav.yk@gmail.com> * [Osquery] Add default osquery_saved_query objects (#129461) * [Unified Search] Show error message for invalid date filter value (#131290) * feat: added show error message for invalid date * refact: move logic in HOC * feat: refactoring code and added translation * refact show error * refact: show error message * refact: remove translation * refactor: changed menu for show FilterEdit * fix: open/close popover * feat: field.type => KBN_FIELD_TYPES * feat: remove extra code with with input check and refactored filter item * feat: added tests and refactoring code * refact: getFieldValidityAndErrorMessage * feat: return isInvalid checking in valur input type for string, ip * Update navigation landing pages to use appLinks config (#132027) * Update navigation landing pages to use appLinks config * Please code review * align app links changes * Update links descriptions * Rollback title changes * Fix wrong links descriptions * Fix unit tests * Fix description Co-authored-by: semd <sergi.massaneda@elastic.co> * [Cloud Posture] add resource findings page flyout (#132243) * [Discover] Add a tour for Document Explorer (#131125) * [Discover] Add "Take a tour" button to the Document Explorer callout * [Discover] Tmp * [Discover] Add a first Document Explorer tour step * [Discover] Add other Document Explorer tour steps * [Discover] Update tour steps positioning * [Discover] Add gifs to tour steps * [Discover] Refactor how tour steps are registered * [Discover] Add new step to the tour. Update tour steps text. * [Discover] Improve steps positioning * [Discover] Fix positioning for Add field step * [Discover] Add icons to tour steps * [Discover] Reorganize components * [Discover] Skip Columns step when it's not available * [Discover] Rename components * [Discover] Add some tests * [Discover] Fix positioning * [Discover] Fix props * [Discover] Render steps only if the tour is active * [Discover] Update gifs * [Discover] Add image alt text for gifs * [Discover] Tag the Take tour button * [Discover] Update text and tests * [Discover] Add more tests * [Discover] Rename assets directory * [Discover] Fix tour in mobile view. Improve steps positioning and animation. * [Discover] Update text in tour steps * [Discover] Update sort.gif * [Discover] Update image width * Update src/plugins/discover/public/components/discover_tour/discover_tour_provider.tsx Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * Update src/plugins/discover/public/components/discover_tour/discover_tour_provider.tsx Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * [Discover] Update sort.gif * [Discover] Fix code style Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> * [XY] Add `minTimeBarInterval` arg (#128726) * Added `xAxisInterval` arg * Add validation * Add tests * Rename xAxisInterval to minTimeBarInterval and add validation * Fix imports * Add tests to validation * Fix conflicts * [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix' * Fix tests Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> * do not use barrel imports * do not use barrel import * do not use barrel import * do not use barrel imports * do not use barrel import * import types * Add tests * Fix cases bundle size * Add more tests * [Fleet] Add new API to get current upgrades (#132276) * Add support of Data View switching for Agg-Based visualizations (#132184) * Add support of Data View switching for Agg-Based visualizations * fix CI * add use_date_view_updates * implement sync with state * cleanup * cleanup * cleanup * Update index.ts * fix PR comments * Update use_data_view_updates.ts * Update use_data_view_updates.ts Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> * [Security Solution] Responsive styling fixes (#131951) * [Discover] Add Analytics No Data Page (#131965) * [Discover] Add Analytics No Data Page * Make showEmptyPrompt parameter optional * Remove unused import * Remove unnecessary test * Fix test * Update failing test? * Update failing test * Changing the order of functional tests * Fix error handling * Addressing PR comments Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> * Remove barrel export from public index file * remove barrel export * Re-export missing exports * Turn off feature flag Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Esteban Beltran <esteban.beltran@elastic.co> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Ying Mao <ying.mao@elastic.co> Co-authored-by: lcawl <lcawley@elastic.co> Co-authored-by: Mike Côté <mikecote@users.noreply.github.com> Co-authored-by: CJ Cenizal <cj.cenizal@elastic.co> Co-authored-by: Tomasz Ciecierski <ciecierskitomek@gmail.com> Co-authored-by: Uladzislau Lasitsa <Uladzislau_Lasitsa@epam.com> Co-authored-by: Yaroslav Kuznietsov <kuznetsov.yaroslav.yk@gmail.com> Co-authored-by: Nodir Latipov <nodir.latypov@gmail.com> Co-authored-by: Pablo Machado <pablo.nevesmachado@elastic.co> Co-authored-by: semd <sergi.massaneda@elastic.co> Co-authored-by: Or Ouziel <or.ouziel@elastic.co> Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co> Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> Co-authored-by: Christos Nasikas <christos.nasikas@elastic.co> Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co> Co-authored-by: Alexey Antonov <alexwizp@gmail.com> Co-authored-by: Steph Milovic <stephanie.milovic@elastic.co> Co-authored-by: Maja Grubic <maja.grubic@elastic.co>

Added xAxisInterval arg

8151c16

VladLasitsa requested a review from Kuznietsov March 29, 2022 10:05

VladLasitsa mentioned this pull request Mar 29, 2022

[XY] Add interval arg #128157

Closed

VladLasitsa self-assigned this Mar 29, 2022

VladLasitsa added Feature:XYAxis XY-Axis charts (bar, area, line) Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.2.0 labels Mar 29, 2022

VladLasitsa mentioned this pull request Mar 30, 2022

[XY] Expression unification #127115

Closed

31 tasks

VladLasitsa marked this pull request as ready for review April 27, 2022 10:04

VladLasitsa requested a review from a team as a code owner April 27, 2022 10:04

Merge branch 'main' into chart_expressions_xy_add_interval_arg

91aee1b

VladLasitsa added v8.3.0 and removed v8.2.0 labels Apr 28, 2022

Merge branch 'main' into chart_expressions_xy_add_interval_arg

530d42c

flash1293 approved these changes Apr 29, 2022

View reviewed changes

Merge branch 'main' into chart_expressions_xy_add_interval_arg

a0837b4

Kuznietsov reviewed May 4, 2022

View reviewed changes

src/plugins/chart_expressions/expression_xy/common/expression_functions/xy_vis.ts Outdated Show resolved Hide resolved

VladLasitsa added 3 commits May 4, 2022 12:33

Merge branch 'main' into chart_expressions_xy_add_interval_arg

c364bc6

Add validation

2fc8a44

Add tests

1cdb5c0

Kuznietsov reviewed May 5, 2022

View reviewed changes

src/plugins/chart_expressions/expression_xy/common/expression_functions/validate.ts Outdated Show resolved Hide resolved

src/plugins/chart_expressions/expression_xy/common/expression_functions/xy_vis_fn.ts Outdated Show resolved Hide resolved

VladLasitsa added the WIP Work in progress label May 6, 2022

Merge branch 'main' into chart_expressions_xy_add_interval_arg

8d37395

VladLasitsa added 3 commits May 11, 2022 13:46

Rename xAxisInterval to minTimeBarInterval and add validation

decfdc8

Fix imports

dc70053

Add tests to validation

1171fb3

VladLasitsa changed the title ~~[XY] Add xAxisInterval arg~~ [XY] Add minTimeBarInterval arg May 11, 2022

VladLasitsa and others added 5 commits May 13, 2022 11:08

Merge remote-tracking branch 'upstream/main' into chart_expressions_x…

9324056

…y_add_interval_arg

Fix conflicts

9026e8e

[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…

1111f5e

…-ref HEAD~1..HEAD --fix'

Merge remote-tracking branch 'upstream/main' into chart_expressions_x…

3ca7d2c

…y_add_interval_arg

Fix tests

ad797d6

VladLasitsa requested a review from Kuznietsov May 17, 2022 08:12

Merge remote-tracking branch 'upstream/main' into chart_expressions_x…

83cb560

…y_add_interval_arg

flash1293 approved these changes May 17, 2022

View reviewed changes

Kuznietsov approved these changes May 17, 2022

View reviewed changes

VladLasitsa merged commit fe04423 into elastic:main May 17, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[XY] Add `minTimeBarInterval` arg #128726

[XY] Add `minTimeBarInterval` arg #128726

VladLasitsa commented Mar 29, 2022 •

edited

Loading

elasticmachine commented Apr 27, 2022

VladLasitsa commented Apr 27, 2022

VladLasitsa commented Apr 29, 2022

flash1293 left a comment

mbondyra commented May 2, 2022

Kuznietsov left a comment

VladLasitsa commented May 11, 2022

flash1293 left a comment

kibana-ci commented May 17, 2022

API count

Kuznietsov left a comment •

edited

Loading

[XY] Add minTimeBarInterval arg #128726

[XY] Add minTimeBarInterval arg #128726

Conversation

VladLasitsa commented Mar 29, 2022 • edited Loading

Summary

elasticmachine commented Apr 27, 2022

VladLasitsa commented Apr 27, 2022

VladLasitsa commented Apr 29, 2022

flash1293 left a comment

Choose a reason for hiding this comment

mbondyra commented May 2, 2022

Kuznietsov left a comment

Choose a reason for hiding this comment

VladLasitsa commented May 11, 2022

flash1293 left a comment

Choose a reason for hiding this comment

kibana-ci commented May 17, 2022

💚 Build Succeeded

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Page load bundle

API count

History

Kuznietsov left a comment • edited Loading

Choose a reason for hiding this comment

[XY] Add `minTimeBarInterval` arg #128726

[XY] Add `minTimeBarInterval` arg #128726

VladLasitsa commented Mar 29, 2022 •

edited

Loading

Kuznietsov left a comment •

edited

Loading