Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Changes to agent upgrade modal to allow for rolling upgrades #132421

Merged
merged 11 commits into from
May 20, 2022

Conversation

criamico
Copy link
Contributor

@criamico criamico commented May 18, 2022

Summary

Part of #130259

Fixes #131506

Changes to the "agent modal upgrade" modal to use the new bulk upgrade api

One agent

Upgrade_one_agent

Several agents

<= 10 agents
Screenshot 2022-05-19 at 16 01 35

10 agents
Screenshot 2022-05-19 at 16 01 10

Error Callout (400 errors)

Screenshot 2022-05-19 at 16 55 40

Checklist

Delete any items that are not applicable to this PR.

@criamico criamico self-assigned this May 18, 2022
@criamico criamico changed the title Rolling upgrade/upgrade modal [Fleet] Changes to agent upgrade modal to allow for rolling upgrades May 18, 2022
@criamico criamico added ci:no-auto-commit Disable auto-committing changes on CI v8.3.0 Team:Fleet Team label for Observability Data Collection Fleet team labels May 18, 2022
@criamico criamico added the release_note:feature Makes this part of the condensed release notes label May 18, 2022
@criamico criamico marked this pull request as ready for review May 19, 2022 14:11
@criamico criamico requested a review from a team as a code owner May 19, 2022 14:11
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@nchaulet nchaulet self-requested a review May 19, 2022 14:58
@criamico
Copy link
Contributor Author

@elasticmachine merge upstream

Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small suggestions but otherwise it's working well 🚀

// These versions are only intended to be used as a fallback
// in the event that the updated versions cannot be retrieved from the endpoint

export const FALLBACK_VERSIONS = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add 8.3.0 too here? or can we dynamically add the current kibana version so it's not breaking when we create a new kibana version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the version dynamically in the component.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
fleet 623 624 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 705.9KB 707.8KB +1.9KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @criamico

@criamico criamico merged commit aa4c389 into elastic:main May 20, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 20, 2022
@criamico criamico deleted the rolling_upgrade/upgrade_modal branch May 20, 2022 10:24
j-bennet pushed a commit to j-bennet/kibana that referenced this pull request Jun 2, 2022
…lastic#132421)

* [Fleet] Changes to agent upgrade modal to allow for rolling upgrades

* Update the onSubmit logic and handle case with single agent

* Fix check

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* Add option to upgrade immediately; minor fixes

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* Add callout in modal for 400 errors

* Linter fixes

* Fix i18n error

* Address code review comments

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting ci:no-auto-commit Disable auto-committing changes on CI release_note:feature Makes this part of the condensed release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fleet]: Action button for bulk actions is not collapsed on clicking button again.
5 participants