Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SecuritySolution] Refactor security packages #155365

Merged
merged 30 commits into from
Apr 26, 2023
Merged

[SecuritySolution] Refactor security packages #155365

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
96d302a
move security-solution package directory
semd Apr 20, 2023
7f6fb80
ecs data qa dashboard moved
semd Apr 20, 2023
13d39ee
translations prefixes changed
semd Apr 20, 2023
2da6b7e
move data_table package
semd Apr 20, 2023
9b00173
data_table configs and translations
semd Apr 20, 2023
98b7395
storybook fixes
semd Apr 20, 2023
acf1c1e
[CI] Auto-commit changed files from 'node scripts/lint_packages --fix'
kibanamachine Apr 20, 2023
07c69e3
[CI] Auto-commit changed files from 'node scripts/generate codeowners'
kibanamachine Apr 20, 2023
295b159
translations auto fixed
semd Apr 20, 2023
0cf6687
Merge remote-tracking branch 'upstream/main' into 155301_refactor_sec…
semd Apr 20, 2023
3a97c00
fix lint errors
semd Apr 20, 2023
23cb83e
Merge branch '155301_refactor_security_packages' of https://github.co…
semd Apr 20, 2023
c147bc8
Merge branch 'main' into 155301_refactor_security_packages
kibanamachine Apr 20, 2023
3985d0b
Merge branch 'main' into 155301_refactor_security_packages
kibanamachine Apr 21, 2023
9e9f8b1
Merge branch 'main' into 155301_refactor_security_packages
kibanamachine Apr 21, 2023
8e5b8d8
Merge branch 'main' into 155301_refactor_security_packages
kibanamachine Apr 21, 2023
5077331
Merge branch 'main' into 155301_refactor_security_packages
kibanamachine Apr 21, 2023
90b64c9
Merge branch 'main' into 155301_refactor_security_packages
kibanamachine Apr 21, 2023
0b87015
Merge branch 'main' into 155301_refactor_security_packages
kibanamachine Apr 24, 2023
b2024c5
help git to make merge easier
semd Apr 25, 2023
25e5a97
conflicts solved
semd Apr 25, 2023
f5619e0
moving again
semd Apr 25, 2023
4e3c6ad
translations prefixes
semd Apr 25, 2023
281e4f2
translations prefixes
semd Apr 25, 2023
80538ed
i18n
semd Apr 25, 2023
d06ff1a
Merge branch '155301_refactor_security_packages' of https://github.co…
semd Apr 25, 2023
c8f093b
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine Apr 25, 2023
7a59e69
Merge remote-tracking branch 'upstream/main' into 155301_refactor_sec…
semd Apr 26, 2023
addb3be
coverage dir
semd Apr 26, 2023
f143f6c
Merge branch 'main' into 155301_refactor_security_packages
kibanamachine Apr 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -980,7 +980,7 @@ module.exports = {
// front end and common typescript and javascript files only
files: [
'x-pack/plugins/ecs_data_quality_dashboard/common/**/*.{js,mjs,ts,tsx}',
'x-pack/packages/kbn-ecs-data-quality-dashboard/common/**/*.{js,mjs,ts,tsx}',
'x-pack/packages/security-solution/**/*.{js,mjs,ts,tsx}',
'x-pack/plugins/security_solution/public/**/*.{js,mjs,ts,tsx}',
'x-pack/plugins/security_solution/common/**/*.{js,mjs,ts,tsx}',
'x-pack/plugins/timelines/public/**/*.{js,mjs,ts,tsx}',
Expand All @@ -1007,14 +1007,14 @@ module.exports = {
// This should be a very small set as most linter rules are useful for tests as well.
files: [
'x-pack/plugins/ecs_data_quality_dashboard/**/*.{ts,tsx}',
'x-pack/packages/kbn-ecs-data-quality-dashboard/**/*.{ts,tsx}',
'x-pack/packages/security-solution/**/*.{ts,tsx}',
'x-pack/plugins/security_solution/**/*.{ts,tsx}',
'x-pack/plugins/timelines/**/*.{ts,tsx}',
'x-pack/plugins/cases/**/*.{ts,tsx}',
],
excludedFiles: [
'x-pack/plugins/ecs_data_quality_dashboard/**/*.{test,mock,test_helper}.{ts,tsx}',
'x-pack/packages/kbn-ecs-data-quality-dashboard/**/*.{test,mock,test_helper}.{ts,tsx}',
'x-pack/packages/security-solution/**/*.{test,mock,test_helper}.{ts,tsx}',
'x-pack/plugins/security_solution/**/*.{test,mock,test_helper}.{ts,tsx}',
'x-pack/plugins/timelines/**/*.{test,mock,test_helper}.{ts,tsx}',
'x-pack/plugins/cases/**/*.{test,mock,test_helper}.{ts,tsx}',
Expand All @@ -1027,7 +1027,7 @@ module.exports = {
// typescript only for front and back end
files: [
'x-pack/plugins/ecs_data_quality_dashboard/**/*.{ts,tsx}',
'x-pack/packages/kbn-ecs-data-quality-dashboard/**/*.{ts,tsx}',
'x-pack/packages/security-solution/**/*.{ts,tsx}',
'x-pack/plugins/security_solution/**/*.{ts,tsx}',
'x-pack/plugins/timelines/**/*.{ts,tsx}',
'x-pack/plugins/cases/**/*.{ts,tsx}',
Expand Down Expand Up @@ -1059,7 +1059,7 @@ module.exports = {
// typescript and javascript for front and back end
files: [
'x-pack/plugins/ecs_data_quality_dashboard/**/*.{js,mjs,ts,tsx}',
'x-pack/packages/kbn-ecs-data-quality-dashboard/**/*.{js,mjs,ts,tsx}',
'x-pack/packages/security-solution/**/*.{js,mjs,ts,tsx}',
'x-pack/plugins/security_solution/**/*.{js,mjs,ts,tsx}',
'x-pack/plugins/timelines/**/*.{js,mjs,ts,tsx}',
'x-pack/plugins/cases/**/*.{js,mjs,ts,tsx}',
Expand Down
8 changes: 4 additions & 4 deletions .github/CODEOWNERS
View file
Open in desktop
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,7 @@ packages/kbn-docs-utils @elastic/kibana-operations
packages/kbn-dom-drag-drop @elastic/kibana-visualizations @elastic/kibana-data-discovery
packages/kbn-ebt-tools @elastic/kibana-core
packages/kbn-ecs @elastic/kibana-core @elastic/security-threat-hunting-investigations
x-pack/packages/kbn-ecs-data-quality-dashboard @elastic/security-threat-hunting-investigations
x-pack/packages/security-solution/ecs_data_quality_dashboard @elastic/security-threat-hunting-investigations
x-pack/plugins/ecs_data_quality_dashboard @elastic/security-threat-hunting-investigations
test/plugin_functional/plugins/elasticsearch_client_plugin @elastic/kibana-core
x-pack/test/plugin_api_integration/plugins/elasticsearch_client @elastic/kibana-core
Expand Down Expand Up @@ -543,11 +543,11 @@ x-pack/test/security_api_integration/packages/helpers @elastic/kibana-core
x-pack/plugins/security @elastic/kibana-security
x-pack/test/cases_api_integration/common/plugins/security_solution @elastic/response-ops
x-pack/plugins/security_solution @elastic/security-solution
packages/security-solution/side_nav @elastic/security-threat-hunting-explore
packages/security-solution/storybook/config @elastic/security-threat-hunting-explore
x-pack/packages/security-solution/side_nav @elastic/security-threat-hunting-explore
x-pack/packages/security-solution/storybook/config @elastic/security-threat-hunting-explore
x-pack/test/security_functional/plugins/test_endpoints @elastic/kibana-security
packages/kbn-securitysolution-autocomplete @elastic/security-solution-platform
x-pack/packages/kbn-securitysolution-data-table @elastic/security-threat-hunting-investigations
x-pack/packages/security-solution/data_table @elastic/security-threat-hunting-investigations
packages/kbn-securitysolution-ecs @elastic/security-threat-hunting-explore
packages/kbn-securitysolution-es-utils @elastic/security-solution-platform
packages/kbn-securitysolution-exception-list-components @elastic/security-solution-platform
Expand Down
4 changes: 1 addition & 3 deletions .i18nrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
"domDragDrop": "packages/kbn-dom-drag-drop",
"controls": "src/plugins/controls",
"data": "src/plugins/data",
"ecsDataQualityDashboard": "x-pack/packages/kbn-ecs-data-quality-dashboard",
"observabilityAlertDetails": "x-pack/packages/observability/alert_details",
"dataViews": "src/plugins/data_views",
"devTools": "src/plugins/dev_tools",
Expand Down Expand Up @@ -80,11 +79,10 @@
"savedObjects": "src/plugins/saved_objects",
"savedObjectsFinder": "src/plugins/saved_objects_finder",
"savedObjectsManagement": "src/plugins/saved_objects_management",
"securitySolutionDataTable": "packages/kbn-securitysolution-data-table",
"server": "src/legacy/server",
"share": "src/plugins/share",
"sharedUXPackages": "packages/shared-ux",
"securitySolutionPackages": "packages/security-solution",
"securitySolutionPackages": "x-pack/packages/security-solution",
"coloring": "packages/kbn-coloring/src",
"languageDocumentationPopover": "packages/kbn-language-documentation-popover/src",
"statusPage": "src/legacy/core_plugins/status_page",
Expand Down
8 changes: 4 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,7 @@
"@kbn/dom-drag-drop": "link:packages/kbn-dom-drag-drop",
"@kbn/ebt-tools": "link:packages/kbn-ebt-tools",
"@kbn/ecs": "link:packages/kbn-ecs",
"@kbn/ecs-data-quality-dashboard": "link:x-pack/packages/kbn-ecs-data-quality-dashboard",
"@kbn/ecs-data-quality-dashboard": "link:x-pack/packages/security-solution/ecs_data_quality_dashboard",
"@kbn/ecs-data-quality-dashboard-plugin": "link:x-pack/plugins/ecs_data_quality_dashboard",
"@kbn/elasticsearch-client-plugin": "link:test/plugin_functional/plugins/elasticsearch_client_plugin",
"@kbn/elasticsearch-client-xpack-plugin": "link:x-pack/test/plugin_api_integration/plugins/elasticsearch_client",
Expand Down Expand Up @@ -544,11 +544,11 @@
"@kbn/security-plugin": "link:x-pack/plugins/security",
"@kbn/security-solution-fixtures-plugin": "link:x-pack/test/cases_api_integration/common/plugins/security_solution",
"@kbn/security-solution-plugin": "link:x-pack/plugins/security_solution",
"@kbn/security-solution-side-nav": "link:packages/security-solution/side_nav",
"@kbn/security-solution-storybook-config": "link:packages/security-solution/storybook/config",
"@kbn/security-solution-side-nav": "link:x-pack/packages/security-solution/side_nav",
"@kbn/security-solution-storybook-config": "link:x-pack/packages/security-solution/storybook/config",
"@kbn/security-test-endpoints-plugin": "link:x-pack/test/security_functional/plugins/test_endpoints",
"@kbn/securitysolution-autocomplete": "link:packages/kbn-securitysolution-autocomplete",
"@kbn/securitysolution-data-table": "link:x-pack/packages/kbn-securitysolution-data-table",
"@kbn/securitysolution-data-table": "link:x-pack/packages/security-solution/data_table",
"@kbn/securitysolution-ecs": "link:packages/kbn-securitysolution-ecs",
"@kbn/securitysolution-es-utils": "link:packages/kbn-securitysolution-es-utils",
"@kbn/securitysolution-exception-list-components": "link:packages/kbn-securitysolution-exception-list-components",
Expand Down
2 changes: 1 addition & 1 deletion packages/kbn-babel-preset/styled_components_files.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ module.exports = {
* Used by `kbn-babel-preset` and `kbn-eslint-config`.
*/
USES_STYLED_COMPONENTS: [
/packages[\/\\](kbn-ui-shared-deps-(npm|src)|kbn-ecs-data-quality-dashboard)[\/\\]/,
/packages[\/\\]kbn-ui-shared-deps-(npm|src)[\/\\]/,
/src[\/\\]plugins[\/\\](kibana_react)[\/\\]/,
/x-pack[\/\\]plugins[\/\\](apm|beats_management|cases|fleet|infra|lists|observability|observability_shared|exploratory_view|osquery|security_solution|timelines|synthetics|ux)[\/\\]/,
/x-pack[\/\\]test[\/\\]plugin_functional[\/\\]plugins[\/\\]resolver_test[\/\\]/,
Expand Down
13 changes: 0 additions & 13 deletions packages/security-solution/side_nav/jest.config.js
View file
Open in desktop

This file was deleted.

9 changes: 0 additions & 9 deletions packages/security-solution/storybook/config/index.ts
View file
Open in desktop

This file was deleted.

3 changes: 1 addition & 2 deletions src/dev/storybook/aliases.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,7 @@ export const storybookAliases = {
observability: 'x-pack/plugins/observability/.storybook',
presentation: 'src/plugins/presentation_util/storybook',
security_solution: 'x-pack/plugins/security_solution/.storybook',
security_solution_packages: 'packages/security-solution/storybook/config',
security_solution_data_table: 'x-pack/packages/kbn-securitysolution-data-table/.storybook',
security_solution_packages: 'x-pack/packages/security-solution/storybook/config',
shared_ux: 'packages/shared-ux/storybook/config',
threat_intelligence: 'x-pack/plugins/threat_intelligence/.storybook',
triggers_actions_ui: 'x-pack/plugins/triggers_actions_ui/.storybook',
Expand Down
16 changes: 8 additions & 8 deletions tsconfig.base.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -624,8 +624,8 @@
"@kbn/ebt-tools/*": ["packages/kbn-ebt-tools/*"],
"@kbn/ecs": ["packages/kbn-ecs"],
"@kbn/ecs/*": ["packages/kbn-ecs/*"],
"@kbn/ecs-data-quality-dashboard": ["x-pack/packages/kbn-ecs-data-quality-dashboard"],
"@kbn/ecs-data-quality-dashboard/*": ["x-pack/packages/kbn-ecs-data-quality-dashboard/*"],
"@kbn/ecs-data-quality-dashboard": ["x-pack/packages/security-solution/ecs_data_quality_dashboard"],
"@kbn/ecs-data-quality-dashboard/*": ["x-pack/packages/security-solution/ecs_data_quality_dashboard/*"],
"@kbn/ecs-data-quality-dashboard-plugin": ["x-pack/plugins/ecs_data_quality_dashboard"],
"@kbn/ecs-data-quality-dashboard-plugin/*": ["x-pack/plugins/ecs_data_quality_dashboard/*"],
"@kbn/elasticsearch-client-plugin": ["test/plugin_functional/plugins/elasticsearch_client_plugin"],
Expand Down Expand Up @@ -1080,16 +1080,16 @@
"@kbn/security-solution-fixtures-plugin/*": ["x-pack/test/cases_api_integration/common/plugins/security_solution/*"],
"@kbn/security-solution-plugin": ["x-pack/plugins/security_solution"],
"@kbn/security-solution-plugin/*": ["x-pack/plugins/security_solution/*"],
"@kbn/security-solution-side-nav": ["packages/security-solution/side_nav"],
"@kbn/security-solution-side-nav/*": ["packages/security-solution/side_nav/*"],
"@kbn/security-solution-storybook-config": ["packages/security-solution/storybook/config"],
"@kbn/security-solution-storybook-config/*": ["packages/security-solution/storybook/config/*"],
"@kbn/security-solution-side-nav": ["x-pack/packages/security-solution/side_nav"],
"@kbn/security-solution-side-nav/*": ["x-pack/packages/security-solution/side_nav/*"],
"@kbn/security-solution-storybook-config": ["x-pack/packages/security-solution/storybook/config"],
"@kbn/security-solution-storybook-config/*": ["x-pack/packages/security-solution/storybook/config/*"],
"@kbn/security-test-endpoints-plugin": ["x-pack/test/security_functional/plugins/test_endpoints"],
"@kbn/security-test-endpoints-plugin/*": ["x-pack/test/security_functional/plugins/test_endpoints/*"],
"@kbn/securitysolution-autocomplete": ["packages/kbn-securitysolution-autocomplete"],
"@kbn/securitysolution-autocomplete/*": ["packages/kbn-securitysolution-autocomplete/*"],
"@kbn/securitysolution-data-table": ["x-pack/packages/kbn-securitysolution-data-table"],
"@kbn/securitysolution-data-table/*": ["x-pack/packages/kbn-securitysolution-data-table/*"],
"@kbn/securitysolution-data-table": ["x-pack/packages/security-solution/data_table"],
"@kbn/securitysolution-data-table/*": ["x-pack/packages/security-solution/data_table/*"],
"@kbn/securitysolution-ecs": ["packages/kbn-securitysolution-ecs"],
"@kbn/securitysolution-ecs/*": ["packages/kbn-securitysolution-ecs/*"],
"@kbn/securitysolution-es-utils": ["packages/kbn-securitysolution-es-utils"],
Expand Down
20 changes: 0 additions & 20 deletions ...d/impl/data_quality/data_quality_panel/data_quality_summary/errors_viewer/translations.ts
View file
Open in desktop

This file was deleted.

Loading