Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SecuritySolution] Refactor security packages #155365

Merged
merged 30 commits into from
Apr 26, 2023
Merged

[SecuritySolution] Refactor security packages #155365

merged 30 commits into from
Apr 26, 2023

Conversation

semd
Copy link
Contributor

@semd semd commented Apr 20, 2023

Summary

closes: #155301

Moves packages/security-solution/ to x-pack/packages/security-solution/
Moves x-pack/packages/kbn-securitysolution-* into the new x-pack/packages/security-solution/

It contains 3 packages now:

  • data_view/
  • ecs_data_quality_dashboard/
  • side_nav/

Package names and ids have not changed.

Other

  • eslint configured for all the packages in the directory
  • i18n prefix securitySolutionPackages configured for all packages in the directory
  • generic storybook configuration, run with: yarn storybook security_solution_packages

@semd semd added refactoring technical debt Improvement of the software architecture and operational architecture release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team v8.8.0 labels Apr 20, 2023
@semd semd self-assigned this Apr 20, 2023
@semd semd requested review from a team as code owners April 20, 2023 10:46
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@semd
Copy link
Contributor Author

semd commented Apr 20, 2023

@elasticmachine merge upstream

@semd
Copy link
Contributor Author

semd commented Apr 21, 2023

@elasticmachine merge upstream

@semd
Copy link
Contributor Author

semd commented Apr 21, 2023

@elasticmachine merge upstream

machadoum
machadoum approved these changes Apr 21, 2023
View reviewed changes
Copy link
Member

@machadoum machadoum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explore team code LGTM!

@semd
Copy link
Contributor Author

semd commented Apr 21, 2023

@elasticmachine merge upstream

@semd
Copy link
Contributor Author

semd commented Apr 21, 2023

@elasticmachine merge upstream

@semd
Copy link
Contributor Author

semd commented Apr 21, 2023

@elasticmachine merge upstream

@semd
Copy link
Contributor Author

semd commented Apr 24, 2023

@elasticmachine merge upstream

@semd
Copy link
Contributor Author

semd commented Apr 24, 2023

waiting for #155581 changes to be included in this PR

andrew-goldstein
andrew-goldstein approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@andrew-goldstein andrew-goldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for moving the security packages to a common home @semd! 🙏
✅ Data Quality dashboard desk tested locally
LGTM 🚀

@semd semd enabled auto-merge (squash) April 26, 2023 09:41
@semd
Copy link
Contributor Author

semd commented Apr 26, 2023

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 9.1MB 9.1MB +4.0KB
Unknown metric groups

ESLint disabled line counts

id before after diff
@kbn/security-solution-side-nav 1 2 +1
@kbn/securitysolution-data-table 3 4 +1
enterpriseSearch 17 19 +2
securitySolution 399 402 +3
total +7

Total ESLint disabled count

id before after diff
@kbn/security-solution-side-nav 2 3 +1
@kbn/securitysolution-data-table 5 6 +1
enterpriseSearch 18 20 +2
securitySolution 479 482 +3
total +7

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @semd

@semd semd merged commit 202f13f into elastic:main Apr 26, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 26, 2023
jloleysens added a commit to jloleysens/kibana that referenced this pull request Apr 26, 2023
@jloleysens
Merge branch 'main' into compatible-schema-change-check
ab5ff42 
* main: (1294 commits)
  [SecuritySolution] Refactor security packages (elastic#155365)
  [Discover] Show "Temporary" badge for ad-hoc data views in Alerts flyout (elastic#155717)
  [RAM] Conditional actions feedback on pr review (elastic#155804)
  [Files] Adds bulk delete method (elastic#155628)
  [Lens] Use proper way to generate absolute short URL (elastic#155512)
  [Guided onboarding] Use Kibana features to grant access (elastic#155065)
  [Index Management] Fix duped mock (elastic#155844)
  [Lens] Enhance visualization modifier popup with layer palette (elastic#155280)
  Fix flaky combobox tests on role management screen (elastic#155711)
  [Infrastructure UI] Create InventoryViewsService and InventoryViewsClient (elastic#155126)
  [Fleet] always create agent upload write indices (elastic#155729)
  [Fleet] [Cloud Security Posture] Add CloudFormation agent install method (elastic#155045)
  Add tech preview label for search applications (elastic#155649)
  [ML] AIOps: Stabilize flaky functional tests. (elastic#155710)
  [ES UI Shared] Migrate JsonEditor to monaco (elastic#155610)
  [Security Solution] Fixes security_solution storybooks always rendering in a flyout (elastic#155814)
  [Synthetics] Make error popover disappear `onMouseLeave` of metric item card (elastic#155800)
  Remove Exploratory View components from Observability (elastic#155629)
  [Discover] Remove redundant "Filter was added" toast (elastic#155645)
  [RAM][Security Solution][Alerts] Support the ability to trigger a rule action per alert generated (elastic#153611) (elastic#155384)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machadoum machadoum machadoum approved these changes

@jbudz jbudz jbudz approved these changes

@andrew-goldstein andrew-goldstein andrew-goldstein approved these changes

@lgestc lgestc lgestc approved these changes

Assignees

@semd semd

Labels
backport:skip This commit does not require backporting refactoring release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team technical debt Improvement of the software architecture and operational architecture v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SecuritySolution] Build a home 🏠 for Security packages
8 participants
@semd @elasticmachine @kibana-ci @machadoum @jbudz @andrew-goldstein @lgestc @kibanamachine