[Files] Adds bulk delete method #155628
[Files] Adds bulk delete method #155628
Conversation
vadimkibana
added
review
release_note:skip
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
vadimkibana
changed the title
💚 Build Succeeded
Metrics [docs]Public APIs missing exports
Unknown metric groupsAPI count
ESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: |
| public async bulkDeleteFiles({ | ||
| ids, | ||
| }: BulkDeleteFilesArgs): Promise<Array<PromiseSettledResult<void>>> { | ||
| const promises = ids.map((id) => bulkDeleteConcurrency(() => this.deleteFile({ id }))); |
There was a problem hiding this comment.
I know there's complexities here that I'm not aware of but would it be possible to use the saved object client's bulkDelete functionality?
There was a problem hiding this comment.
If you look at the private get below you can see that there is some logic encapsulated. It converts the id to a File instance and calls its delete() method which then delete the content from the blob storage, calls the updateFileState to change the state, delete the SO and finally logs some events logAuditEvent 😊
That's what we hook into.
There was a problem hiding this comment.
+1 to what @sebelga mentioned, essentially, before even deleting the saved object metadata document, we need to delete the blob contents first, which is stored in a different place.
* main: (1294 commits) [SecuritySolution] Refactor security packages (elastic#155365) [Discover] Show "Temporary" badge for ad-hoc data views in Alerts flyout (elastic#155717) [RAM] Conditional actions feedback on pr review (elastic#155804) [Files] Adds bulk delete method (elastic#155628) [Lens] Use proper way to generate absolute short URL (elastic#155512) [Guided onboarding] Use Kibana features to grant access (elastic#155065) [Index Management] Fix duped mock (elastic#155844) [Lens] Enhance visualization modifier popup with layer palette (elastic#155280) Fix flaky combobox tests on role management screen (elastic#155711) [Infrastructure UI] Create InventoryViewsService and InventoryViewsClient (elastic#155126) [Fleet] always create agent upload write indices (elastic#155729) [Fleet] [Cloud Security Posture] Add CloudFormation agent install method (elastic#155045) Add tech preview label for search applications (elastic#155649) [ML] AIOps: Stabilize flaky functional tests. (elastic#155710) [ES UI Shared] Migrate JsonEditor to monaco (elastic#155610) [Security Solution] Fixes security_solution storybooks always rendering in a flyout (elastic#155814) [Synthetics] Make error popover disappear `onMouseLeave` of metric item card (elastic#155800) Remove Exploratory View components from Observability (elastic#155629) [Discover] Remove redundant "Filter was added" toast (elastic#155645) [RAM][Security Solution][Alerts] Support the ability to trigger a rule action per alert generated (elastic#153611) (elastic#155384) ...
Summary
Closes #154286
Checklist
Delete any items that are not applicable to this PR.
For maintainers