Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Infrastructure UI] Create InventoryViewsService and InventoryViewsClient #155126

Merged
merged 37 commits into from
Apr 26, 2023
Merged

[Infrastructure UI] Create InventoryViewsService and InventoryViewsClient #155126

merged 37 commits into from
Apr 26, 2023

Conversation

tonyghiani
Copy link
Contributor

📓 Summary

Depends on #154900
Closes #155110

This PR implements the InventoryViewsService and InventoryViewsClient, injecting an instance of the client in the KibanaContextForPlugin and exposing so a set of utilities to retrieve/update inventory views:

  • findInventoryViews
  • getInventoryView
  • createInventoryView
  • updateInventoryView
  • deleteInventoryView

👣 Next steps

Marco Antonio Ghiani and others added 18 commits April 11, 2023 11:19
feat(infra): wip on inventory views
3ec7402
refactor(infra): move saved objects into server
10e34e8
feat(infra): add inventory view to common types with versioning
a7c9330
feat(infra): wip endpoints
c3d9c8e
feat(infra): implement inventory view endpoints
bab4c46
@kibanamachine
[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…
6df39b1 
…-ref HEAD~1..HEAD --fix'
fix(infra): update saved object runtime type
a6d9262
feat(infra): add static view
70a6f5f
docs(infra): add doc about endpoints
e71d868
@tonyghiani
Merge branch 'main' into 152617-saved-views-http-endpoints
15b88a1
refactor(infra): restore legacy saved view files until client is refa…
d21947a 
…ctored
tests(infra): add inventoryViews test
85881d3
feat(infra): init metrics explorer view common
418b3b1
@tonyghiani
Merge branch 'main' into 152617-saved-views-http-endpoints
bfa86b9
@tonyghiani
Merge branch 'main' into 152617-saved-views-http-endpoints
6a18272
@tonyghiani
Merge branch 'main' into 152617-saved-views-http-endpoints
59e6e33
feat(infra): update type imports
1af7672
fix(infra): typo
426f924
@tonyghiani tonyghiani added Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes labels Apr 18, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@tonyghiani tonyghiani changed the title [Infrastructure UI] Add inventory views client [Infrastructure UI] Create InventoryViewsService and InventoryViewsClient Apr 18, 2023
@tonyghiani tonyghiani force-pushed the 155110-inventory-views-client branch from 72e06e6 to e593b8e Compare April 19, 2023 14:36
@tonyghiani tonyghiani force-pushed the 155110-inventory-views-client branch from b0d074f to e38bc2e Compare April 19, 2023 15:35
@tonyghiani tonyghiani force-pushed the 155110-inventory-views-client branch from e38bc2e to 9f13379 Compare April 24, 2023 09:51
@tonyghiani tonyghiani marked this pull request as ready for review April 24, 2023 09:56
@tonyghiani tonyghiani requested a review from a team as a code owner April 24, 2023 09:56
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

crespocarlos
crespocarlos approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@crespocarlos crespocarlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
infra 1357 1365 +8

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
infra 42 43 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 2.0MB 2.0MB -26.0KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
infra 10 11 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
infra 91.5KB 96.7KB +5.2KB
Unknown metric groups

API count

id before after diff
infra 45 46 +1

ESLint disabled in files

id before after diff
infra 8 9 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 17 19 +2
securitySolution 399 402 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 18 20 +2
infra 60 61 +1
securitySolution 479 482 +3
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tonyghiani tonyghiani merged commit 1351760 into elastic:main Apr 26, 2023
@tonyghiani tonyghiani deleted the 155110-inventory-views-client branch April 26, 2023 08:50
@kibanamachine kibanamachine added v8.8.0 backport:skip This commit does not require backporting labels Apr 26, 2023
jloleysens added a commit to jloleysens/kibana that referenced this pull request Apr 26, 2023
@jloleysens
Merge branch 'main' into compatible-schema-change-check
ab5ff42 
* main: (1294 commits)
  [SecuritySolution] Refactor security packages (elastic#155365)
  [Discover] Show "Temporary" badge for ad-hoc data views in Alerts flyout (elastic#155717)
  [RAM] Conditional actions feedback on pr review (elastic#155804)
  [Files] Adds bulk delete method (elastic#155628)
  [Lens] Use proper way to generate absolute short URL (elastic#155512)
  [Guided onboarding] Use Kibana features to grant access (elastic#155065)
  [Index Management] Fix duped mock (elastic#155844)
  [Lens] Enhance visualization modifier popup with layer palette (elastic#155280)
  Fix flaky combobox tests on role management screen (elastic#155711)
  [Infrastructure UI] Create InventoryViewsService and InventoryViewsClient (elastic#155126)
  [Fleet] always create agent upload write indices (elastic#155729)
  [Fleet] [Cloud Security Posture] Add CloudFormation agent install method (elastic#155045)
  Add tech preview label for search applications (elastic#155649)
  [ML] AIOps: Stabilize flaky functional tests. (elastic#155710)
  [ES UI Shared] Migrate JsonEditor to monaco (elastic#155610)
  [Security Solution] Fixes security_solution storybooks always rendering in a flyout (elastic#155814)
  [Synthetics] Make error popover disappear `onMouseLeave` of metric item card (elastic#155800)
  Remove Exploratory View components from Observability (elastic#155629)
  [Discover] Remove redundant "Filter was added" toast (elastic#155645)
  [RAM][Security Solution][Alerts] Support the ability to trigger a rule action per alert generated (elastic#153611) (elastic#155384)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crespocarlos crespocarlos crespocarlos approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Infrastructure UI] Create inventory views for client service
6 participants
@tonyghiani @apmmachine @elasticmachine @kibana-ci @crespocarlos @kibanamachine