Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Maintenance Window callout: Improve UI copy after tech writer review #157076

Merged
merged 2 commits into from
May 9, 2023
Merged

[Security Solution] Maintenance Window callout: Improve UI copy after tech writer review #157076

merged 2 commits into from
May 9, 2023

Conversation

nikitaindik
Copy link
Contributor

@nikitaindik nikitaindik commented May 8, 2023 •
edited by kibanamachine
Loading

Summary

Tweaked UI wording after consulting with a tech writer

Screenshot 2023-05-08 at 22 51 39

Addresses: #155099
Main PR: #155386

@nikitaindik nikitaindik added release_note:skip Skip the PR/issue when compiling release notes Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Feature:Rule Management Security Solution Detection Rule Management Team:Detection Rule Management Security Detection Rule Management Team v8.8.0 v8.9.0 labels May 8, 2023
@nikitaindik nikitaindik self-assigned this May 8, 2023
@nikitaindik nikitaindik marked this pull request as ready for review May 8, 2023 20:48
@nikitaindik nikitaindik requested a review from a team as a code owner May 8, 2023 20:48
@nikitaindik nikitaindik requested a review from maximpn May 8, 2023 20:48
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@nikitaindik nikitaindik enabled auto-merge (squash) May 8, 2023 20:50
@nikitaindik nikitaindik added the ui-copy Review of UI copy with docs team is recommended label May 8, 2023
@nikitaindik nikitaindik disabled auto-merge May 8, 2023 20:52
@nikitaindik nikitaindik enabled auto-merge (squash) May 8, 2023 20:52
@nikitaindik nikitaindik force-pushed the maintenance-window-callout-ui-copy-update branch from 770b7b7 to 4649f04 Compare May 9, 2023 07:12
@nikitaindik nikitaindik requested a review from a team as a code owner May 9, 2023 07:12
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Security Solution Tests #3 / timeline flyout button the (+) button popover menu owns focus

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 9.1MB 9.1MB -21.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 399 403 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 479 483 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nikitaindik

maximpn
maximpn approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@maximpn maximpn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nikitaindik nikitaindik merged commit 352c8d8 into elastic:main May 9, 2023
@kibanamachine kibanamachine mentioned this pull request May 9, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 9, 2023
@nikitaindik
[Security Solution] Maintenance Window callout: Improve UI copy after…
45a9996 
… tech writer review (elastic#157076)

## Summary

Tweaked UI wording after consulting with a tech writer

<img width="1329" alt="Screenshot 2023-05-08 at 22 51 39"
src="https://user-images.githubusercontent.com/15949146/236932465-43e6181e-c2dc-453a-b109-0ab22bbae695.png">

**Addresses:** elastic#155099
**Main PR:** elastic#155386

(cherry picked from commit 352c8d8)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 20, 2023
@kibanamachine @nikitaindik @banderror
[8.8] [Security Solution] Maintenance Window callout: Improve UI copy…
1f033b4 
… after tech writer review (#157076) (#157158)

# Backport

This will backport the following commits from `main` to `8.8`:
- [[Security Solution] Maintenance Window callout: Improve UI copy after
tech writer review
(#157076)](#157076)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nikita
Indik","email":"nikita.indik@elastic.co"},"sourceCommit":{"committedDate":"2023-05-09T12:34:29Z","message":"[Security
Solution] Maintenance Window callout: Improve UI copy after tech writer
review (#157076)\n\n## Summary\r\n\r\nTweaked UI wording after
consulting with a tech writer \r\n\r\n<img width=\"1329\"
alt=\"Screenshot 2023-05-08 at 22 51
39\"\r\nsrc=\"https://user-images.githubusercontent.com/15949146/236932465-43e6181e-c2dc-453a-b109-0ab22bbae695.png\">\r\n\r\n**Addresses:**
https://github.com/elastic/kibana/issues/155099\r\n**Main PR:**
https://github.com/elastic/kibana/pull/155386","sha":"352c8d8b1f7dbdadb8d2dbf1d5192e78a43a67af","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Detections
and Resp","Team: SecuritySolution","Feature:Rule
Management","Team:Detection
Rules","ui-copy","v8.8.0","v8.9.0"],"number":157076,"url":"https://github.com/elastic/kibana/pull/157076","mergeCommit":{"message":"[Security
Solution] Maintenance Window callout: Improve UI copy after tech writer
review (#157076)\n\n## Summary\r\n\r\nTweaked UI wording after
consulting with a tech writer \r\n\r\n<img width=\"1329\"
alt=\"Screenshot 2023-05-08 at 22 51
39\"\r\nsrc=\"https://user-images.githubusercontent.com/15949146/236932465-43e6181e-c2dc-453a-b109-0ab22bbae695.png\">\r\n\r\n**Addresses:**
https://github.com/elastic/kibana/issues/155099\r\n**Main PR:**
https://github.com/elastic/kibana/pull/155386","sha":"352c8d8b1f7dbdadb8d2dbf1d5192e78a43a67af"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/157076","number":157076,"mergeCommit":{"message":"[Security
Solution] Maintenance Window callout: Improve UI copy after tech writer
review (#157076)\n\n## Summary\r\n\r\nTweaked UI wording after
consulting with a tech writer \r\n\r\n<img width=\"1329\"
alt=\"Screenshot 2023-05-08 at 22 51
39\"\r\nsrc=\"https://user-images.githubusercontent.com/15949146/236932465-43e6181e-c2dc-453a-b109-0ab22bbae695.png\">\r\n\r\n**Addresses:**
https://github.com/elastic/kibana/issues/155099\r\n**Main PR:**
https://github.com/elastic/kibana/pull/155386","sha":"352c8d8b1f7dbdadb8d2dbf1d5192e78a43a67af"}}]}]
BACKPORT-->

Co-authored-by: Nikita Indik <nikita.indik@elastic.co>
Co-authored-by: Georgii Gorbachev <georgii.gorbachev@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximpn maximpn maximpn approved these changes

Assignees

@nikitaindik nikitaindik

Labels
Feature:Rule Management Security Solution Detection Rule Management release_note:skip Skip the PR/issue when compiling release notes Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. ui-copy Review of UI copy with docs team is recommended v8.8.0 v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nikitaindik @elasticmachine @kibana-ci @kibanamachine @maximpn