Custom path for data directory configuration is ignored #157659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ikuni17
added
Team:Operations
|
Pinging @elastic/kibana-operations (Team:Operations) |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Unknown metric groupsAPI count
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @Ikuni17 |
jbudz
approved these changes
May 15, 2023
jasonrhodes
pushed a commit
that referenced
this pull request
May 17, 2023
Fixes #142865 ## Summary The user can set a path for local data storage through CLI or `kibana.yml`, but this setting was not implemented and the default `data` directory was being used. There are a few instances of hard coded `data/xxx` paths in the codebase for babel, ci and testing which are not applicable to production. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Ikuni17
added a commit
to Ikuni17/kibana
that referenced
this pull request
May 18, 2023
Fixes elastic#142865 ## Summary The user can set a path for local data storage through CLI or `kibana.yml`, but this setting was not implemented and the default `data` directory was being used. There are a few instances of hard coded `data/xxx` paths in the codebase for babel, ci and testing which are not applicable to production. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 9aa186e) # Conflicts: # packages/kbn-utils/src/path/index.test.ts # packages/kbn-utils/src/path/index.ts # packages/kbn-utils/tsconfig.json
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Ikuni17
added a commit
to Ikuni17/kibana
that referenced
this pull request
May 23, 2023
…tic#157659)" This reverts commit 9aa186e.
Ikuni17
added a commit
that referenced
this pull request
May 23, 2023
delanni
pushed a commit
to delanni/kibana
that referenced
this pull request
May 25, 2023
…tic#157… (elastic#158325) Revert PR elastic#157659 due to blocking serverless image promotion.
|
Hi, I've noticed that the commits have been reverted, but I still value the 'path.data' feature. I was wondering if there are any plans to address this bug in the future? Thank you very much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #142865
Summary
The user can set a path for local data storage through CLI or
kibana.yml, but this setting was not implemented and the defaultdatadirectory was being used.There are a few instances of hard coded
data/xxxpaths in the codebase for babel, ci and testing which are not applicable to production.Checklist