Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Custom path for data directory configuration is ignored (#157… #158325

Merged
merged 1 commit into from
May 23, 2023
Merged

Revert "Custom path for data directory configuration is ignored (#157… #158325

merged 1 commit into from
May 23, 2023

Conversation

Ikuni17
Copy link
Contributor

@Ikuni17 Ikuni17 commented May 23, 2023

Revert PR #157659 due to blocking serverless image promotion.

@Ikuni17 Ikuni17 requested a review from jbudz May 23, 2023 20:21
@Ikuni17 Ikuni17 self-assigned this May 23, 2023
@Ikuni17 Ikuni17 requested a review from a team as a code owner May 23, 2023 20:21
@Ikuni17 Ikuni17 added the release_note:skip Skip the PR/issue when compiling release notes label May 23, 2023
@Ikuni17 Ikuni17 enabled auto-merge (squash) May 23, 2023 20:47
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/utils 15 14 -1
Unknown metric groups

API count

id before after diff
@kbn/utils 25 24 -1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 399 403 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 479 483 +4
total +6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Ikuni17

@Ikuni17 Ikuni17 merged commit 59c2ff5 into elastic:main May 23, 2023
@kibanamachine kibanamachine added v8.9.0 backport:skip This commit does not require backporting labels May 23, 2023
@Ikuni17 Ikuni17 deleted the revert/pr-157659 branch May 23, 2023 22:18
@Ikuni17 Ikuni17 mentioned this pull request May 24, 2023
Merged
delanni pushed a commit to delanni/kibana that referenced this pull request May 25, 2023
@Ikuni17 @delanni
Revert "Custom path for data directory configuration is ignored (elas…
f59377f 
…tic#157… (elastic#158325)

Revert PR elastic#157659 due to blocking serverless image promotion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbudz jbudz jbudz approved these changes

Assignees

@Ikuni17 Ikuni17

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ikuni17 @kibana-ci @jbudz @kibanamachine