[Logs onboarding] Refactors the install elastic agent steps to own component #162600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
ogupte
added
the
release_note:skip
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
ThomThomson
pushed a commit
to ThomThomson/kibana
that referenced
this pull request
Aug 1, 2023
yngrdyn
added a commit
that referenced
this pull request
Aug 4, 2023
…62972) Closes #154929. This PR along with #162654, #162706 and #162600 completes the work required for collect system logs. ### Changes - `ObservabilityOnboardingType` now could be `logFiles | systemLogs`. This help us to identify (without changing the script) whether we need to retrieve the yaml configuration for customLogs or for systemLogs. - Added `generateSystemLogsYml` which generates a specific configuration for system logs. - `get_has_logs.ts` was modified so we are querying the proper index depending on the type of logs. #### Demo https://github.com/elastic/kibana/assets/1313018/47eca890-37b2-401e-9e41-67c978ab50ad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required pre-work to implement the the system logs flow: #154929. Both flows will be using the same install steps.