-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Logs onboarding] Generate elastic-agent.yml file for system logs #162972
[Logs onboarding] Generate elastic-agent.yml file for system logs #162972
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
/oblt-deploy |
1 similar comment
/oblt-deploy |
84908dc
to
b4d0e91
Compare
b4d0e91
to
c63e8d3
Compare
58d1f92
to
6090745
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, a few questions.
dataset, | ||
namespace, | ||
type, | ||
state: savedObservabilityOnboardingState.state, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you think we need to pass in the type
separately since it is already in the saved object?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer to pass the type
explicitly
@@ -40,7 +40,7 @@ export function InstallElasticAgent() { | |||
const [elasticAgentPlatform, setElasticAgentPlatform] = | |||
useState<ElasticAgentPlatform>('linux-tar'); | |||
|
|||
const datasetName = 'elastic-agent'; | |||
const datasetName = 'system-logs'; | |||
const namespace = 'default'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless we have UI to configure datasetName
and namespace
maybe these values can be hardcoded in the route as the saved object is created. what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
datasetName
in this case is used for name
required property in the route, this is the name that we use to create the apiKey. SystemLogsState
is only composed by namespace. I can move the namespace to the server.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/oblt-deploy |
/oblt-deploy |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Closes #154929.
This PR along with #162654, #162706 and #162600 completes the work required for collect system logs.
Changes
ObservabilityOnboardingType
now could belogFiles | systemLogs
. This help us to identify (without changing the script) whether we need to retrieve the yaml configuration for customLogs or for systemLogs.generateSystemLogsYml
which generates a specific configuration for system logs.get_has_logs.ts
was modified so we are querying the proper index depending on the type of logs.Demo
Screen.Recording.2023-08-02.at.17.58.58.mov