Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Index details page] Implement mappings tab #165038

Merged
merged 8 commits into from
Aug 29, 2023
Merged

[Index details page] Implement mappings tab #165038

merged 8 commits into from
Aug 29, 2023

Conversation

yuliacech
Copy link
Contributor

@yuliacech yuliacech commented Aug 28, 2023 •
edited
Loading

Summary

Fixes #164572

This PR implements the mappings displayed in the Mappings tab of the index details page. The mappings are loaded from the existing route api/index_management/mapping/:indexName. There is a loading indicator and an error prompt for the API request. There is a link to the mappings docs on the right side of the tab. We need to add an Ent Search specific docs link to the right side of the tab which will be addressed as a separate PR (issue). Also any potential performance issues with displaying the mappings object in the code block will be addressed in a separate PR (issue).

Screenshots

Small mappings object

Screenshot 2023-08-29 at 15 54 33

Large mappings object

Screenshot 2023-08-29 at 15 54 20

Loading

Screenshot 2023-08-29 at 17 07 17

Error loading mappings

Screenshot 2023-08-29 at 17 07 44

Checklist

This was referenced Aug 29, 2023
Closed
Closed
@yuliacech yuliacech marked this pull request as ready for review August 29, 2023 15:09
@yuliacech yuliacech requested a review from a team as a code owner August 29, 2023 15:09
@yuliacech yuliacech added Feature:Index Management Index and index templates UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes labels Aug 29, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

alisonelizabeth
alisonelizabeth approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work 🎉 LGTM.

...anagement/public/application/sections/home/index_list/details_page/details_page_mappings.tsx Outdated
</EuiFlexItem>
<EuiFlexItem>
<EuiText>
<b>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used EuiTitle for this in my stats PR. Do you think that's better for a11y purposes? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, thanks! I'll use the same

@yuliacech
Copy link
Contributor Author

Thanks a lot for reviewing, @alisonelizabeth!

@yuliacech yuliacech enabled auto-merge (squash) August 29, 2023 16:46
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
indexManagement 497 498 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
indexManagement 526.9KB 529.7KB +2.8KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@yuliacech yuliacech merged commit 5ee3cd1 into elastic:main Aug 29, 2023
23 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Aug 29, 2023
bryce-b pushed a commit to bryce-b/kibana that referenced this pull request Sep 19, 2023
@yuliacech @kibanamachine @bryce-b
[Index details page] Implement mappings tab (elastic#165038)
b7378aa 
## Summary
Addresses elastic#164572

This PR implements the mappings displayed in the Mappings tab of the
index details page. The mappings are loaded from the existing route
`api/index_management/mapping/:indexName`. There is a loading indicator
and an error prompt for the API request. There is a link to the mappings
docs on the right side of the tab. We need to add an Ent Search specific
docs link to the right side of the tab which will be addressed as a
separate PR ([issue](elastic#165107)).
Also any potential performance issues with displaying the mappings
object in the code block will be addressed in a separate PR
([issue](elastic#165112)).

### Screenshots
#### Small mappings object
<img width="1590" alt="Screenshot 2023-08-29 at 15 54 33"
src="https://github.com/elastic/kibana/assets/6585477/1b2b950c-446c-4534-8606-94df548ef2ab">

#### Large mappings object 
<img width="1576" alt="Screenshot 2023-08-29 at 15 54 20"
src="https://github.com/elastic/kibana/assets/6585477/35933fec-eb8d-439c-9cec-e03a3b7dd938">

#### Loading 
<img width="1336" alt="Screenshot 2023-08-29 at 17 07 17"
src="https://github.com/elastic/kibana/assets/6585477/4e723b72-2437-45c3-8e0e-54028bd3944b">

#### Error loading mappings
<img width="1337" alt="Screenshot 2023-08-29 at 17 07 44"
src="https://github.com/elastic/kibana/assets/6585477/2f611081-f11f-41b1-b66e-3086927b1bf0">


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@yuliacech yuliacech mentioned this pull request Sep 22, 2023
Merged
Ikuni17 pushed a commit that referenced this pull request Sep 27, 2023
@yuliacech @kibanamachine
[Index Management] Implement index details page (#165705)
e1b37a6 
## Summary
This PR removes the feature flag and enables the new index details page
by default. The index details page was implemented in following PRs:
- #163521
- #163955
- #164741
- #165027
- #165038
- #165456

In this PR we completely remove now obsolete code for the old index
details flyout: react components and corresponding redux code. All
related tests are updated and cleaned up. The config value for Index
Management plugin `xpack.index_management.dev.enableIndexDetailsPage` is
deprecated as unused and can be removed in v9.0.


### How to test
1. Start ES and Kibana with `yarn es snapshot` and `yarn start`
3. Navigate to Index Management and create an index
4. Click the index name in the table and check the tabs of the details
page
### Screenshots
#### Stateful
Overview 
<img width="1387" alt="Screenshot 2023-09-27 at 14 41 57"
src="https://github.com/elastic/kibana/assets/6585477/e58b15e7-d10c-4473-873c-d0f128392404">


Mappings
<img width="1392" alt="Screenshot 2023-09-27 at 14 42 05"
src="https://github.com/elastic/kibana/assets/6585477/441157cb-5a26-47c3-8da0-b4df51ebec5d">


Settings 
<img width="1385" alt="Screenshot 2023-09-27 at 14 42 13"
src="https://github.com/elastic/kibana/assets/6585477/da66a2eb-1f21-44c1-9356-484c66caab88">


Statistics
<img width="1380" alt="Screenshot 2023-09-27 at 14 42 22"
src="https://github.com/elastic/kibana/assets/6585477/ec93d85c-e754-4c21-88ab-0124dc114fc9">


Error loading data
<img width="1333" alt="Screenshot 2023-09-26 at 19 05 37"
src="https://github.com/elastic/kibana/assets/6585477/fc1804b3-6aa0-4019-bae6-e7bb40113b28">
<img width="1327" alt="Screenshot 2023-09-26 at 19 06 07"
src="https://github.com/elastic/kibana/assets/6585477/ca711697-cc74-4ba8-b17c-ec9b01f3026e">
<img width="1329" alt="Screenshot 2023-09-26 at 19 06 28"
src="https://github.com/elastic/kibana/assets/6585477/0cb46b09-8542-452a-8845-40d060057e95">
<img width="1331" alt="Screenshot 2023-09-26 at 19 06 48"
src="https://github.com/elastic/kibana/assets/6585477/87de8d3d-b6e5-4e8f-b27c-18a1c6e950d8">


Error saving index settings
<img width="1332" alt="Screenshot 2023-09-26 at 19 07 31"
src="https://github.com/elastic/kibana/assets/6585477/e6e4b3d0-c237-4d0a-995a-4562bc78f88e">


### Serverless
Overview 
<img width="1336" alt="Screenshot 2023-09-26 at 19 51 47"
src="https://github.com/elastic/kibana/assets/6585477/6c76c23b-4be6-4ab3-ae1d-c7ae751e100d">


Mappings
<img width="1336" alt="Screenshot 2023-09-26 at 19 23 51"
src="https://github.com/elastic/kibana/assets/6585477/625fa703-506f-4389-9df0-86441a655074">


Settings
<img width="1332" alt="Screenshot 2023-09-26 at 19 24 02"
src="https://github.com/elastic/kibana/assets/6585477/c496ab09-f2db-4c1b-9fb6-1e9b64b1c142">


# Release note
Index details can now be viewed on a new index details page in Index
Management.
<img width="1387" alt="Screenshot 2023-09-27 at 14 41 57"
src="https://github.com/elastic/kibana/assets/6585477/b90c706d-8b15-49e4-8f6a-cb66f3ed1822">

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@yuliacech yuliacech deleted the im/details_page/mappings_tab branch February 15, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alisonelizabeth alisonelizabeth alisonelizabeth approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Index Management Index and index templates UI release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Index details page] Implement the "mappings" tab
5 participants
@yuliacech @elasticmachine @kibana-ci @alisonelizabeth @kibanamachine