Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Index Management] Implement index details page #165705

Merged
merged 29 commits into from
Sep 27, 2023

Conversation

yuliacech
Copy link
Contributor

@yuliacech yuliacech commented Sep 5, 2023

Summary

This PR removes the feature flag and enables the new index details page by default. The index details page was implemented in following PRs:

In this PR we completely remove now obsolete code for the old index details flyout: react components and corresponding redux code. All related tests are updated and cleaned up. The config value for Index Management plugin xpack.index_management.dev.enableIndexDetailsPage is deprecated as unused and can be removed in v9.0.

How to test

  1. Start ES and Kibana with yarn es snapshot and yarn start
  2. Navigate to Index Management and create an index
  3. Click the index name in the table and check the tabs of the details page

Screenshots

Stateful

Overview
Screenshot 2023-09-27 at 14 41 57

Mappings
Screenshot 2023-09-27 at 14 42 05

Settings
Screenshot 2023-09-27 at 14 42 13

Statistics
Screenshot 2023-09-27 at 14 42 22

Error loading data
Screenshot 2023-09-26 at 19 05 37
Screenshot 2023-09-26 at 19 06 07
Screenshot 2023-09-26 at 19 06 28
Screenshot 2023-09-26 at 19 06 48

Error saving index settings
Screenshot 2023-09-26 at 19 07 31

Serverless

Overview
Screenshot 2023-09-26 at 19 51 47

Mappings
Screenshot 2023-09-26 at 19 23 51

Settings
Screenshot 2023-09-26 at 19 24 02

Release note

Index details can now be viewed on a new index details page in Index Management.
Screenshot 2023-09-27 at 14 41 57

@mdefazio
Copy link
Contributor

mdefazio commented Sep 7, 2023

Adding this comment here so as to not clutter the other PR.

(Referencing the bulk action menu)

I'm not sure it makes sense to keep those "show" actions with the new page for index details

It might be worthwhile to keep these. Currently these are one-click into the flyout tab depending on the choice—perhaps worth considering maintaining that expectation of the user if they are looking for a specific action. (With the added value that these are now a dedicated view). As opposed to them not finding an action they were used to selecting.

@yuliacech yuliacech added release_note:feature Makes this part of the condensed release notes and removed release_note:fix labels Sep 8, 2023
yuliacech added a commit that referenced this pull request Sep 21, 2023
## Summary
Fixes #165844
Partially addresses #122577 

This PR fixes the inconsistency with breadcrumbs in Index Management.
Previously, the breadcrumbs were updated only when an index template or
a component template was being created/edited. This PR adds breadcrumbs
for each of 4 main tabs: indices, data streams, index templates,
component templates. It also adds breadcrumbs for the new index details
page.

**Note for reviewers:** Tabs "Documents" and "Pipelines" on the new
index details page will not be implemented for now, so there are no
breadcrumbs for them.

**Note for copy review**: This PR can be reviewed only in terms on
breadcrumbs in Index Management. The copy review for the new index
details page can be done in this
[PR](#165705).

### Screenshots 

#### Indices list
Breadcrumbs "Indices"

<img width="1318" alt="Screenshot 2023-09-07 at 17 22 56"
src="https://github.com/elastic/kibana/assets/6585477/1a670df6-b0b2-4272-b7ec-e50719884ad8">

#### Index details - overview tab
Breadcrumbs "Indices" (link) => "Index details" -> "Overview"
<img width="1130" alt="Screenshot 2023-09-08 at 17 20 45"
src="https://github.com/elastic/kibana/assets/6585477/87b75a2c-d3e2-454d-8ad5-979feb3dc8a5">


#### Index details - mappings tab
Breadcrumbs "Indices"(link) -> "Index details" -> "Mappings"
<img width="1319" alt="Screenshot 2023-09-07 at 17 23 53"
src="https://github.com/elastic/kibana/assets/6585477/d42baf78-9133-4c87-bdbd-1aedad119e62">

#### Index details - settings tab
Breadcrumbs "Indices"(link) -> "Index details" -> "Settings"
<img width="1305" alt="Screenshot 2023-09-07 at 17 24 00"
src="https://github.com/elastic/kibana/assets/6585477/bf94497c-4ca3-413c-be57-37499c0839ba">

#### Index details - stats tab
Breadcrumbs "Indices"(link) -> "Index details" -> "Stats"
<img width="1300" alt="Screenshot 2023-09-07 at 17 24 12"
src="https://github.com/elastic/kibana/assets/6585477/c1798ac2-7169-4bfe-8732-ed3f8e6d812e">

#### Data streams
Breadcrumbs "Data streams"
<img width="1319" alt="Screenshot 2023-09-07 at 17 23 03"
src="https://github.com/elastic/kibana/assets/6585477/f4d0230e-994f-4537-a43d-065d364ffc7c">

#### Index templates
Breadcrumbs "Templates" 
<img width="1319" alt="Screenshot 2023-09-07 at 17 23 10"
src="https://github.com/elastic/kibana/assets/6585477/610c609c-1213-4388-9c73-68711c2c4bb6">

#### Component templates
Breadcrumbs "Component templates" 
<img width="1303" alt="Screenshot 2023-09-07 at 17 23 28"
src="https://github.com/elastic/kibana/assets/6585477/4f90eadb-a409-4e53-84f0-92b5f40b7639">



### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@yuliacech yuliacech force-pushed the im/details_page/remove_feature_flag branch from ed4e52d to 71c0e55 Compare September 22, 2023 15:11
yuliacech added a commit that referenced this pull request Sep 22, 2023
## Summary
Fixes #166100

This PR adds a workaround fix for the new index details page when
opening for index names with special characters, for example
`test_index%`. Because of how encoding/decoding works, we can't use the
index name as a part of the url like `/indices/${indexName}` (see for
more details). Instead we have to pass the index name in a query
parameter like `/indices/index_details?indexName=${indexName}. The
downside of this workaround is that the url semantics doesn't reflect
that the index name is mandatory for the page to work. Once
#132600 is resolved, we should
revert this workaround and use the index name as a url segment again.

Note for reviewers: The jest tests for this fix are part of
#165705

### How to test
1. Add `xpack.index_management.dev.enableIndexDetailsPage: true` to the
file `config/kibana.dev.yml` to enable the new index details page
2. Navigate to Index Management and use the "create index" button 
3. Type a name with special characters, for example `test%`
4. Click the new index name in the list and check that the details page
and all tabs work
5. Also reload the page completely and check that the page still loads
correctly

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Alison Goryachev <alisonmllr20@gmail.com>
@yuliacech yuliacech force-pushed the im/details_page/remove_feature_flag branch from 71c0e55 to b7e996d Compare September 22, 2023 15:28
@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 27, 2023

💔 Build Failed

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
indexManagement 606 586 -20

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
indexManagement 601.5KB 553.0KB -48.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
indexManagement 33.6KB 33.1KB -520.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Ikuni17 Ikuni17 merged commit e1b37a6 into elastic:main Sep 27, 2023
17 of 19 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Sep 27, 2023
yuliacech added a commit that referenced this pull request Oct 18, 2023
## Summary

This PR removes some leftover code from deleting the index details
flyout in #165705
benakansara pushed a commit to benakansara/kibana that referenced this pull request Oct 22, 2023
## Summary

This PR removes some leftover code from deleting the index details
flyout in elastic#165705
benakansara pushed a commit to benakansara/kibana that referenced this pull request Oct 22, 2023
## Summary

This PR removes some leftover code from deleting the index details
flyout in elastic#165705
github-merge-queue bot pushed a commit that referenced this pull request Nov 7, 2023
## Summary
Fixes #170335

This PR adds index name badges to the index details page. The badges
used to be rendered in the index details flyout but were not
re-implemented for the new details page in
#165705.
Currently, there are only 3 possible badges: "frozen", "rollup" and
"follower".

### Screenshots
#### Short index name
<img width="1486" alt="Screenshot 2023-11-03 at 17 53 18"
src="https://github.com/elastic/kibana/assets/6585477/92bc5ae0-b4ef-4710-a9c2-8dd505b0febf">

#### Long index name


https://github.com/elastic/kibana/assets/6585477/1b89381b-5b9a-4a59-9473-e5887a473250






### Checklist

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)


### Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to
identify risks that should be tested prior to the change/feature
release.

When forming the risk matrix, consider some of the following examples
and how they may potentially impact the change:

| Risk | Probability | Severity | Mitigation/Notes |

|---------------------------|-------------|----------|-------------------------|
| Multiple Spaces&mdash;unexpected behavior in non-default Kibana Space.
| Low | High | Integration tests will verify that all features are still
supported in non-default Kibana Space and when user switches between
spaces. |
| Multiple nodes&mdash;Elasticsearch polling might have race conditions
when multiple Kibana nodes are polling for the same tasks. | High | Low
| Tasks are idempotent, so executing them multiple times will not result
in logical error, but will degrade performance. To test for this case we
add plenty of unit tests around this logic and document manual testing
procedure. |
| Code should gracefully handle cases when feature X or plugin Y are
disabled. | Medium | High | Unit tests will verify that any feature flag
or plugin combination still results in our service operational. |
| [See more potential risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Ruhshan pushed a commit to Ruhshan/kibana that referenced this pull request Nov 7, 2023
…#170558)

## Summary
Fixes elastic#170335

This PR adds index name badges to the index details page. The badges
used to be rendered in the index details flyout but were not
re-implemented for the new details page in
elastic#165705.
Currently, there are only 3 possible badges: "frozen", "rollup" and
"follower".

### Screenshots
#### Short index name
<img width="1486" alt="Screenshot 2023-11-03 at 17 53 18"
src="https://github.com/elastic/kibana/assets/6585477/92bc5ae0-b4ef-4710-a9c2-8dd505b0febf">

#### Long index name


https://github.com/elastic/kibana/assets/6585477/1b89381b-5b9a-4a59-9473-e5887a473250






### Checklist

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)


### Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to
identify risks that should be tested prior to the change/feature
release.

When forming the risk matrix, consider some of the following examples
and how they may potentially impact the change:

| Risk | Probability | Severity | Mitigation/Notes |

|---------------------------|-------------|----------|-------------------------|
| Multiple Spaces&mdash;unexpected behavior in non-default Kibana Space.
| Low | High | Integration tests will verify that all features are still
supported in non-default Kibana Space and when user switches between
spaces. |
| Multiple nodes&mdash;Elasticsearch polling might have race conditions
when multiple Kibana nodes are polling for the same tasks. | High | Low
| Tasks are idempotent, so executing them multiple times will not result
in logical error, but will degrade performance. To test for this case we
add plenty of unit tests around this logic and document manual testing
procedure. |
| Code should gracefully handle cases when feature X or plugin Y are
disabled. | Medium | High | Unit tests will verify that any feature flag
or plugin combination still results in our service operational. |
| [See more potential risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
yuliacech added a commit that referenced this pull request Jan 30, 2024
…9303)

## Summary
Fixes #169016
This PR puts back the functionality that existed prior to 8.11 when the
new index page was
[introduced](#165705) (see any
8.10 or earlier deployments to see how the settings editor worked). The
autocomplete is only showing the settings that are displayed in the
editor after the edit mode has been enabled. There is no autocomplete
suggestions for all settings that can be changed. There is an
[issue](#175714) to track work
to improve the overall UX in the index settings editor.

### Screenshots 

<img width="1214" alt="Screenshot 2024-01-29 at 10 30 17"
src="https://github.com/elastic/kibana/assets/6585477/9e42993c-a735-4856-8f70-e65ad112c36e">


#### 8.10 and earlier versions

<img width="723" alt="Screenshot 2024-01-29 at 10 28 49"
src="https://github.com/elastic/kibana/assets/6585477/47b59668-f338-4212-88bd-f682df1e0d2a">



Summarize your PR. If it involves visual changes include a screenshot or
gif.


### Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)


### Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to
identify risks that should be tested prior to the change/feature
release.

When forming the risk matrix, consider some of the following examples
and how they may potentially impact the change:

| Risk | Probability | Severity | Mitigation/Notes |

|---------------------------|-------------|----------|-------------------------|
| Multiple Spaces&mdash;unexpected behavior in non-default Kibana Space.
| Low | High | Integration tests will verify that all features are still
supported in non-default Kibana Space and when user switches between
spaces. |
| Multiple nodes&mdash;Elasticsearch polling might have race conditions
when multiple Kibana nodes are polling for the same tasks. | High | Low
| Tasks are idempotent, so executing them multiple times will not result
in logical error, but will degrade performance. To test for this case we
add plenty of unit tests around this logic and document manual testing
procedure. |
| Code should gracefully handle cases when feature X or plugin Y are
disabled. | Medium | High | Unit tests will verify that any feature flag
or plugin combination still results in our service operational. |
| [See more potential risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
nreese pushed a commit to nreese/kibana that referenced this pull request Jan 31, 2024
…stic#169303)

## Summary
Fixes elastic#169016
This PR puts back the functionality that existed prior to 8.11 when the
new index page was
[introduced](elastic#165705) (see any
8.10 or earlier deployments to see how the settings editor worked). The
autocomplete is only showing the settings that are displayed in the
editor after the edit mode has been enabled. There is no autocomplete
suggestions for all settings that can be changed. There is an
[issue](elastic#175714) to track work
to improve the overall UX in the index settings editor.

### Screenshots 

<img width="1214" alt="Screenshot 2024-01-29 at 10 30 17"
src="https://github.com/elastic/kibana/assets/6585477/9e42993c-a735-4856-8f70-e65ad112c36e">


#### 8.10 and earlier versions

<img width="723" alt="Screenshot 2024-01-29 at 10 28 49"
src="https://github.com/elastic/kibana/assets/6585477/47b59668-f338-4212-88bd-f682df1e0d2a">



Summarize your PR. If it involves visual changes include a screenshot or
gif.


### Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)


### Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to
identify risks that should be tested prior to the change/feature
release.

When forming the risk matrix, consider some of the following examples
and how they may potentially impact the change:

| Risk | Probability | Severity | Mitigation/Notes |

|---------------------------|-------------|----------|-------------------------|
| Multiple Spaces&mdash;unexpected behavior in non-default Kibana Space.
| Low | High | Integration tests will verify that all features are still
supported in non-default Kibana Space and when user switches between
spaces. |
| Multiple nodes&mdash;Elasticsearch polling might have race conditions
when multiple Kibana nodes are polling for the same tasks. | High | Low
| Tasks are idempotent, so executing them multiple times will not result
in logical error, but will degrade performance. To test for this case we
add plenty of unit tests around this logic and document manual testing
procedure. |
| Code should gracefully handle cases when feature X or plugin Y are
disabled. | Medium | High | Unit tests will verify that any feature flag
or plugin combination still results in our service operational. |
| [See more potential risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Feb 5, 2024
…stic#169303)

## Summary
Fixes elastic#169016
This PR puts back the functionality that existed prior to 8.11 when the
new index page was
[introduced](elastic#165705) (see any
8.10 or earlier deployments to see how the settings editor worked). The
autocomplete is only showing the settings that are displayed in the
editor after the edit mode has been enabled. There is no autocomplete
suggestions for all settings that can be changed. There is an
[issue](elastic#175714) to track work
to improve the overall UX in the index settings editor.

### Screenshots 

<img width="1214" alt="Screenshot 2024-01-29 at 10 30 17"
src="https://github.com/elastic/kibana/assets/6585477/9e42993c-a735-4856-8f70-e65ad112c36e">


#### 8.10 and earlier versions

<img width="723" alt="Screenshot 2024-01-29 at 10 28 49"
src="https://github.com/elastic/kibana/assets/6585477/47b59668-f338-4212-88bd-f682df1e0d2a">



Summarize your PR. If it involves visual changes include a screenshot or
gif.


### Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)


### Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to
identify risks that should be tested prior to the change/feature
release.

When forming the risk matrix, consider some of the following examples
and how they may potentially impact the change:

| Risk | Probability | Severity | Mitigation/Notes |

|---------------------------|-------------|----------|-------------------------|
| Multiple Spaces&mdash;unexpected behavior in non-default Kibana Space.
| Low | High | Integration tests will verify that all features are still
supported in non-default Kibana Space and when user switches between
spaces. |
| Multiple nodes&mdash;Elasticsearch polling might have race conditions
when multiple Kibana nodes are polling for the same tasks. | High | Low
| Tasks are idempotent, so executing them multiple times will not result
in logical error, but will degrade performance. To test for this case we
add plenty of unit tests around this logic and document manual testing
procedure. |
| Code should gracefully handle cases when feature X or plugin Y are
disabled. | Medium | High | Unit tests will verify that any feature flag
or plugin combination still results in our service operational. |
| [See more potential risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Feb 6, 2024
…stic#169303)

## Summary
Fixes elastic#169016
This PR puts back the functionality that existed prior to 8.11 when the
new index page was
[introduced](elastic#165705) (see any
8.10 or earlier deployments to see how the settings editor worked). The
autocomplete is only showing the settings that are displayed in the
editor after the edit mode has been enabled. There is no autocomplete
suggestions for all settings that can be changed. There is an
[issue](elastic#175714) to track work
to improve the overall UX in the index settings editor.

### Screenshots 

<img width="1214" alt="Screenshot 2024-01-29 at 10 30 17"
src="https://github.com/elastic/kibana/assets/6585477/9e42993c-a735-4856-8f70-e65ad112c36e">


#### 8.10 and earlier versions

<img width="723" alt="Screenshot 2024-01-29 at 10 28 49"
src="https://github.com/elastic/kibana/assets/6585477/47b59668-f338-4212-88bd-f682df1e0d2a">



Summarize your PR. If it involves visual changes include a screenshot or
gif.


### Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)


### Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to
identify risks that should be tested prior to the change/feature
release.

When forming the risk matrix, consider some of the following examples
and how they may potentially impact the change:

| Risk | Probability | Severity | Mitigation/Notes |

|---------------------------|-------------|----------|-------------------------|
| Multiple Spaces&mdash;unexpected behavior in non-default Kibana Space.
| Low | High | Integration tests will verify that all features are still
supported in non-default Kibana Space and when user switches between
spaces. |
| Multiple nodes&mdash;Elasticsearch polling might have race conditions
when multiple Kibana nodes are polling for the same tasks. | High | Low
| Tasks are idempotent, so executing them multiple times will not result
in logical error, but will degrade performance. To test for this case we
add plenty of unit tests around this logic and document manual testing
procedure. |
| Code should gracefully handle cases when feature X or plugin Y are
disabled. | Medium | High | Unit tests will verify that any feature flag
or plugin combination still results in our service operational. |
| [See more potential risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@yuliacech yuliacech deleted the im/details_page/remove_feature_flag branch February 15, 2024 12:05
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
…stic#169303)

## Summary
Fixes elastic#169016
This PR puts back the functionality that existed prior to 8.11 when the
new index page was
[introduced](elastic#165705) (see any
8.10 or earlier deployments to see how the settings editor worked). The
autocomplete is only showing the settings that are displayed in the
editor after the edit mode has been enabled. There is no autocomplete
suggestions for all settings that can be changed. There is an
[issue](elastic#175714) to track work
to improve the overall UX in the index settings editor.

### Screenshots 

<img width="1214" alt="Screenshot 2024-01-29 at 10 30 17"
src="https://github.com/elastic/kibana/assets/6585477/9e42993c-a735-4856-8f70-e65ad112c36e">


#### 8.10 and earlier versions

<img width="723" alt="Screenshot 2024-01-29 at 10 28 49"
src="https://github.com/elastic/kibana/assets/6585477/47b59668-f338-4212-88bd-f682df1e0d2a">



Summarize your PR. If it involves visual changes include a screenshot or
gif.


### Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)


### Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to
identify risks that should be tested prior to the change/feature
release.

When forming the risk matrix, consider some of the following examples
and how they may potentially impact the change:

| Risk | Probability | Severity | Mitigation/Notes |

|---------------------------|-------------|----------|-------------------------|
| Multiple Spaces&mdash;unexpected behavior in non-default Kibana Space.
| Low | High | Integration tests will verify that all features are still
supported in non-default Kibana Space and when user switches between
spaces. |
| Multiple nodes&mdash;Elasticsearch polling might have race conditions
when multiple Kibana nodes are polling for the same tasks. | High | Low
| Tasks are idempotent, so executing them multiple times will not result
in logical error, but will degrade performance. To test for this case we
add plenty of unit tests around this logic and document manual testing
procedure. |
| Code should gracefully handle cases when feature X or plugin Y are
disabled. | Medium | High | Unit tests will verify that any feature flag
or plugin combination still results in our service operational. |
| [See more potential risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
…stic#169303)

## Summary
Fixes elastic#169016
This PR puts back the functionality that existed prior to 8.11 when the
new index page was
[introduced](elastic#165705) (see any
8.10 or earlier deployments to see how the settings editor worked). The
autocomplete is only showing the settings that are displayed in the
editor after the edit mode has been enabled. There is no autocomplete
suggestions for all settings that can be changed. There is an
[issue](elastic#175714) to track work
to improve the overall UX in the index settings editor.

### Screenshots 

<img width="1214" alt="Screenshot 2024-01-29 at 10 30 17"
src="https://github.com/elastic/kibana/assets/6585477/9e42993c-a735-4856-8f70-e65ad112c36e">


#### 8.10 and earlier versions

<img width="723" alt="Screenshot 2024-01-29 at 10 28 49"
src="https://github.com/elastic/kibana/assets/6585477/47b59668-f338-4212-88bd-f682df1e0d2a">



Summarize your PR. If it involves visual changes include a screenshot or
gif.


### Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)


### Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to
identify risks that should be tested prior to the change/feature
release.

When forming the risk matrix, consider some of the following examples
and how they may potentially impact the change:

| Risk | Probability | Severity | Mitigation/Notes |

|---------------------------|-------------|----------|-------------------------|
| Multiple Spaces&mdash;unexpected behavior in non-default Kibana Space.
| Low | High | Integration tests will verify that all features are still
supported in non-default Kibana Space and when user switches between
spaces. |
| Multiple nodes&mdash;Elasticsearch polling might have race conditions
when multiple Kibana nodes are polling for the same tasks. | High | Low
| Tasks are idempotent, so executing them multiple times will not result
in logical error, but will degrade performance. To test for this case we
add plenty of unit tests around this logic and document manual testing
procedure. |
| Code should gracefully handle cases when feature X or plugin Y are
disabled. | Medium | High | Unit tests will verify that any feature flag
or plugin combination still results in our service operational. |
| [See more potential risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
fkanout pushed a commit to fkanout/kibana that referenced this pull request Mar 4, 2024
…stic#169303)

## Summary
Fixes elastic#169016
This PR puts back the functionality that existed prior to 8.11 when the
new index page was
[introduced](elastic#165705) (see any
8.10 or earlier deployments to see how the settings editor worked). The
autocomplete is only showing the settings that are displayed in the
editor after the edit mode has been enabled. There is no autocomplete
suggestions for all settings that can be changed. There is an
[issue](elastic#175714) to track work
to improve the overall UX in the index settings editor.

### Screenshots 

<img width="1214" alt="Screenshot 2024-01-29 at 10 30 17"
src="https://github.com/elastic/kibana/assets/6585477/9e42993c-a735-4856-8f70-e65ad112c36e">


#### 8.10 and earlier versions

<img width="723" alt="Screenshot 2024-01-29 at 10 28 49"
src="https://github.com/elastic/kibana/assets/6585477/47b59668-f338-4212-88bd-f682df1e0d2a">



Summarize your PR. If it involves visual changes include a screenshot or
gif.


### Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)


### Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to
identify risks that should be tested prior to the change/feature
release.

When forming the risk matrix, consider some of the following examples
and how they may potentially impact the change:

| Risk | Probability | Severity | Mitigation/Notes |

|---------------------------|-------------|----------|-------------------------|
| Multiple Spaces&mdash;unexpected behavior in non-default Kibana Space.
| Low | High | Integration tests will verify that all features are still
supported in non-default Kibana Space and when user switches between
spaces. |
| Multiple nodes&mdash;Elasticsearch polling might have race conditions
when multiple Kibana nodes are polling for the same tasks. | High | Low
| Tasks are idempotent, so executing them multiple times will not result
in logical error, but will degrade performance. To test for this case we
add plenty of unit tests around this logic and document manual testing
procedure. |
| Code should gracefully handle cases when feature X or plugin Y are
disabled. | Medium | High | Unit tests will verify that any feature flag
or plugin combination still results in our service operational. |
| [See more potential risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Index Management Index and index templates UI release_note:feature Makes this part of the condensed release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants