Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unified Search] Change phrase(s) comboboxes to async patterns #171427

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

cee-chen
Copy link
Member

@cee-chen cee-chen commented Nov 16, 2023

Summary

This PR does NOT address #158876, but helps reduce the confusion/cognitive dissonance of the async search results only matching on words from the start of the string, vs. EuiComboBox showing search results from anywhere in the string by default.

Please see https://eui.elastic.co/#/forms/combo-box#async for more documentation on async searching.

Before

image

After

image

Checklist

- since the suggestions/options are being async loaded from elasticsearch
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
unifiedSearch 213.7KB 213.8KB +96.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cee-chen cee-chen marked this pull request as ready for review November 16, 2023 18:52
@cee-chen cee-chen requested a review from a team as a code owner November 16, 2023 18:52
@cee-chen cee-chen added release_note:skip Skip the PR/issue when compiling release notes v8.12.0 labels Nov 16, 2023
Copy link
Contributor

@mbondyra mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good improvement! LGTM 👌🏼

@cee-chen
Copy link
Member Author

Thank you Marta!

@cee-chen cee-chen merged commit a723bd0 into elastic:main Nov 20, 2023
32 checks passed
@cee-chen cee-chen deleted the combobox-async-suggestions branch November 20, 2023 18:01
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants