Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RAM] Add cases functionality for ML #172217

Merged
merged 22 commits into from
Dec 22, 2023
Merged

[RAM] Add cases functionality for ML #172217

merged 22 commits into from
Dec 22, 2023

Conversation

XavierM
Copy link
Contributor

@XavierM XavierM commented Nov 29, 2023 •
edited by cnasikas
Loading

Summary

Fix -> #171150

Checklist

Release notes

Enable the alerts table for cases in the Stack Management.

@XavierM XavierM added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.12.0 labels Nov 29, 2023
@XavierM XavierM marked this pull request as ready for review December 5, 2023 22:03
@XavierM XavierM requested review from a team as code owners December 5, 2023 22:03
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@botelastic botelastic bot added the Team:obs-ux-management Observability Management User Experience Team label Dec 5, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@darnautov

This comment was marked as resolved.

Sign in to view
@XavierM XavierM added v8.13.0 and removed v8.12.0 labels Dec 6, 2023
@cnasikas cnasikas mentioned this pull request Dec 8, 2023
Merged
2 tasks
@cnasikas cnasikas added the ci:cloud-deploy Create or update a Cloud deployment label Dec 22, 2023
cnasikas
cnasikas approved these changes Dec 22, 2023
View reviewed changes
Copy link
Member

@cnasikas cnasikas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGMT. I tested and everything is working as expected. Some comments:

  • We should disable the status alert synching for stack cases as it is only supported by the Security solution. Enabling it for Stack will bypass the alerting RBAC model. Oy11 has it disabled. We should do it on this PR.
  • Given that we a) enable the alerts table in stack cases and b) we can attach ML alerts to stack cases it is worth it to put some release notes about it.
  • I still cannot navigate to the rule from the user actions. The rule's name is not a link. It can be done on another PR.

Stack

Screenshot 2023-12-22 at 3 05 38 PM

O11y

Screenshot 2023-12-22 at 3 07 50 PM

  • As an enhancement on another PR it would be nice if the alerts flyout opens when you navigate to the alerts table from the user action (only for single alerts). The alternative would be to have a generic flyout for stack alerts. This is something the cases team can work on in 8.13+. Wdyt?

  • I still found it a bit weird that from the same page in ML, I can see the solution picker when I attach an ML viz but when I attach an alert is not apparent to which solution the case will be created. Maybe we can show an information banner on the top of the modal. Again something that can be done as an improvement in future releases and something that the Cases team can work on in 8.13+. Wdyt?

x-pack/plugins/cases/public/components/user_actions/comment/show_alert.test.tsx Outdated Show resolved Hide resolved
x-pack/plugins/cases/public/components/user_actions/comment/show_alert.test.tsx Outdated Show resolved Hide resolved
x-pack/plugins/cases/public/components/app/index.tsx Outdated Show resolved Hide resolved
x-pack/plugins/cases/public/components/case_view/components/case_view_alerts.tsx Show resolved Hide resolved
x-pack/plugins/cases/public/containers/use_get_feature_ids.tsx Show resolved Hide resolved
...ns/ml/public/alerting/anomaly_detection_alerts_table/register_alerts_table_configuration.tsx Outdated Show resolved Hide resolved
@XavierM XavierM enabled auto-merge (squash) December 22, 2023 15:01
@XavierM XavierM added release_note:feature Makes this part of the condensed release notes and removed release_note:skip Skip the PR/issue when compiling release notes labels Dec 22, 2023
@kibana-ci
Copy link
Collaborator

kibana-ci commented Dec 22, 2023 •
edited
Loading

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
cases 714 715 +1
ml 1885 1886 +1
total +2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
cases 94 95 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cases 443.8KB 445.1KB +1.3KB
ml 3.6MB 3.6MB +468.0B
observability 587.2KB 587.3KB +21.0B
triggersActionsUi 1.4MB 1.4MB +108.0B
total +1.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
cases 167.8KB 168.2KB +364.0B
triggersActionsUi 104.7KB 105.0KB +320.0B
total +684.0B
Unknown metric groups

API count

id before after diff
cases 114 115 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

darnautov
darnautov approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

@XavierM XavierM merged commit 151ece6 into elastic:main Dec 22, 2023
23 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Dec 22, 2023
@cnasikas cnasikas added release_note:enhancement and removed release_note:feature Makes this part of the condensed release notes labels Jan 8, 2024
@cnasikas cnasikas mentioned this pull request Jan 8, 2024
Merged
2 tasks
cnasikas added a commit that referenced this pull request Jan 8, 2024
@cnasikas
[Cases] Unskip alerts tab functional test (#174454)
d99827d 
## Summary

PR #172217 enabled the alerts
table for cases in the stack management. All of our functional tests use
stack cases to test the various features. Now that the table is enabled
in stack cases we can test alerts. This PR unkskips a test that tests
the alerts tab.

Flaky test runner:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4788

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
clintandrewhall pushed a commit to clintandrewhall/kibana that referenced this pull request Jan 9, 2024
@cnasikas @clintandrewhall
[Cases] Unskip alerts tab functional test (elastic#174454)
0304c26 
## Summary

PR elastic#172217 enabled the alerts
table for cases in the stack management. All of our functional tests use
stack cases to test the various features. Now that the table is enabled
in stack cases we can test alerts. This PR unkskips a test that tests
the alerts tab.

Flaky test runner:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4788

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
delanni pushed a commit to delanni/kibana that referenced this pull request Jan 11, 2024
@cnasikas @delanni
[Cases] Unskip alerts tab functional test (elastic#174454)
869e1f8 
## Summary

PR elastic#172217 enabled the alerts
table for cases in the stack management. All of our functional tests use
stack cases to test the various features. Now that the table is enabled
in stack cases we can test alerts. This PR unkskips a test that tests
the alerts tab.

Flaky test runner:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4788

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
@cnasikas cnasikas mentioned this pull request Jan 12, 2024
Open
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
@cnasikas @CoenWarmer
[Cases] Unskip alerts tab functional test (elastic#174454)
cb94a5f 
## Summary

PR elastic#172217 enabled the alerts
table for cases in the stack management. All of our functional tests use
stack cases to test the various features. Now that the table is enabled
in stack cases we can test alerts. This PR unkskips a test that tests
the alerts tab.

Flaky test runner:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4788

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson left review comments

@darnautov darnautov darnautov approved these changes

@cnasikas cnasikas cnasikas approved these changes

@maryam-saeidi maryam-saeidi maryam-saeidi approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting ci:cloud-deploy Create or update a Cloud deployment release_note:enhancement Team:obs-ux-management Observability Management User Experience Team Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@XavierM @elasticmachine @darnautov @kibana-ci @peteharverson @cnasikas @maryam-saeidi @kibanamachine