Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cases] Unskip alerts tab functional test #174454

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

cnasikas
Copy link
Member

@cnasikas cnasikas commented Jan 8, 2024

Summary

PR #172217 enabled the alerts table for cases in the stack management. All of our functional tests use stack cases to test the various features. Now that the table is enabled in stack cases we can test alerts. This PR unkskips a test that tests the alerts tab.

Flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4788

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@cnasikas cnasikas added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Cases Cases feature v8.13.0 labels Jan 8, 2024
@cnasikas cnasikas self-assigned this Jan 8, 2024
@cnasikas cnasikas requested a review from a team as a code owner January 8, 2024 13:46
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

@cnasikas cnasikas added the release_note:skip Skip the PR/issue when compiling release notes label Jan 8, 2024
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @cnasikas

@cnasikas cnasikas merged commit d99827d into elastic:main Jan 8, 2024
29 checks passed
@cnasikas cnasikas deleted the unkskip_alert_table_tests branch January 8, 2024 17:35
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jan 8, 2024
clintandrewhall pushed a commit to clintandrewhall/kibana that referenced this pull request Jan 9, 2024
## Summary

PR elastic#172217 enabled the alerts
table for cases in the stack management. All of our functional tests use
stack cases to test the various features. Now that the table is enabled
in stack cases we can test alerts. This PR unkskips a test that tests
the alerts tab.

Flaky test runner:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4788

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
delanni pushed a commit to delanni/kibana that referenced this pull request Jan 11, 2024
## Summary

PR elastic#172217 enabled the alerts
table for cases in the stack management. All of our functional tests use
stack cases to test the various features. Now that the table is enabled
in stack cases we can test alerts. This PR unkskips a test that tests
the alerts tab.

Flaky test runner:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4788

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
## Summary

PR elastic#172217 enabled the alerts
table for cases in the stack management. All of our functional tests use
stack cases to test the various features. Now that the table is enabled
in stack cases we can test alerts. This PR unkskips a test that tests
the alerts tab.

Flaky test runner:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4788

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Cases Cases feature release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants