-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RAM][Observability] Add alert fields table to Observability flyout #174685
[RAM][Observability] Add alert fields table to Observability flyout #174685
Conversation
Pinging @elastic/response-ops (Team:ResponseOps) |
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
640e946
to
4d18719
Compare
993896f
to
8a44f14
Compare
8a44f14
to
e6e28f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -41,16 +44,16 @@ export function AlertsFlyout({ | |||
if (!alertData) { | |||
alertData = decoratedAlerts?.find((a) => a.fields[ALERT_UUID] === selectedAlertId) as TopAlert; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not related to this PR but this logic seems to be related to the parent component instead of here, it is a bit confusing why we have are passing both alerts
and alert
to this component. 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I too noticed this, it seems like the intention was to support both retrieving the alert form the list fetched by the table and receive a single one too even though the first option seems unused as of now
x-pack/plugins/observability/public/pages/cases/components/cases.tsx
Outdated
Show resolved
Hide resolved
} | ||
|
||
export const useFetchAlertDetail = (id: string): [boolean, TopAlert | null] => { | ||
export interface AlertDetail { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
export interface AlertDetail { | |
export interface AlertData { // Or maybe AlertInstance | |
formatted: TopAlert; | |
raw: EcsFieldsResponse; | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the improvement ❤️
18499cf
to
08ffa7c
Compare
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
* main: (520 commits) Update Kibana code editor dependencies (#171720) [SLOs] Hide view in app in slo alerts table in slo details page (#175441) [api-docs] 2024-01-25 Daily api_docs build (#175502) [DOCS] Add buildkite links to doc preview comments (#175463) skip flaky suite (#175443) [Security Solution][Timeline] refactor timeline modal save timeline button (#175343) [RAM] Stack Management::Rules loses user selections when navigating back (#174954) [Security Solution][Timeline] refactor timeline modal attach to case button (#175163) Upgrade EUI to v92.1.1 (#174955) [Fleet]: Beta label is shown inconsistently while selecting proxy under Fleet settings. (#170634) [Cloud Security] Rules Combo Box filters Custom component (#175175) skip flaky suite (#175407) [Security Solution][Timeline] refactor timeline modal open timeline button (#175335) [Embedded Console] Introduce kbnSolutionNavOffset CSS variable (#175348) [Console] disable access to embedded console without dev tools capability (#175321) fix(x-pack/reporting): use FIPS-compliant ID generator `uuidv4` in Reporting plugin (#174809) [Security Solution] Data quality dashboard persistence (#173185) [RAM][Observability] Add alert fields table to Observability flyout (#174685) test: add missing await for connector table disappearance (#175430) [RAM][Maintenance Window] Fix maintenance window FE types and transforms (#173888) ...
…lastic#174685) ## Summary Adds the alert fields table from elastic#172830 to Observability alert flyouts (triggered by the `View alert details` action). ![image](https://github.com/elastic/kibana/assets/18363145/7e10517e-a5b6-497a-91c8-5bc2bc88ad69) ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Xavier Mouligneau <xavier.mouligneau@elastic.co>
…lastic#174685) ## Summary Adds the alert fields table from elastic#172830 to Observability alert flyouts (triggered by the `View alert details` action). ![image](https://github.com/elastic/kibana/assets/18363145/7e10517e-a5b6-497a-91c8-5bc2bc88ad69) ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Xavier Mouligneau <xavier.mouligneau@elastic.co>
…lastic#174685) ## Summary Adds the alert fields table from elastic#172830 to Observability alert flyouts (triggered by the `View alert details` action). ![image](https://github.com/elastic/kibana/assets/18363145/7e10517e-a5b6-497a-91c8-5bc2bc88ad69) ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Xavier Mouligneau <xavier.mouligneau@elastic.co>
Summary
Adds the alert fields table from #172830 to Observability alert flyouts (triggered by the
View alert details
action).Checklist