-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add missing await for connector table disappearance #175430
Conversation
x-pack/test_serverless/functional/page_objects/svl_search_connectors_page.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes LGTM.
Quick question: is there a better way to test these FTR tests to avoid the failures like this in future?
Reason I am asking is, I did not see these errors when I was testing locally, with my PR CIs, and MKI tests. and I am worried if I have missed any aspect of testing here. Thanks in advance!
@saarikabhasi - the only thing I can think of is the flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner You can set up your proposed changes, then run several retries on the same case, to see if it still occasionally happens or is quite reliably stable. |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
* main: (520 commits) Update Kibana code editor dependencies (#171720) [SLOs] Hide view in app in slo alerts table in slo details page (#175441) [api-docs] 2024-01-25 Daily api_docs build (#175502) [DOCS] Add buildkite links to doc preview comments (#175463) skip flaky suite (#175443) [Security Solution][Timeline] refactor timeline modal save timeline button (#175343) [RAM] Stack Management::Rules loses user selections when navigating back (#174954) [Security Solution][Timeline] refactor timeline modal attach to case button (#175163) Upgrade EUI to v92.1.1 (#174955) [Fleet]: Beta label is shown inconsistently while selecting proxy under Fleet settings. (#170634) [Cloud Security] Rules Combo Box filters Custom component (#175175) skip flaky suite (#175407) [Security Solution][Timeline] refactor timeline modal open timeline button (#175335) [Embedded Console] Introduce kbnSolutionNavOffset CSS variable (#175348) [Console] disable access to embedded console without dev tools capability (#175321) fix(x-pack/reporting): use FIPS-compliant ID generator `uuidv4` in Reporting plugin (#174809) [Security Solution] Data quality dashboard persistence (#173185) [RAM][Observability] Add alert fields table to Observability flyout (#174685) test: add missing await for connector table disappearance (#175430) [RAM][Maintenance Window] Fix maintenance window FE types and transforms (#173888) ...
…5430) ## Summary There's been a few recent failures in this test: https://buildkite.com/elastic/kibana-on-merge/builds/40574#018d3a8b-fe46-410e-a2b9-51eff916ddcd https://buildkite.com/elastic/kibana-on-merge/builds/40576#018d3b7a-1be4-499d-9b42-e10d860ee637 I don't know if this small addition will make any difference in the test timing out, but it will probably avoid the `Unhandled Promise rejection detected:` kind of errors, since we'll now wait for the expression. cc: @saarikabhasi
Friendly reminder: Looks like this PR hasn’t been backported yet. |
…5430) ## Summary There's been a few recent failures in this test: https://buildkite.com/elastic/kibana-on-merge/builds/40574#018d3a8b-fe46-410e-a2b9-51eff916ddcd https://buildkite.com/elastic/kibana-on-merge/builds/40576#018d3b7a-1be4-499d-9b42-e10d860ee637 I don't know if this small addition will make any difference in the test timing out, but it will probably avoid the `Unhandled Promise rejection detected:` kind of errors, since we'll now wait for the expression. cc: @saarikabhasi
…5430) ## Summary There's been a few recent failures in this test: https://buildkite.com/elastic/kibana-on-merge/builds/40574#018d3a8b-fe46-410e-a2b9-51eff916ddcd https://buildkite.com/elastic/kibana-on-merge/builds/40576#018d3b7a-1be4-499d-9b42-e10d860ee637 I don't know if this small addition will make any difference in the test timing out, but it will probably avoid the `Unhandled Promise rejection detected:` kind of errors, since we'll now wait for the expression. cc: @saarikabhasi
Friendly reminder: Looks like this PR hasn’t been backported yet. |
5 similar comments
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Summary
There's been a few recent failures in this test:
https://buildkite.com/elastic/kibana-on-merge/builds/40574#018d3a8b-fe46-410e-a2b9-51eff916ddcd
https://buildkite.com/elastic/kibana-on-merge/builds/40576#018d3b7a-1be4-499d-9b42-e10d860ee637
I don't know if this small addition will make any difference in the test timing out, but it will probably avoid the
Unhandled Promise rejection detected:
kind of errors, since we'll now wait for the expression.cc: @saarikabhasi