Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Serverless][FTR] Fix flaky viewer_role_login test for MKI #178522

Merged
merged 8 commits into from
Mar 22, 2024
Merged

[Serverless][FTR] Fix flaky viewer_role_login test for MKI #178522

merged 8 commits into from
Mar 22, 2024

Conversation

wayneseymour
Copy link
Member

@wayneseymour wayneseymour commented Mar 12, 2024 •
edited
Loading

Resolves: #178403

Drop wrapper div and place data test subj within the eui component, per docs.

Also:

  • add calls to wait until loading has finished
  • add 10_000 timeouts to test subects calls

@wayneseymour wayneseymour self-assigned this Mar 12, 2024
@wayneseymour
Copy link
Member Author

/ci

@wayneseymour wayneseymour force-pushed the fix-flaky-viewer-role-login-test-for-mki branch from e21c903 to 6b55f72 Compare March 13, 2024 10:05
@wayneseymour wayneseymour marked this pull request as ready for review March 14, 2024 17:07
@wayneseymour wayneseymour requested a review from a team as a code owner March 14, 2024 17:07
@wayneseymour
Copy link
Member Author

@elasticmachine merge upstream

@kc13greiner kc13greiner self-requested a review March 14, 2024 17:37
kc13greiner
kc13greiner approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@kc13greiner kc13greiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wayneseymour wayneseymour added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Mar 15, 2024
@wayneseymour
Copy link
Member Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
security 65.1KB 65.0KB -23.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @wayneseymour

pheyos
pheyos approved these changes Mar 22, 2024
View reviewed changes
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Let's hope this fixes the flakiness 🤞

@wayneseymour wayneseymour merged commit 6dcfbd7 into elastic:main Mar 22, 2024
17 checks passed
@wayneseymour wayneseymour deleted the fix-flaky-viewer-role-login-test-for-mki branch March 22, 2024 10:09
@thomheymann thomheymann mentioned this pull request Mar 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pheyos pheyos pheyos approved these changes

@kc13greiner kc13greiner kc13greiner approved these changes

Assignees

@wayneseymour wayneseymour

Labels
backport:skip This commit does not require backporting FTR release_note:skip Skip the PR/issue when compiling release notes v8.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix flaky viewer_role_login test for MKI
5 participants
@wayneseymour @kibana-ci @pheyos @kc13greiner @kibanamachine