Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Serverless][FTR] Fix flaky viewer_role_login test for MKI #178522

Merged
merged 8 commits into from
Mar 22, 2024
Merged

[Serverless][FTR] Fix flaky viewer_role_login test for MKI #178522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6b55f72
[Serverless][FTR] Fix flaky viewer_role_login test for MKI
wayneseymour Mar 12, 2024
b3de7e9
[Serverless][FTR] Fix flaky viewer_role_login test for MKI
wayneseymour Mar 12, 2024
0e805ce
Merge branch 'main' into fix-flaky-viewer-role-login-test-for-mki
kibanamachine Mar 14, 2024
a256719
Merge branch 'main' into fix-flaky-viewer-role-login-test-for-mki
kibanamachine Mar 20, 2024
ba478cd
Merge branch 'fix-flaky-viewer-role-login-test-for-mki' of github.com…
wayneseymour Mar 20, 2024
7d60143
Merge branch 'main' of github.com:elastic/kibana into fix-flaky-viewe…
wayneseymour Mar 20, 2024
f149155
Merge branch 'main' of github.com:elastic/kibana into fix-flaky-viewe…
wayneseymour Mar 21, 2024
0b337a2
Increase timeouts and wait until loading is finished.
wayneseymour Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 12 additions & 13 deletions x-pack/plugins/security/public/nav_control/nav_control_component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,19 +179,18 @@ export const SecurityNavControl: FunctionComponent<SecurityNavControlProps> = ({
panelPaddingSize="none"
buffer={0}
>
<div data-test-subj="userMenu">
<EuiContextMenu
className="chrNavControl__userMenu"
initialPanelId={0}
panels={[
{
id: 0,
title: displayName,
content: <ContextMenuContent items={items} />,
},
]}
/>
</div>
<EuiContextMenu
className="chrNavControl__userMenu"
initialPanelId={0}
panels={[
{
id: 0,
title: displayName,
content: <ContextMenuContent items={items} />,
},
]}
data-test-subj="userMenu"
/>
</EuiPopover>
);
};
15 changes: 11 additions & 4 deletions x-pack/test_serverless/functional/page_objects/svl_common_page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export function SvlCommonPageProvider({ getService, getPageObjects }: FtrProvide
const testSubjects = getService('testSubjects');
const find = getService('find');
const config = getService('config');
const pageObjects = getPageObjects(['security', 'common']);
const pageObjects = getPageObjects(['security', 'common', 'header']);
const retry = getService('retry');
const deployment = getService('deployment');
const log = getService('log');
Expand Down Expand Up @@ -229,15 +229,22 @@ export function SvlCommonPageProvider({ getService, getPageObjects }: FtrProvide
},

async clickUserAvatar() {
await testSubjects.click('userMenuAvatar');
await pageObjects.header.waitUntilLoadingHasFinished();
await testSubjects.click('userMenuAvatar', 10_000);
},

async assertUserAvatarExists() {
await testSubjects.existOrFail('userMenuAvatar');
await pageObjects.header.waitUntilLoadingHasFinished();
await testSubjects.existOrFail('userMenuAvatar', {
timeout: 10_000,
});
},

async assertUserMenuExists() {
await testSubjects.existOrFail('userMenu');
await pageObjects.header.waitUntilLoadingHasFinished();
await testSubjects.existOrFail('userMenu', {
timeout: 10_000,
});
},
};
}