[CI] Validate CDN assets in typescript #181733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delanni
added
Team:Operations
|
Pinging @elastic/kibana-operations (Team:Operations) |
jbudz
approved these changes
Apr 26, 2024
delanni
force-pushed
the
validate-cdn-assets-in-typescript
branch
from
b3d0525
to
92fa9c7
Compare
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
To update your PR or re-run it, just comment with: |
delanni
added a commit
that referenced
this pull request
May 3, 2024
## Summary Related to #181733 - I didn't check, and axios rejects requests' promises that don't result in `2xx`. This PR wraps the attempt in a try-catch to be able to retry.
yuliacech
pushed a commit
to yuliacech/kibana
that referenced
this pull request
May 3, 2024
## Summary Replaces bash/curl validation with Typescript, to see if it's any faster or more reliable This was a successful run: https://buildkite.com/elastic/kibana-artifacts-container-image/builds/11689#018f1a82-bf0f-4cd4-ac34-4f822d73a17b - the validation seems to have taken place in 5 seconds.
yuliacech
pushed a commit
to yuliacech/kibana
that referenced
this pull request
May 3, 2024
## Summary Related to elastic#181733 - I didn't check, and axios rejects requests' promises that don't result in `2xx`. This PR wraps the attempt in a try-catch to be able to retry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replaces bash/curl validation with Typescript, to see if it's any faster or more reliable
This was a successful run: https://buildkite.com/elastic/kibana-artifacts-container-image/builds/11689#018f1a82-bf0f-4cd4-ac34-4f822d73a17b - the validation seems to have taken place in 5 seconds (instead of 15m+)