[CI] Fix axios requests to allow retry #182386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delanni
added
release_note:skip
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
jbudz
approved these changes
May 2, 2024
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
yuliacech
pushed a commit
to yuliacech/kibana
that referenced
this pull request
May 3, 2024
## Summary Related to elastic#181733 - I didn't check, and axios rejects requests' promises that don't result in `2xx`. This PR wraps the attempt in a try-catch to be able to retry.
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
kibanamachine
added
the
backport missing
delanni
added
backport:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to #181733 - I didn't check, and axios rejects requests' promises that don't result in
2xx.This PR wraps the attempt in a try-catch to be able to retry.